Ironruby core - Apr 2009 - platform_is fix needed ?

Hi,

system_spec.rb fails all its tests because the before(:each) calls
platform_is(:windows) without a block, while it appears to require
one.

Can I just fix this specific spec by using platform_is +
platform_is_not instead, or is it better to fix platform_is to allow
calls without blocks ? I''d prefer the former because it sounds
simpler.

what do you think ?

-- Thibaut

I''m doing an update to the specs right now, so can we wait until that
goes through, then see if it is still an issue?

Thanks


-----Original Message-----
From: Thibaut Barr?re <thibaut.barrere at gmail.com>
Sent: April 17, 2009 1:09 PM
To: ironruby-core <ironruby-core at rubyforge.org>
Subject: [Ironruby-core] platform_is fix needed ?


Hi,

system_spec.rb fails all its tests because the before(:each) calls
platform_is(:windows) without a block, while it appears to require
one.

Can I just fix this specific spec by using platform_is +
platform_is_not instead, or is it better to fix platform_is to allow
calls without blocks ? I''d prefer the former because it sounds
simpler.

what do you think ?

-- Thibaut
_______________________________________________
Ironruby-core mailing list
Ironruby-core at rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core

> I''m doing an update to the specs right now, so can we wait until
that goes through, then see if it is still an issue?
Sure. If it still fails after the update, I pushed a fix here:
http://github.com/thbar/ironruby/commit/87a9613939942ab50ae5a152c2f84a61e55d99f5
(one remaining failure after that).

-- Thibaut