Ironruby core - Apr 2009 - [patch] Fixes for Array#=

Hi,

I''ve just committed my first patch to IronRuby on my forked
repository, this is the URL for the diff:

http://github.com/nrk/ironruby/commit/7b819d65bd26c0642f88ab30e8ccc17d9e625fcf

This patch fixes 4 failures in core/array/element_set_spec.rb, namely:

Array#[]= inserts the given elements with [range] which the range is zero-width
Array#[]= inserts the given elements with [start, length] which length is zero
Array#[]= inserts the given elements with [range] which the range has
negative width
Array#[]= with [index, count] inserts other section in place defined by idx

The patch itself is nothing special, but it is needed to run
ironruby-hpricot out of the box on IronRuby.

Thanks,
Daniele

-- 
Daniele Alessandri
http://www.clorophilla.net/blog/
http://twitter.com/JoL1hAHN

Changes look good! Thanks for the patch, Daniele!

Note that the tags should be deleted once the bug is fixed. That way, running
irtests.bat will run the specs you have just enabled and ensure that you really
have fixed the issue. Deleting the tags should be in the same commit as the
source code fix.

I have deleted the tags and pushed it to 
http://github.com/shri/ironruby/commit/95d1a8410d2bbabd37e27314da1c504cc486a711

Thanks,
Shri

-----Original Message-----
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at
rubyforge.org] On Behalf Of Daniele Alessandri
Sent: Tuesday, April 14, 2009 7:46 AM
To: ironruby-core at rubyforge.org
Subject: [Ironruby-core] [patch] Fixes for Array#[]
Hi,

I''ve just committed my first patch to IronRuby on my forked
repository, this is the URL for the diff:

http://github.com/nrk/ironruby/commit/7b819d65bd26c0642f88ab30e8ccc17d9e625fcf

This patch fixes 4 failures in core/array/element_set_spec.rb, namely:

Array#[]= inserts the given elements with [range] which the range is zero-width
Array#[]= inserts the given elements with [start, length] which length is zero
Array#[]= inserts the given elements with [range] which the range has
negative width
Array#[]= with [index, count] inserts other section in place defined by idx

The patch itself is nothing special, but it is needed to run
ironruby-hpricot out of the box on IronRuby.

Thanks,
Daniele

-- 
Daniele Alessandri
http://www.clorophilla.net/blog/
http://twitter.com/JoL1hAHN
_______________________________________________
Ironruby-core mailing list
Ironruby-core at rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core

Cool. More patches to come :-)
I''ll make sure to include changes/removals of the tags files in the
next commits.


On Tue, Apr 14, 2009 at 23:18, Shri Borde <Shri.Borde at microsoft.com>
wrote:
> Changes look good! Thanks for the patch, Daniele!
>
> Note that the tags should be deleted once the bug is fixed. That way,
running irtests.bat will run the specs you have just enabled and ensure that you
really have fixed the issue. Deleting the tags should be in the same commit as
the source code fix.
>
> I have deleted the tags and pushed it to
>
http://github.com/shri/ironruby/commit/95d1a8410d2bbabd37e27314da1c504cc486a711
>
> Thanks,
> Shri
>
-- 
Daniele Alessandri
http://www.clorophilla.net/blog/
http://twitter.com/JoL1hAHN