Ironruby core - Apr 2009 - [patch] agdlr: Fix for Package.NormalizePath

Hey,

This patch is part of a bunch I sent to Jimmy privately. But they
haven''t been applied, so am resending them here for review.

Package.NormalizePath transforms paths in the xap that use \ as a
directory separator to /. So use \ directly, instead of expecting it
to be the system directory separator.

Thanks,

-- 
Jb Evain  <jb at nurv.fr>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Package.patch
Type: application/octet-stream
Size: 700 bytes
Desc: not available
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20090401/61830ee2/attachment.obj>

Hey Jimmy,

On 4/1/09, Jimmy Schementi <Jimmy.Schementi at microsoft.com>
wrote:
> They are applied in the dev/mono branch, and I can apply them for 0.5.1.
Yeah, that would be cool. Is there any reason for not merging them in origin?

-- 
Jb Evain  <jb at nurv.fr>

They are applied in the dev/mono branch, and I can apply them for 0.5.1.

~Jimmy
Sent from my phone

On Apr 1, 2009, at 8:01 AM, "Jb Evain" <jb at nurv.fr> wrote:
> Hey,
>
> This patch is part of a bunch I sent to Jimmy privately. But they
> haven''t been applied, so am resending them here for review.
>
> Package.NormalizePath transforms paths in the xap that use \ as a
> directory separator to /. So use \ directly, instead of expecting it
> to be the system directory separator.
>
> Thanks,
>
> --
> Jb Evain  <jb at nurv.fr>
> <Package.patch>
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core

No major reason ... they are small enough to be considered bug reports, so I
have no problem making the fixes. FYI, I have to be more careful with
substantial  improvements/features, for the same reason that IronRuby.dll or the
DLR can''t accept contributions, but I hope to have a clearer message on
contributions in the future.

I don''t have moonlight on any of my machines to test it out (though I
trust you =P). Can you point me at instructions for setting up Moonlight? I have
a Ubuntu VM , or is there another distro I should use since you''re
testing more on it (SUSE I assume?).

~js
> -----Original Message-----
> From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> bounces at rubyforge.org] On Behalf Of Jb Evain
> Sent: Wednesday, April 01, 2009 11:02 AM
> To: ironruby-core at rubyforge.org
> Subject: Re: [Ironruby-core] [patch] agdlr: Fix for
> Package.NormalizePath
>
> Hey Jimmy,
>
> On 4/1/09, Jimmy Schementi <Jimmy.Schementi at microsoft.com> wrote:
> > They are applied in the dev/mono branch, and I can apply them for
> 0.5.1.
>
> Yeah, that would be cool. Is there any reason for not merging them in
> origin?
>
> --
> Jb Evain  <jb at nurv.fr>
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core

On 4/1/09, Jimmy Schementi <Jimmy.Schementi at microsoft.com>
wrote:
> No major reason ... they are small enough to be considered bug reports, so
I have no problem making the fixes. FYI, I have to be more careful with
substantial  improvements/features, for the same reason that IronRuby.dll or the
DLR can''t accept contributions, but I hope to have a clearer message on
contributions in the future.
Cool. I don''t particularly care that my own personal patch is applied,
I care about having the feature working. So if you guys prefer bug
reports I can submit bugs reports.
>  I don''t have moonlight on any of my machines to test it out
(though I trust you =P). Can you point me at instructions for setting up
Moonlight? I have a Ubuntu VM , or is there another distro I should use since
you''re testing more on it (SUSE I assume?).
I use openSUSE, but there''s no reason you couldn''t make it
work
Ubuntu. You would have to setup Mono from svn, I suggest using:

http://www.mono-project.com/Parallel_Mono_Environments

There''s some instructions for Moonlight here:

http://www.mono-project.com/Moonlight#Developing_Moonlight

But it''s not always up to date as we are currently changing things a
lot. Don''t hesitate to ask on moonlight-list  for help, or contact me
directly.

http://lists.ximian.com/mailman/listinfo/moonlight-list

-- 
Jb Evain  <jb at nurv.fr>