thr3ads.net - Ironruby core - [Ironruby-core] Review: Marshal bug [Mar 2009]

If this information is useful, please help other people find it:
Share via:

Shri Borde

2009-Mar-26 23:34 UTC

[Ironruby-core] Review: Marshal bug

GitDiff.bat a90a89465f3b9c178507f83e4797481463989059
119b056332b270164eaf2b1f9cd2956387e38636
http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636

YAML should allow spaces. eg the trailing \s\t in YAML.load("!timestamp
''2009-03-22 00:00:00\s\t''") is allowed
Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe
is not in the path
File.expand_path("~") should throw ArgumentError is HOME is not set


 *  
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-0>
 *  
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-1>
 *  
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rb<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-2>
 *  
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixtures/marshal_data.rb<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-3>
 *  
Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load_spec.rb<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-4>
 *  
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-5>
 *  
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Marshal.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-6>
 *  
Merlin/Main/Languages/Ruby/Scripts/bin/igem.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7>
 *  
Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8>
 *  
Merlin/Main/Languages/Ruby/Scripts/bin/irails.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9>
 *  
Merlin/Main/Languages/Ruby/Scripts/bin/irake.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10>
 *  
Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11>
 *  
Merlin/Main/Languages/Ruby/Scripts/bin/iri.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12>

Thanks,
Shri

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20090326/74910ff2/attachment.html>

Tomas Matousek

2009-Mar-27 19:59 UTC

head link

[Ironruby-core] Review: Marshal bug

Library changes look good.

Tomas

From: Shri Borde
Sent: Thursday, March 26, 2009 4:35 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Review: Marshal bug

GitDiff.bat a90a89465f3b9c178507f83e4797481463989059
119b056332b270164eaf2b1f9cd2956387e38636
http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636

YAML should allow spaces. eg the trailing \s\t in YAML.load("!timestamp
''2009-03-22 00:00:00\s\t''") is allowed
Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe
is not in the path
File.expand_path("~") should throw ArgumentError is HOME is not set


 *  
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-0>
 *  
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-1>
 *  
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rb<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-2>
 *  
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixtures/marshal_data.rb<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-3>
 *  
Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load_spec.rb<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-4>
 *  
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-5>
 *  
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Marshal.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-6>
 *  
Merlin/Main/Languages/Ruby/Scripts/bin/igem.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7>
 *  
Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8>
 *  
Merlin/Main/Languages/Ruby/Scripts/bin/irails.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9>
 *  
Merlin/Main/Languages/Ruby/Scripts/bin/irake.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10>
 *  
Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11>
 *  
Merlin/Main/Languages/Ruby/Scripts/bin/iri.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12>

Thanks,
Shri

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20090327/67c93788/attachment-0001.html>

Jim Deville

2009-Mar-27 20:18 UTC

head link

[Ironruby-core] Review: Marshal bug

Test and batch changes look good.

JD

From: Tomas Matousek
Sent: Friday, March 27, 2009 12:59 PM
To: Shri Borde; IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Review: Marshal bug

Library changes look good.

Tomas

From: Shri Borde
Sent: Thursday, March 26, 2009 4:35 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Review: Marshal bug

GitDiff.bat a90a89465f3b9c178507f83e4797481463989059
119b056332b270164eaf2b1f9cd2956387e38636
http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636

YAML should allow spaces. eg the trailing \s\t in YAML.load("!timestamp
''2009-03-22 00:00:00\s\t''") is allowed
Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe
is not in the path
File.expand_path("~") should throw ArgumentError is HOME is not set


  *  
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-0>
  *  
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-1>
  *  
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rb<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-2>
  *  
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixtures/marshal_data.rb<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-3>
  *  
Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load_spec.rb<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-4>
  *  
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-5>
  *  
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Marshal.cs<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-6>
  *  
Merlin/Main/Languages/Ruby/Scripts/bin/igem.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-7>
  *  
Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-8>
  *  
Merlin/Main/Languages/Ruby/Scripts/bin/irails.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-9>
  *  
Merlin/Main/Languages/Ruby/Scripts/bin/irake.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-10>
  *  
Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-11>
  *  
Merlin/Main/Languages/Ruby/Scripts/bin/iri.bat<http://github.com/shri/ironruby/commit/119b056332b270164eaf2b1f9cd2956387e38636#diff-12>

Thanks,
Shri

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20090327/7eb54a5a/attachment.html>

Ironruby core - Mar 2009 - Review: Marshal bug

[Ironruby-core] Review: Marshal bug

[Ironruby-core] Review: Marshal bug

[Ironruby-core] Review: Marshal bug