Jb Evain
2009-Mar-03 12:46 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
Hey, I spent some time investigating why on Mono ir.exe (last git revision) doesn''t print the result of evaluations. The issue lies in the processing of new lines in Microsoft.Scripting.Core.Hosting.Shell.CommandLine. The code is appending \n as terminating new lines, but checks for the presence of Environment.NewLine inside the evaluated string. Obviously it works only if Environment.NewLine is \r\n, and not \n. Attached is a suggested patch, addressing the issue. -- Jb Evain <jb at nurv.fr> -------------- next part -------------- A non-text attachment was scrubbed... Name: cmd_line.patch Type: text/x-patch Size: 2026 bytes Desc: not available URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/157c44dc/attachment-0001.bin>
Ivan Porto Carrero
2009-Mar-03 14:22 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
Great i''ll add those to the mono branch :) On Tue, Mar 3, 2009 at 1:46 PM, Jb Evain <jb at nurv.fr> wrote:> Hey, > > I spent some time investigating why on Mono ir.exe (last git revision) > doesn''t print the result of evaluations. > > The issue lies in the processing of new lines in > Microsoft.Scripting.Core.Hosting.Shell.CommandLine. > > The code is appending \n as terminating new lines, but checks for the > presence of Environment.NewLine inside the evaluated string. Obviously > it works only if Environment.NewLine is \r\n, and not \n. > > Attached is a suggested patch, addressing the issue. > > -- > Jb Evain <jb at nurv.fr> > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/5d023639/attachment.html>
Thibaut Barrère
2009-Mar-03 14:34 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
> Great i''ll add those to the mono branch :)Sorry for the obvious question: where is the mono branch ? I think I reached a point where I need to build it myself (and I want to stay on Mac for the moment :-). -- Thibaut
Ivan Porto Carrero
2009-Mar-03 14:46 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
http://github.com/mletterle/ironruby cd src git clone git://github.com/mletterle/ironruby.git<http://github.com/casualjim/ironruby.git> cd ironruby git checkout -b linux git pull origin linux ./build (you may have to chmod +x that build file first) or sh build if you put ~/bin in your PATH variable it will build, package and deploy an ironruby version. I''m still updating the build though at the moment. If you join the IRC channel you can see my check in coming through. I''ll also send a mail to this mailinglist when I''m done :). On Tue, Mar 3, 2009 at 3:34 PM, Thibaut Barr?re <thibaut.barrere at gmail.com>wrote:> > Great i''ll add those to the mono branch :) > > Sorry for the obvious question: where is the mono branch ? > > I think I reached a point where I need to build it myself (and I want > to stay on Mac for the moment :-). > > -- Thibaut > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/efa72a51/attachment.html>
Jb Evain
2009-Mar-03 16:10 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
Hey Ivan, On 3/3/09, Ivan Porto Carrero <ivan at flanders.co.nz> wrote:> Great i''ll add those to the mono branch :)Do you keep a log of what goes into this branch? Does the branch contain any workaround for a Mono issue that has not been solved, or reported? -- Jb Evain <jb at nurv.fr>
Shri Borde
2009-Mar-03 17:45 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
I have updated the instructions at http://wiki.github.com/ironruby/ironruby#wiki_building-mono. Except for the build step. The wiki says to use ?rake compile mono=1?. Feel free to update the wiki if there is a better way to do the build. From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Ivan Porto Carrero Sent: Tuesday, March 03, 2009 6:47 AM To: ironruby-core at rubyforge.org Subject: Re: [Ironruby-core] [patch] Issue in DLR.CommandLine with new lines http://github.com/mletterle/ironruby cd src git clone git://github.com/mletterle/ironruby.git<http://github.com/casualjim/ironruby.git> cd ironruby git checkout -b linux git pull origin linux ./build (you may have to chmod +x that build file first) or sh build if you put ~/bin in your PATH variable it will build, package and deploy an ironruby version. I''m still updating the build though at the moment. If you join the IRC channel you can see my check in coming through. I''ll also send a mail to this mailinglist when I''m done :). On Tue, Mar 3, 2009 at 3:34 PM, Thibaut Barr?re <thibaut.barrere at gmail.com<mailto:thibaut.barrere at gmail.com>> wrote:> Great i''ll add those to the mono branch :)Sorry for the obvious question: where is the mono branch ? I think I reached a point where I need to build it myself (and I want to stay on Mac for the moment :-). -- Thibaut _______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org<mailto:Ironruby-core at rubyforge.org> http://rubyforge.org/mailman/listinfo/ironruby-core -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/40804011/attachment.html>
Ivan Porto Carrero
2009-Mar-03 17:49 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
Perhaps..
Most of the fixes in that branch have to do with type inference and missing
parameterless constructors.
public class MyType{
}
Compiles on MS.NET but not on Mono.
public class MyType{
public MyType(){
}
}
There is an issue though around delegates but this has to do with generic
type parameter inference again.
And the reason I still didn''t check in today is because gmcs is
complaining
about a file being defined twice but I can''t find it anywhere :(.
Interpreter is the name of the file, when I look at the class descriptions
most of them have been defined as partial classes _and_ it does build on
windows :)
I had a merge conflict on Microsoft.Scripting.Build.csproj but i thought
that had to do with line endings as I couldn''t spot the conflict
anywhere in
the file and when I threw the 2 files in a file comparer line endings were
the only differences.
I''ll try to chase up that one problem with delegates
On Tue, Mar 3, 2009 at 5:10 PM, Jb Evain <jb at nurv.fr> wrote:
> Hey Ivan,
>
> On 3/3/09, Ivan Porto Carrero <ivan at flanders.co.nz> wrote:
> > Great i''ll add those to the mono branch :)
>
> Do you keep a log of what goes into this branch? Does the branch
> contain any workaround for a Mono issue that has not been solved, or
> reported?
>
> --
> Jb Evain <jb at nurv.fr>
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/a27f8f84/attachment.html>
Ivan Porto Carrero
2009-Mar-03 17:56 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
Cool :) I went ahead and added the bit about the build script, also removed the instruction with the patch file as that is not necessary anymore. On Tue, Mar 3, 2009 at 6:45 PM, Shri Borde <Shri.Borde at microsoft.com> wrote:> I have updated the instructions at > http://wiki.github.com/ironruby/ironruby#wiki_building-mono. Except for > the build step. The wiki says to use ?rake compile mono=1?. Feel free to > update the wiki if there is a better way to do the build. > > > > *From:* ironruby-core-bounces at rubyforge.org [mailto: > ironruby-core-bounces at rubyforge.org] *On Behalf Of *Ivan Porto Carrero > *Sent:* Tuesday, March 03, 2009 6:47 AM > *To:* ironruby-core at rubyforge.org > *Subject:* Re: [Ironruby-core] [patch] Issue in DLR.CommandLine with new > lines > > > > http://github.com/mletterle/ironruby > > cd src > > git clone git://github.com/mletterle/ironruby.git<http://github.com/casualjim/ironruby.git> > cd ironruby > git checkout -b linux > git pull origin linux > > ./build (you may have to chmod +x that build file first) or sh build > > if you put ~/bin in your PATH variable it will build, package and deploy an > ironruby version. I''m still updating the build though at the moment. If you > join the IRC channel you can see my check in coming through. I''ll also send > a mail to this mailinglist when I''m done :). > > > > > On Tue, Mar 3, 2009 at 3:34 PM, Thibaut Barr?re < > thibaut.barrere at gmail.com> wrote: > > > Great i''ll add those to the mono branch :) > > Sorry for the obvious question: where is the mono branch ? > > I think I reached a point where I need to build it myself (and I want > to stay on Mac for the moment :-). > > -- Thibaut > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core > > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/e2604b86/attachment.html>
Jb Evain
2009-Mar-03 18:08 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
Hey, On 3/3/09, Ivan Porto Carrero <ivan at flanders.co.nz> wrote:> public class MyType{ > } > > Compiles on MS.NET but not on Mono.Huh? It does compile on Mono. It must be a different issue.> There is an issue though around delegates but this has to do with generic > type parameter inference again.Have you filed a bug or extracted a test case? Anyway, I''ll make sure IronRuby compiles fine with gmcs. -- Jb Evain <jb at nurv.fr>
Ivan Porto Carrero
2009-Mar-03 18:09 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
http://github.com/casualjim/ironruby/commit/1d06f3dead4de74f3529c8c028a655e0fc94a7a4#diff-4 Mono didn''t want to cast the Expression<T> to a LambdaExpression :) On that page you can find most of the code fixes I made to make IR compile on mono. I''ve just repeated those in Michaels branch and just have to delete my fork at some stage :) On Tue, Mar 3, 2009 at 6:56 PM, Ivan Porto Carrero <ivan at flanders.co.nz>wrote:> Cool :) I went ahead and added the bit about the build script, also > removed the instruction with the patch file as that is not necessary > anymore. > > > > > On Tue, Mar 3, 2009 at 6:45 PM, Shri Borde <Shri.Borde at microsoft.com>wrote: > >> I have updated the instructions at >> http://wiki.github.com/ironruby/ironruby#wiki_building-mono. Except for >> the build step. The wiki says to use ?rake compile mono=1?. Feel free to >> update the wiki if there is a better way to do the build. >> >> >> >> *From:* ironruby-core-bounces at rubyforge.org [mailto: >> ironruby-core-bounces at rubyforge.org] *On Behalf Of *Ivan Porto Carrero >> *Sent:* Tuesday, March 03, 2009 6:47 AM >> *To:* ironruby-core at rubyforge.org >> *Subject:* Re: [Ironruby-core] [patch] Issue in DLR.CommandLine with new >> lines >> >> >> >> http://github.com/mletterle/ironruby >> >> cd src >> >> git clone git://github.com/mletterle/ironruby.git<http://github.com/casualjim/ironruby.git> >> cd ironruby >> git checkout -b linux >> git pull origin linux >> >> ./build (you may have to chmod +x that build file first) or sh build >> >> if you put ~/bin in your PATH variable it will build, package and deploy >> an ironruby version. I''m still updating the build though at the moment. If >> you join the IRC channel you can see my check in coming through. I''ll also >> send a mail to this mailinglist when I''m done :). >> >> >> >> >> On Tue, Mar 3, 2009 at 3:34 PM, Thibaut Barr?re < >> thibaut.barrere at gmail.com> wrote: >> >> > Great i''ll add those to the mono branch :) >> >> Sorry for the obvious question: where is the mono branch ? >> >> I think I reached a point where I need to build it myself (and I want >> to stay on Mac for the moment :-). >> >> -- Thibaut >> >> _______________________________________________ >> Ironruby-core mailing list >> Ironruby-core at rubyforge.org >> http://rubyforge.org/mailman/listinfo/ironruby-core >> >> >> >> _______________________________________________ >> Ironruby-core mailing list >> Ironruby-core at rubyforge.org >> http://rubyforge.org/mailman/listinfo/ironruby-core >> >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/632ef656/attachment-0001.html>
Jb Evain
2009-Mar-03 18:34 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
Hey, On 3/3/09, Ivan Porto Carrero <ivan at flanders.co.nz> wrote:> On that page you can find most of the code fixes I made to make IR compile > on mono.Very nice, thanks! -- Jb Evain <jb at nurv.fr>
Ivan Porto Carrero
2009-Mar-03 20:19 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
Ok I just checked in the latest git push from Jim into the linux branch. I also applied your patches JB. As it turns out it was a merge conflict in Microsoft.Scripting.Build.csproj, but git found it unnecessary to mark it as a conflict and just kept the older version of the file. It looks like Runtime/LegacyScriptCode.cs (ironic as IR hasn''t even hit 1.0 yet :)) got added and 2 files in the Interpreter couldn''t be found because they didn''t exist anymore. On Tue, Mar 3, 2009 at 7:08 PM, Jb Evain <jb at nurv.fr> wrote:> Hey, > > On 3/3/09, Ivan Porto Carrero <ivan at flanders.co.nz> wrote: > > public class MyType{ > > } > > > > Compiles on MS.NET but not on Mono. > > Huh? It does compile on Mono. It must be a different issue. > > > There is an issue though around delegates but this has to do with generic > > type parameter inference again. > > Have you filed a bug or extracted a test case? > > Anyway, I''ll make sure IronRuby compiles fine with gmcs. > > -- > Jb Evain <jb at nurv.fr> > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/aee70f8b/attachment.html>
Thibaut Barrère
2009-Mar-03 20:31 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
> I have updated the instructions at > http://wiki.github.com/ironruby/ironruby#wiki_building-mono. Except for the > build step. The wiki says to use ?rake compile mono=1?. Feel free to update > the wiki if there is a better way to do the build.Ivan, Shri, thanks for the build info and updating the wiki. Building it on mono right now. cheers -- Thibaut> > > > From: ironruby-core-bounces at rubyforge.org > [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Ivan Porto Carrero > Sent: Tuesday, March 03, 2009 6:47 AM > To: ironruby-core at rubyforge.org > Subject: Re: [Ironruby-core] [patch] Issue in DLR.CommandLine with new lines > > > > http://github.com/mletterle/ironruby > > cd src > > git clone git://github.com/mletterle/ironruby.git > cd ironruby > git checkout -b linux > git pull origin linux > > ./build (you may have to chmod +x that build file first) or sh build > > if you put ~/bin in your PATH variable it will build, package and deploy an > ironruby version. I''m still updating the build though at the moment. If you > join the IRC channel you can see my check in coming through. I''ll also send > a mail to this mailinglist when I''m done :). > > > On Tue, Mar 3, 2009 at 3:34 PM, Thibaut Barr?re <thibaut.barrere at gmail.com> > wrote: > >> Great i''ll add those to the mono branch :) > > Sorry for the obvious question: where is the mono branch ? > > I think I reached a point where I need to build it myself (and I want > to stay on Mac for the moment :-). > > -- Thibaut > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core > > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core > >
Thibaut Barrère
2009-Mar-03 20:38 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
> Ok I just checked in the latest git push from Jim into the linux branch. I > also applied your patches JB. > As it turns out it was a merge conflict in Microsoft.Scripting.Build.csproj, > but git found it unnecessary to mark it as a conflict and just kept the > older version of the file. > > It looks like Runtime/LegacyScriptCode.cs (ironic as IR hasn''t even hit 1.0 > yet :)) got added and 2 files in the Interpreter couldn''t be found because > they didn''t exist anymore.Seems I have a compile issue (pulled the linux branch) - I''m using the chmod''ed +x build: Exception caught by the compiler while compiling: Block that caused the problem begin at: Runtime/LegacyScriptCode.cs(58,35): Block being compiled: [Runtime/LegacyScriptCode.cs(59,34):,Runtime/LegacyScriptCode.cs(67,13):] System.NullReferenceException: Object reference not set to an instance of an object Internal compiler error at Runtime/LegacyScriptCode.cs(58,35):: exception caught while emitting MethodBuilder [LegacyScriptCode::EnsureTarget] Do you meet this as well ? I''m using Mono 2.4. -- Thibaut> > On Tue, Mar 3, 2009 at 7:08 PM, Jb Evain <jb at nurv.fr> wrote: >> >> Hey, >> >> On 3/3/09, Ivan Porto Carrero <ivan at flanders.co.nz> wrote: >> > public class MyType{ >> > } >> > >> > Compiles on MS.NET but not on Mono. >> >> Huh? It does compile on Mono. It must be a different issue. >> >> > There is an issue though around delegates but this has to do with >> > generic >> > type parameter inference again. >> >> Have you filed a bug or extracted a test case? >> >> Anyway, I''ll make sure IronRuby compiles fine with gmcs. >> >> -- >> Jb Evain ?<jb at nurv.fr> >> _______________________________________________ >> Ironruby-core mailing list >> Ironruby-core at rubyforge.org >> http://rubyforge.org/mailman/listinfo/ironruby-core > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core > >
Ivan Porto Carrero
2009-Mar-03 20:55 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
For me it builds but I''m on mono trunk On the build server it builds as well: http://ironruby.colliertech.org/integrity/ironruby/builds/45599d7a3f2f769fc5f658ea2f8eaec1e2eb666a I can publish a packaged version automatically when I build if you want. That would typically be 1-2 days behind on Jim''s pushes. I''ll set up a git repo with mono builds and publish the url here and on the wiki On Tue, Mar 3, 2009 at 9:38 PM, Thibaut Barr?re <thibaut.barrere at gmail.com>wrote:> > Ok I just checked in the latest git push from Jim into the linux branch. > I > > also applied your patches JB. > > As it turns out it was a merge conflict in > Microsoft.Scripting.Build.csproj, > > but git found it unnecessary to mark it as a conflict and just kept the > > older version of the file. > > > > It looks like Runtime/LegacyScriptCode.cs (ironic as IR hasn''t even hit > 1.0 > > yet :)) got added and 2 files in the Interpreter couldn''t be found > because > > they didn''t exist anymore. > > Seems I have a compile issue (pulled the linux branch) - I''m using the > chmod''ed +x build: > > Exception caught by the compiler while compiling: > Block that caused the problem begin at: > Runtime/LegacyScriptCode.cs(58,35): > Block being compiled: > [Runtime/LegacyScriptCode.cs(59,34):,Runtime/LegacyScriptCode.cs(67,13):] > System.NullReferenceException: Object reference not set to an instance > of an object > Internal compiler error at Runtime/LegacyScriptCode.cs(58,35):: > exception caught while emitting MethodBuilder > [LegacyScriptCode::EnsureTarget] > > Do you meet this as well ? I''m using Mono 2.4. > > -- Thibaut > > > > > > > On Tue, Mar 3, 2009 at 7:08 PM, Jb Evain <jb at nurv.fr> wrote: > >> > >> Hey, > >> > >> On 3/3/09, Ivan Porto Carrero <ivan at flanders.co.nz> wrote: > >> > public class MyType{ > >> > } > >> > > >> > Compiles on MS.NET but not on Mono. > >> > >> Huh? It does compile on Mono. It must be a different issue. > >> > >> > There is an issue though around delegates but this has to do with > >> > generic > >> > type parameter inference again. > >> > >> Have you filed a bug or extracted a test case? > >> > >> Anyway, I''ll make sure IronRuby compiles fine with gmcs. > >> > >> -- > >> Jb Evain <jb at nurv.fr> > >> _______________________________________________ > >> Ironruby-core mailing list > >> Ironruby-core at rubyforge.org > >> http://rubyforge.org/mailman/listinfo/ironruby-core > > > > > > _______________________________________________ > > Ironruby-core mailing list > > Ironruby-core at rubyforge.org > > http://rubyforge.org/mailman/listinfo/ironruby-core > > > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/b21780e8/attachment-0001.html>
Thibaut Barrère
2009-Mar-03 21:25 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
Hi Ivan,> I can publish a packaged version automatically when I build if you want. > That would typically be 1-2 days behind on Jim''s pushes. > > I''ll set up a git repo with mono builds and publish the url here and on the > wiki >that will be useful, thanks! -- Thibaut> > > > > On Tue, Mar 3, 2009 at 9:38 PM, Thibaut Barr?re <thibaut.barrere at gmail.com > > wrote: > >> > Ok I just checked in the latest git push from Jim into the linux branch. >> I >> > also applied your patches JB. >> > As it turns out it was a merge conflict in >> Microsoft.Scripting.Build.csproj, >> > but git found it unnecessary to mark it as a conflict and just kept the >> > older version of the file. >> > >> > It looks like Runtime/LegacyScriptCode.cs (ironic as IR hasn''t even hit >> 1.0 >> > yet :)) got added and 2 files in the Interpreter couldn''t be found >> because >> > they didn''t exist anymore. >> >> Seems I have a compile issue (pulled the linux branch) - I''m using the >> chmod''ed +x build: >> >> Exception caught by the compiler while compiling: >> Block that caused the problem begin at: >> Runtime/LegacyScriptCode.cs(58,35): >> Block being compiled: >> [Runtime/LegacyScriptCode.cs(59,34):,Runtime/LegacyScriptCode.cs(67,13):] >> System.NullReferenceException: Object reference not set to an instance >> of an object >> Internal compiler error at Runtime/LegacyScriptCode.cs(58,35):: >> exception caught while emitting MethodBuilder >> [LegacyScriptCode::EnsureTarget] >> >> Do you meet this as well ? I''m using Mono 2.4. >> >> -- Thibaut >> >> >> >> > >> > On Tue, Mar 3, 2009 at 7:08 PM, Jb Evain <jb at nurv.fr> wrote: >> >> >> >> Hey, >> >> >> >> On 3/3/09, Ivan Porto Carrero <ivan at flanders.co.nz> wrote: >> >> > public class MyType{ >> >> > } >> >> > >> >> > Compiles on MS.NET but not on Mono. >> >> >> >> Huh? It does compile on Mono. It must be a different issue. >> >> >> >> > There is an issue though around delegates but this has to do with >> >> > generic >> >> > type parameter inference again. >> >> >> >> Have you filed a bug or extracted a test case? >> >> >> >> Anyway, I''ll make sure IronRuby compiles fine with gmcs. >> >> >> >> -- >> >> Jb Evain <jb at nurv.fr> >> >> _______________________________________________ >> >> Ironruby-core mailing list >> >> Ironruby-core at rubyforge.org >> >> http://rubyforge.org/mailman/listinfo/ironruby-core >> > >> > >> > _______________________________________________ >> > Ironruby-core mailing list >> > Ironruby-core at rubyforge.org >> > http://rubyforge.org/mailman/listinfo/ironruby-core >> > >> > >> _______________________________________________ >> Ironruby-core mailing list >> Ironruby-core at rubyforge.org >> http://rubyforge.org/mailman/listinfo/ironruby-core >> > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/9465db21/attachment.html>
Ivan Porto Carrero
2009-Mar-03 21:33 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
You can find the binaries @ http://github.com/casualjim/ironruby-mono-builds On Tue, Mar 3, 2009 at 10:25 PM, Thibaut Barr?re <thibaut.barrere at gmail.com>wrote:> Hi Ivan, > >> I can publish a packaged version automatically when I build if you want. >> That would typically be 1-2 days behind on Jim''s pushes. >> >> I''ll set up a git repo with mono builds and publish the url here and on >> the wiki >> > > that will be useful, thanks! > > -- Thibaut > > >> >> >> >> >> On Tue, Mar 3, 2009 at 9:38 PM, Thibaut Barr?re < >> thibaut.barrere at gmail.com> wrote: >> >>> > Ok I just checked in the latest git push from Jim into the linux >>> branch. I >>> > also applied your patches JB. >>> > As it turns out it was a merge conflict in >>> Microsoft.Scripting.Build.csproj, >>> > but git found it unnecessary to mark it as a conflict and just kept the >>> > older version of the file. >>> > >>> > It looks like Runtime/LegacyScriptCode.cs (ironic as IR hasn''t even hit >>> 1.0 >>> > yet :)) got added and 2 files in the Interpreter couldn''t be found >>> because >>> > they didn''t exist anymore. >>> >>> Seems I have a compile issue (pulled the linux branch) - I''m using the >>> chmod''ed +x build: >>> >>> Exception caught by the compiler while compiling: >>> Block that caused the problem begin at: >>> Runtime/LegacyScriptCode.cs(58,35): >>> Block being compiled: >>> [Runtime/LegacyScriptCode.cs(59,34):,Runtime/LegacyScriptCode.cs(67,13):] >>> System.NullReferenceException: Object reference not set to an instance >>> of an object >>> Internal compiler error at Runtime/LegacyScriptCode.cs(58,35):: >>> exception caught while emitting MethodBuilder >>> [LegacyScriptCode::EnsureTarget] >>> >>> Do you meet this as well ? I''m using Mono 2.4. >>> >>> -- Thibaut >>> >>> >>> >>> > >>> > On Tue, Mar 3, 2009 at 7:08 PM, Jb Evain <jb at nurv.fr> wrote: >>> >> >>> >> Hey, >>> >> >>> >> On 3/3/09, Ivan Porto Carrero <ivan at flanders.co.nz> wrote: >>> >> > public class MyType{ >>> >> > } >>> >> > >>> >> > Compiles on MS.NET but not on Mono. >>> >> >>> >> Huh? It does compile on Mono. It must be a different issue. >>> >> >>> >> > There is an issue though around delegates but this has to do with >>> >> > generic >>> >> > type parameter inference again. >>> >> >>> >> Have you filed a bug or extracted a test case? >>> >> >>> >> Anyway, I''ll make sure IronRuby compiles fine with gmcs. >>> >> >>> >> -- >>> >> Jb Evain <jb at nurv.fr> >>> >> _______________________________________________ >>> >> Ironruby-core mailing list >>> >> Ironruby-core at rubyforge.org >>> >> http://rubyforge.org/mailman/listinfo/ironruby-core >>> > >>> > >>> > _______________________________________________ >>> > Ironruby-core mailing list >>> > Ironruby-core at rubyforge.org >>> > http://rubyforge.org/mailman/listinfo/ironruby-core >>> > >>> > >>> _______________________________________________ >>> Ironruby-core mailing list >>> Ironruby-core at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/ironruby-core >>> >> >> >> _______________________________________________ >> Ironruby-core mailing list >> Ironruby-core at rubyforge.org >> http://rubyforge.org/mailman/listinfo/ironruby-core >> >> > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/b2870d80/attachment.html>
Thibaut Barrère
2009-Mar-03 21:53 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
> > You can find the binaries @ > http://github.com/casualjim/ironruby-mono-builds >Lovely - cloning it right now. thanks! -- Thibaut> > > > > On Tue, Mar 3, 2009 at 10:25 PM, Thibaut Barr?re < > thibaut.barrere at gmail.com> wrote: > >> Hi Ivan, >> >>> I can publish a packaged version automatically when I build if you want. >>> That would typically be 1-2 days behind on Jim''s pushes. >>> >>> I''ll set up a git repo with mono builds and publish the url here and on >>> the wiki >>> >> >> that will be useful, thanks! >> >> -- Thibaut >> >> >>> >>> >>> >>> >>> On Tue, Mar 3, 2009 at 9:38 PM, Thibaut Barr?re < >>> thibaut.barrere at gmail.com> wrote: >>> >>>> > Ok I just checked in the latest git push from Jim into the linux >>>> branch. I >>>> > also applied your patches JB. >>>> > As it turns out it was a merge conflict in >>>> Microsoft.Scripting.Build.csproj, >>>> > but git found it unnecessary to mark it as a conflict and just kept >>>> the >>>> > older version of the file. >>>> > >>>> > It looks like Runtime/LegacyScriptCode.cs (ironic as IR hasn''t even >>>> hit 1.0 >>>> > yet :)) got added and 2 files in the Interpreter couldn''t be found >>>> because >>>> > they didn''t exist anymore. >>>> >>>> Seems I have a compile issue (pulled the linux branch) - I''m using the >>>> chmod''ed +x build: >>>> >>>> Exception caught by the compiler while compiling: >>>> Block that caused the problem begin at: >>>> Runtime/LegacyScriptCode.cs(58,35): >>>> Block being compiled: >>>> >>>> [Runtime/LegacyScriptCode.cs(59,34):,Runtime/LegacyScriptCode.cs(67,13):] >>>> System.NullReferenceException: Object reference not set to an instance >>>> of an object >>>> Internal compiler error at Runtime/LegacyScriptCode.cs(58,35):: >>>> exception caught while emitting MethodBuilder >>>> [LegacyScriptCode::EnsureTarget] >>>> >>>> Do you meet this as well ? I''m using Mono 2.4. >>>> >>>> -- Thibaut >>>> >>>> >>>> >>>> > >>>> > On Tue, Mar 3, 2009 at 7:08 PM, Jb Evain <jb at nurv.fr> wrote: >>>> >> >>>> >> Hey, >>>> >> >>>> >> On 3/3/09, Ivan Porto Carrero <ivan at flanders.co.nz> wrote: >>>> >> > public class MyType{ >>>> >> > } >>>> >> > >>>> >> > Compiles on MS.NET but not on Mono. >>>> >> >>>> >> Huh? It does compile on Mono. It must be a different issue. >>>> >> >>>> >> > There is an issue though around delegates but this has to do with >>>> >> > generic >>>> >> > type parameter inference again. >>>> >> >>>> >> Have you filed a bug or extracted a test case? >>>> >> >>>> >> Anyway, I''ll make sure IronRuby compiles fine with gmcs. >>>> >> >>>> >> -- >>>> >> Jb Evain <jb at nurv.fr> >>>> >> _______________________________________________ >>>> >> Ironruby-core mailing list >>>> >> Ironruby-core at rubyforge.org >>>> >> http://rubyforge.org/mailman/listinfo/ironruby-core >>>> > >>>> > >>>> > _______________________________________________ >>>> > Ironruby-core mailing list >>>> > Ironruby-core at rubyforge.org >>>> > http://rubyforge.org/mailman/listinfo/ironruby-core >>>> > >>>> > >>>> _______________________________________________ >>>> Ironruby-core mailing list >>>> Ironruby-core at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/ironruby-core >>>> >>> >>> >>> _______________________________________________ >>> Ironruby-core mailing list >>> Ironruby-core at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/ironruby-core >>> >>> >> >> _______________________________________________ >> Ironruby-core mailing list >> Ironruby-core at rubyforge.org >> http://rubyforge.org/mailman/listinfo/ironruby-core >> >> > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/9c8cd8a6/attachment-0001.html>
Thibaut Barrère
2009-Mar-03 22:03 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
In case that''s useful to someone else, I had to: ln -s ~/git/ironruby-mono-builds/lib/ ~/lib ln -s ~/git/ironruby-mono-builds/bin/ ~/bin thanks again Ivan! -- Thibaut On Tue, Mar 3, 2009 at 10:53 PM, Thibaut Barr?re <thibaut.barrere at gmail.com>wrote:> You can find the binaries @ >> http://github.com/casualjim/ironruby-mono-builds >> > > Lovely - cloning it right now. > > thanks! > > -- Thibaut > > >> >> >> >> >> On Tue, Mar 3, 2009 at 10:25 PM, Thibaut Barr?re < >> thibaut.barrere at gmail.com> wrote: >> >>> Hi Ivan, >>> >>>> I can publish a packaged version automatically when I build if you want. >>>> That would typically be 1-2 days behind on Jim''s pushes. >>>> >>>> I''ll set up a git repo with mono builds and publish the url here and on >>>> the wiki >>>> >>> >>> that will be useful, thanks! >>> >>> -- Thibaut >>> >>> >>>> >>>> >>>> >>>> >>>> On Tue, Mar 3, 2009 at 9:38 PM, Thibaut Barr?re < >>>> thibaut.barrere at gmail.com> wrote: >>>> >>>>> > Ok I just checked in the latest git push from Jim into the linux >>>>> branch. I >>>>> > also applied your patches JB. >>>>> > As it turns out it was a merge conflict in >>>>> Microsoft.Scripting.Build.csproj, >>>>> > but git found it unnecessary to mark it as a conflict and just kept >>>>> the >>>>> > older version of the file. >>>>> > >>>>> > It looks like Runtime/LegacyScriptCode.cs (ironic as IR hasn''t even >>>>> hit 1.0 >>>>> > yet :)) got added and 2 files in the Interpreter couldn''t be found >>>>> because >>>>> > they didn''t exist anymore. >>>>> >>>>> Seems I have a compile issue (pulled the linux branch) - I''m using the >>>>> chmod''ed +x build: >>>>> >>>>> Exception caught by the compiler while compiling: >>>>> Block that caused the problem begin at: >>>>> Runtime/LegacyScriptCode.cs(58,35): >>>>> Block being compiled: >>>>> >>>>> [Runtime/LegacyScriptCode.cs(59,34):,Runtime/LegacyScriptCode.cs(67,13):] >>>>> System.NullReferenceException: Object reference not set to an instance >>>>> of an object >>>>> Internal compiler error at Runtime/LegacyScriptCode.cs(58,35):: >>>>> exception caught while emitting MethodBuilder >>>>> [LegacyScriptCode::EnsureTarget] >>>>> >>>>> Do you meet this as well ? I''m using Mono 2.4. >>>>> >>>>> -- Thibaut >>>>> >>>>> >>>>> >>>>> > >>>>> > On Tue, Mar 3, 2009 at 7:08 PM, Jb Evain <jb at nurv.fr> wrote: >>>>> >> >>>>> >> Hey, >>>>> >> >>>>> >> On 3/3/09, Ivan Porto Carrero <ivan at flanders.co.nz> wrote: >>>>> >> > public class MyType{ >>>>> >> > } >>>>> >> > >>>>> >> > Compiles on MS.NET but not on Mono. >>>>> >> >>>>> >> Huh? It does compile on Mono. It must be a different issue. >>>>> >> >>>>> >> > There is an issue though around delegates but this has to do with >>>>> >> > generic >>>>> >> > type parameter inference again. >>>>> >> >>>>> >> Have you filed a bug or extracted a test case? >>>>> >> >>>>> >> Anyway, I''ll make sure IronRuby compiles fine with gmcs. >>>>> >> >>>>> >> -- >>>>> >> Jb Evain <jb at nurv.fr> >>>>> >> _______________________________________________ >>>>> >> Ironruby-core mailing list >>>>> >> Ironruby-core at rubyforge.org >>>>> >> http://rubyforge.org/mailman/listinfo/ironruby-core >>>>> > >>>>> > >>>>> > _______________________________________________ >>>>> > Ironruby-core mailing list >>>>> > Ironruby-core at rubyforge.org >>>>> > http://rubyforge.org/mailman/listinfo/ironruby-core >>>>> > >>>>> > >>>>> _______________________________________________ >>>>> Ironruby-core mailing list >>>>> Ironruby-core at rubyforge.org >>>>> http://rubyforge.org/mailman/listinfo/ironruby-core >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Ironruby-core mailing list >>>> Ironruby-core at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/ironruby-core >>>> >>>> >>> >>> _______________________________________________ >>> Ironruby-core mailing list >>> Ironruby-core at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/ironruby-core >>> >>> >> >> _______________________________________________ >> Ironruby-core mailing list >> Ironruby-core at rubyforge.org >> http://rubyforge.org/mailman/listinfo/ironruby-core >> >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090303/7ede1d86/attachment.html>
Rafael Rosa
2009-Mar-03 23:09 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
Hi, It worked, after some wrestling with the paths. Thanks. Cheers, Rafael www.rafaelrosafu.com -- Posted via http://www.ruby-forum.com/.
Ivan Porto Carrero
2009-Mar-04 22:10 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
Hi Can you let me know which paths were giving you issues? Thanks On Wed, Mar 4, 2009 at 12:09 AM, Rafael Rosa <lists at ruby-forum.com> wrote:> Hi, > > It worked, after some wrestling with the paths. Thanks. > > Cheers, > Rafael > www.rafaelrosafu.com > -- > Posted via http://www.ruby-forum.com/. > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090304/38175870/attachment.html>
Rafael Rosa
2009-Mar-05 04:54 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
Hi, Nothing serious, the problem is that the "ir" script has a hardcoded path to "~/bin/ir" and already used that directory, so I had to ajust that, no big deal, but it might be nice to put a small notice on the README warning about that. Sorry for not specifing the problem before. Cheers -- Posted via http://www.ruby-forum.com/.
Jb Evain
2009-Mar-05 13:32 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
On 3/3/09, Jb Evain <jb at nurv.fr> wrote:> I spent some time investigating why on Mono ir.exe (last git revision) > doesn''t print the result of evaluations. > > The issue lies in the processing of new lines in > Microsoft.Scripting.Core.Hosting.Shell.CommandLine. > > The code is appending \n as terminating new lines, but checks for the > presence of Environment.NewLine inside the evaluated string. Obviously > it works only if Environment.NewLine is \r\n, and not \n. > > Attached is a suggested patch, addressing the issue.Microsoft folks, I know you can''t take direct patches for the DLR, but do you plan to take this bug into consideration? -- Jb Evain <jb at nurv.fr>
Curt Hagenlocher
2009-Mar-05 14:17 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
I recommend that you file this as a bug report against the DLR at http://www.codeplex.com/dlr -----Original Message----- From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Jb Evain Sent: Thursday, March 05, 2009 5:32 AM To: ironruby-core at rubyforge.org Subject: Re: [Ironruby-core] [patch] Issue in DLR.CommandLine with new lines On 3/3/09, Jb Evain <jb at nurv.fr> wrote:> I spent some time investigating why on Mono ir.exe (last git revision) > doesn''t print the result of evaluations. > > The issue lies in the processing of new lines in > Microsoft.Scripting.Core.Hosting.Shell.CommandLine. > > The code is appending \n as terminating new lines, but checks for the > presence of Environment.NewLine inside the evaluated string. Obviously > it works only if Environment.NewLine is \r\n, and not \n. > > Attached is a suggested patch, addressing the issue.Microsoft folks, I know you can''t take direct patches for the DLR, but do you plan to take this bug into consideration? -- Jb Evain <jb at nurv.fr> _______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core
Shri Borde
2009-Mar-05 17:42 UTC
[Ironruby-core] [patch] Issue in DLR.CommandLine with new lines
It sounds like an easy fix, so we will try to get it fixed in the next few days. -----Original Message----- From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Curt Hagenlocher Sent: Thursday, March 05, 2009 6:17 AM To: ironruby-core at rubyforge.org Subject: Re: [Ironruby-core] [patch] Issue in DLR.CommandLine with new lines I recommend that you file this as a bug report against the DLR at http://www.codeplex.com/dlr -----Original Message----- From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Jb Evain Sent: Thursday, March 05, 2009 5:32 AM To: ironruby-core at rubyforge.org Subject: Re: [Ironruby-core] [patch] Issue in DLR.CommandLine with new lines On 3/3/09, Jb Evain <jb at nurv.fr> wrote:> I spent some time investigating why on Mono ir.exe (last git revision) > doesn''t print the result of evaluations. > > The issue lies in the processing of new lines in > Microsoft.Scripting.Core.Hosting.Shell.CommandLine. > > The code is appending \n as terminating new lines, but checks for the > presence of Environment.NewLine inside the evaluated string. Obviously > it works only if Environment.NewLine is \r\n, and not \n. > > Attached is a suggested patch, addressing the issue.Microsoft folks, I know you can''t take direct patches for the DLR, but do you plan to take this bug into consideration? -- Jb Evain <jb at nurv.fr> _______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core _______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core