tfpt review "/shelveset:bugfixes1;REDMOND\jdeville" Comment : BinaryEncoding changes to help mono compilation, thanks to M. Letterle. Changes in FileOps to fix File.dirname (Rubyforge bugs 23669 and 22167), thanks to Ivan Porto Carrero. Tag changes for the FileOps fix. -------------- next part -------------- A non-text attachment was scrubbed... Name: bugfixes1.diff Type: application/octet-stream Size: 13101 bytes Desc: bugfixes1.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20090210/dc4d76c1/attachment.obj>
Looks good. Removing tags is good =)> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jim Deville > Sent: Tuesday, February 10, 2009 4:47 PM > To: IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: [Ironruby-core] Code Review: bugfixes1 > > tfpt review "/shelveset:bugfixes1;REDMOND\jdeville" > Comment : > BinaryEncoding changes to help mono compilation, thanks to M. > Letterle. Changes in FileOps to fix File.dirname (Rubyforge bugs 23669 > and 22167), thanks to Ivan Porto Carrero. Tag changes for the FileOps > fix. >
Reviewed by JSchementi via IRC> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jim Deville > Sent: Tuesday, February 10, 2009 4:47 PM > To: IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: [Ironruby-core] Code Review: bugfixes1 > > tfpt review "/shelveset:bugfixes1;REDMOND\jdeville" > Comment : > BinaryEncoding changes to help mono compilation, thanks to M. > Letterle. Changes in FileOps to fix File.dirname (Rubyforge bugs 23669 > and 22167), thanks to Ivan Porto Carrero. Tag changes for the FileOps > fix. >