Affects: Microsoft.Scripting.Core.dll and IronRuby tfpt review "/shelveset:Thread;REDMOND\sborde" Comment : Fixes to all the currently disabled Thread tests Thread#stop/Kernel#sleep use an Event which can be signalled from other threads, instead of using Thread.Sleep ThreadOps.CreateThread catches and ignores ThreadAbortException instead of publishing it as RubyThreadInfo.Exception Thread#main - its per ScriptRuntime, mainly because that was easier to implement, and also there is no good answer to how Thread#main should function in hosted scenarios Adds lock to RubyModule.EnsureInitialized to prevent use of uninitialized modules in multi-thread scenarios. Changes RunRSpec.cmd to match the flags used by "rake why_regression" Microsoft.Scripting.Core: Fixes ExpressionWriter to deal with GotoExpression.Value being null in VisitGoto -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081216/f101620a/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: Thread.diff Type: application/octet-stream Size: 29669 bytes Desc: Thread.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081216/f101620a/attachment-0001.obj>
Test changes look good. I''d like to see the RunRSpec.cmd use ruby to run mspec with args of ci and -t "path to ir", which is what the rakefile sets up as a command line. JD From: Shri Borde Sent: Tuesday, December 16, 2008 2:39 PM To: IronRuby External Code Reviewers; Rowan Code Reviewers; DLR Code Reviews Cc: ironruby-core at rubyforge.org Subject: Code Review: IronRuby Thread fixes Affects: Microsoft.Scripting.Core.dll and IronRuby tfpt review "/shelveset:Thread;REDMOND\sborde" Comment : Fixes to all the currently disabled Thread tests Thread#stop/Kernel#sleep use an Event which can be signalled from other threads, instead of using Thread.Sleep ThreadOps.CreateThread catches and ignores ThreadAbortException instead of publishing it as RubyThreadInfo.Exception Thread#main - its per ScriptRuntime, mainly because that was easier to implement, and also there is no good answer to how Thread#main should function in hosted scenarios Adds lock to RubyModule.EnsureInitialized to prevent use of uninitialized modules in multi-thread scenarios. Changes RunRSpec.cmd to match the flags used by "rake why_regression" Microsoft.Scripting.Core: Fixes ExpressionWriter to deal with GotoExpression.Value being null in VisitGoto -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081216/f3350ed9/attachment.html>
DLR change looks great! From: Shri Borde Sent: Tuesday, December 16, 2008 2:39 PM To: IronRuby External Code Reviewers; Rowan Code Reviewers; DLR Code Reviews Cc: ironruby-core at rubyforge.org Subject: Code Review: IronRuby Thread fixes Affects: Microsoft.Scripting.Core.dll and IronRuby tfpt review "/shelveset:Thread;REDMOND\sborde" Comment : Fixes to all the currently disabled Thread tests Thread#stop/Kernel#sleep use an Event which can be signalled from other threads, instead of using Thread.Sleep ThreadOps.CreateThread catches and ignores ThreadAbortException instead of publishing it as RubyThreadInfo.Exception Thread#main - its per ScriptRuntime, mainly because that was easier to implement, and also there is no good answer to how Thread#main should function in hosted scenarios Adds lock to RubyModule.EnsureInitialized to prevent use of uninitialized modules in multi-thread scenarios. Changes RunRSpec.cmd to match the flags used by "rake why_regression" Microsoft.Scripting.Core: Fixes ExpressionWriter to deal with GotoExpression.Value being null in VisitGoto -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081216/6563f773/attachment.html>
Ruby changes are good. From: Shri Borde Sent: Tuesday, December 16, 2008 2:39 PM To: IronRuby External Code Reviewers; Rowan Code Reviewers; DLR Code Reviews Cc: ironruby-core at rubyforge.org Subject: Code Review: IronRuby Thread fixes Affects: Microsoft.Scripting.Core.dll and IronRuby tfpt review "/shelveset:Thread;REDMOND\sborde" Comment : Fixes to all the currently disabled Thread tests Thread#stop/Kernel#sleep use an Event which can be signalled from other threads, instead of using Thread.Sleep ThreadOps.CreateThread catches and ignores ThreadAbortException instead of publishing it as RubyThreadInfo.Exception Thread#main - its per ScriptRuntime, mainly because that was easier to implement, and also there is no good answer to how Thread#main should function in hosted scenarios Adds lock to RubyModule.EnsureInitialized to prevent use of uninitialized modules in multi-thread scenarios. Changes RunRSpec.cmd to match the flags used by "rake why_regression" Microsoft.Scripting.Core: Fixes ExpressionWriter to deal with GotoExpression.Value being null in VisitGoto -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081217/e3304bb8/attachment-0001.html>