Ironruby core - Dec 2008 - Code Review: ScopesAndCrossRuntime

tfpt review "/shelveset:ScopesAndCrossRuntime;REDMOND\tomat"

  DLR, Python, JS:
  A little bit of code context cleanup and dead code removal.


  Ruby:
  -     Removes RubyScope <: CodeContext inheritance relationship.
  -     Implements isSelfContained flags for modules as it works for classes.
  -     Nests Clr module into a new IronRuby module that maps to IronRuby.Ruby
hosting class. The hierarchy is as follows:
  module IronRuby
        module Clr
                def self.profile
                end
        end
        module ParseTree
                ...
        end

  #hosting methods:
  def self.create_runtime
  def self.create_engine
  ...
  end
  -     Fixes bugs in cross-runtime object access, adds some tests. Prohibits
adding methods and mixins to a class defined in a foreign runtime.

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ScopesAndCrossRuntime.diff
Type: application/octet-stream
Size: 95241 bytes
Desc: ScopesAndCrossRuntime.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20081206/9506e5fd/attachment-0001.obj>

Mmm... I love the smell of dead CodeContext in the morning.  It smells like
victory!

Language changes look good.

-----Original Message-----
From: Tomas Matousek
Sent: Saturday, December 06, 2008 1:59 PM
To: IronRuby External Code Reviewers; DLR Code Reviews
Cc: ironruby-core at rubyforge.org
Subject: Code Review: ScopesAndCrossRuntime

  tfpt review "/shelveset:ScopesAndCrossRuntime;REDMOND\tomat"

  DLR, Python, JS:
  A little bit of code context cleanup and dead code removal.


  Ruby:
  -     Removes RubyScope <: CodeContext inheritance relationship.
  -     Implements isSelfContained flags for modules as it works for classes.
  -     Nests Clr module into a new IronRuby module that maps to IronRuby.Ruby
hosting class. The hierarchy is as follows:
  module IronRuby
        module Clr
                def self.profile
                end
        end
        module ParseTree
                ...
        end

  #hosting methods:
  def self.create_runtime
  def self.create_engine
  ...
  end
  -     Fixes bugs in cross-runtime object access, adds some tests. Prohibits
adding methods and mixins to a class defined in a foreign runtime.

Tomas

Outer ring changes look beautiful too. This sure is a victory! Thank you, Tomas!

Martin

-----Original Message-----
From: Curt Hagenlocher
Sent: Saturday, December 06, 2008 9:47 PM
To: Tomas Matousek; IronRuby External Code Reviewers; DLR Code Reviews
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: ScopesAndCrossRuntime

Mmm... I love the smell of dead CodeContext in the morning.  It smells like
victory!

Language changes look good.

-----Original Message-----
From: Tomas Matousek
Sent: Saturday, December 06, 2008 1:59 PM
To: IronRuby External Code Reviewers; DLR Code Reviews
Cc: ironruby-core at rubyforge.org
Subject: Code Review: ScopesAndCrossRuntime

  tfpt review "/shelveset:ScopesAndCrossRuntime;REDMOND\tomat"

  DLR, Python, JS:
  A little bit of code context cleanup and dead code removal.


  Ruby:
  -     Removes RubyScope <: CodeContext inheritance relationship.
  -     Implements isSelfContained flags for modules as it works for classes.
  -     Nests Clr module into a new IronRuby module that maps to IronRuby.Ruby
hosting class. The hierarchy is as follows:
  module IronRuby
        module Clr
                def self.profile
                end
        end
        module ParseTree
                ...
        end

  #hosting methods:
  def self.create_runtime
  def self.create_engine
  ...
  end
  -     Fixes bugs in cross-runtime object access, adds some tests. Prohibits
adding methods and mixins to a class defined in a foreign runtime.

Tomas