tfpt review "/shelveset:NoComplexCall;REDMOND\tomat" Outer DLR Change: Tweaks outer layer DynamicSiteHelpers to publish delegate type factory method (this class will hopefully go away as soon as LambdaExpression provides the same functionality). Ruby changes: Removes ComplexCallHelper and other useless stuff from AstFactory :) Tomas
Two misspellings should be noted -- the shelveset is actually named NoComplexCalls and RubyMethodInfo.PramsArrayDelegateType needs another "a". :) Looks good otherwise. -----Original Message----- From: Tomas Matousek Sent: Monday, November 24, 2008 6:37 PM To: IronRuby External Code Reviewers; DLR Code Reviews Cc: ironruby-core at rubyforge.org Subject: Code Review: NoComplexCall tfpt review "/shelveset:NoComplexCall;REDMOND\tomat" Outer DLR Change: Tweaks outer layer DynamicSiteHelpers to publish delegate type factory method (this class will hopefully go away as soon as LambdaExpression provides the same functionality). Ruby changes: Removes ComplexCallHelper and other useless stuff from AstFactory :) Tomas
Looks good! -----Original Message----- From: Tomas Matousek Sent: Monday, November 24, 2008 6:37 PM To: IronRuby External Code Reviewers; DLR Code Reviews Cc: ironruby-core at rubyforge.org Subject: Code Review: NoComplexCall tfpt review "/shelveset:NoComplexCall;REDMOND\tomat" Outer DLR Change: Tweaks outer layer DynamicSiteHelpers to publish delegate type factory method (this class will hopefully go away as soon as LambdaExpression provides the same functionality). Ruby changes: Removes ComplexCallHelper and other useless stuff from AstFactory :) Tomas