tfpt review "/shelveset:MiscFixesA2;REDMOND\tomat" Misc small fixes: - Throws an exception when IronRuby.Libraries.dll is not present. Currently it ends up with stack overflow because method_missing calls to_s method to format the message, which is undefined and so invokes method_missing. - Adds id to call site tracer. - Adds ''.exe'' to the list of extensions that are used in require. Tomas -------------- next part -------------- A non-text attachment was scrubbed... Name: MiscFixesA2.diff Type: application/octet-stream Size: 12130 bytes Desc: MiscFixesA2.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20081118/dd4487a4/attachment-0001.obj>
Looks good. -----Original Message----- From: Tomas Matousek Sent: Tuesday, November 18, 2008 10:38 AM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: MiscFixesA2 tfpt review "/shelveset:MiscFixesA2;REDMOND\tomat" Misc small fixes: - Throws an exception when IronRuby.Libraries.dll is not present. Currently it ends up with stack overflow because method_missing calls to_s method to format the message, which is undefined and so invokes method_missing. - Adds id to call site tracer. - Adds ''.exe'' to the list of extensions that are used in require. Tomas