Ironruby core - Nov 2008 - Code Review: rakefix1

Attached patch fixes (well, at least a bit of) Rake build. In
particular, this patch fixes get_case_sensitive_path to actually work.
Current code does p.downcase.to_s == filename, which assumes filename
is already downcased, but filename is from *.csproj and it actually is
not, so at least it should be p.downcase == filename.downcase. Current
code also does not deal with directory names differing in case.

-- 
Seo Sanghyeon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rakefix1.diff
Type: text/x-diff
Size: 2256 bytes
Desc: not available
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20081107/59cc72f5/attachment-0001.bin>

Looks good!


JD

> -----Original Message-----
> From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> bounces at rubyforge.org] On Behalf Of Seo Sanghyeon
> Sent: Thursday, November 06, 2008 11:57 PM
> To: ironruby-core at rubyforge.org
> Subject: [Ironruby-core] Code Review: rakefix1
>
> Attached patch fixes (well, at least a bit of) Rake build. In
> particular, this patch fixes get_case_sensitive_path to actually work.
> Current code does p.downcase.to_s == filename, which assumes filename
> is already downcased, but filename is from *.csproj and it actually is
> not, so at least it should be p.downcase == filename.downcase. Current
> code also does not deal with directory names differing in case.
>
> --
> Seo Sanghyeon