tfpt review "/shelveset:remove_old_spec;REDMOND\jdeville" Comment : This change removes the old specs from the test directory. It also removes the Rake tasks for those tests, and gets them out of SNAP. -------------- next part -------------- A non-text attachment was scrubbed... Name: remove_old_spec.diff Type: application/octet-stream Size: 2484 bytes Desc: remove_old_spec.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080915/252830df/attachment.obj>
Rowantest.vbproj doesn''t have any changes. Could you sort the vsmdi (using sortvsmdi.py in test\scripts)? There are too many changes otherwise. -----Original Message----- From: Jim Deville Sent: Monday, September 15, 2008 11:29 AM To: IronRuby External Code Reviewers; Srivatsn Narayanan Cc: ironruby-core at rubyforge.org Subject: Code Review: remove_old_spec tfpt review "/shelveset:remove_old_spec;REDMOND\jdeville" Comment : This change removes the old specs from the test directory. It also removes the Rake tasks for those tests, and gets them out of SNAP.
Any idea why VS decided to check that file out? I''m trying to get into the habit of running tfpt uu before shelving, but I missed it this time. I''ll run that and the sortvsmdi script and resubmit. JD> -----Original Message----- > From: Srivatsn Narayanan > Sent: Monday, September 15, 2008 11:38 AM > To: Jim Deville; IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: RE: Code Review: remove_old_spec > > Rowantest.vbproj doesn''t have any changes. Could you sort the vsmdi > (using sortvsmdi.py in test\scripts)? There are too many changes > otherwise. > > -----Original Message----- > From: Jim Deville > Sent: Monday, September 15, 2008 11:29 AM > To: IronRuby External Code Reviewers; Srivatsn Narayanan > Cc: ironruby-core at rubyforge.org > Subject: Code Review: remove_old_spec > > tfpt review "/shelveset:remove_old_spec;REDMOND\jdeville" > Comment : > This change removes the old specs from the test directory. It also > removes the Rake tasks for those tests, and gets them out of SNAP. >
Actually it should have a change - the entry for rubyspec.generictest should get deleted from the vbproj file. I don''t know why its not there - did you perhaps not save the vbproj when you closed vs? -----Original Message----- From: Jim Deville Sent: Monday, September 15, 2008 11:41 AM To: Srivatsn Narayanan; IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: RE: Code Review: remove_old_spec Any idea why VS decided to check that file out? I''m trying to get into the habit of running tfpt uu before shelving, but I missed it this time. I''ll run that and the sortvsmdi script and resubmit. JD> -----Original Message----- > From: Srivatsn Narayanan > Sent: Monday, September 15, 2008 11:38 AM > To: Jim Deville; IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: RE: Code Review: remove_old_spec > > Rowantest.vbproj doesn''t have any changes. Could you sort the vsmdi > (using sortvsmdi.py in test\scripts)? There are too many changes > otherwise. > > -----Original Message----- > From: Jim Deville > Sent: Monday, September 15, 2008 11:29 AM > To: IronRuby External Code Reviewers; Srivatsn Narayanan > Cc: ironruby-core at rubyforge.org > Subject: Code Review: remove_old_spec > > tfpt review "/shelveset:remove_old_spec;REDMOND\jdeville" > Comment : > This change removes the old specs from the test directory. It also > removes the Rake tasks for those tests, and gets them out of SNAP. >
Fixed, can you recheck for me? Same shelveset JD> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jim Deville > Sent: Monday, September 15, 2008 11:41 AM > To: Srivatsn Narayanan; IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: Re: [Ironruby-core] Code Review: remove_old_spec > > Any idea why VS decided to check that file out? > > I''m trying to get into the habit of running tfpt uu before shelving, > but I missed it this time. I''ll run that and the sortvsmdi script and > resubmit. > > > JD > > > -----Original Message----- > > From: Srivatsn Narayanan > > Sent: Monday, September 15, 2008 11:38 AM > > To: Jim Deville; IronRuby External Code Reviewers > > Cc: ironruby-core at rubyforge.org > > Subject: RE: Code Review: remove_old_spec > > > > Rowantest.vbproj doesn''t have any changes. Could you sort the vsmdi > > (using sortvsmdi.py in test\scripts)? There are too many changes > > otherwise. > > > > -----Original Message----- > > From: Jim Deville > > Sent: Monday, September 15, 2008 11:29 AM > > To: IronRuby External Code Reviewers; Srivatsn Narayanan > > Cc: ironruby-core at rubyforge.org > > Subject: Code Review: remove_old_spec > > > > tfpt review "/shelveset:remove_old_spec;REDMOND\jdeville" > > Comment : > > This change removes the old specs from the test directory. It also > > removes the Rake tasks for those tests, and gets them out of SNAP. > > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core
There is a "Tests Not in a list" testlist in the vsmdi. Its there because some hosting tests don''t belong to any testlist. I''ll talk to sesh about cleaning it up but can you remove this manually in the meanwhile (as in using notepad). This screws up SNAP otherwise. Otherwise it looks good. Go ahead with it after fixing the vsmdi. -----Original Message----- From: Jim Deville Sent: Monday, September 15, 2008 1:03 PM To: ironruby-core at rubyforge.org; Srivatsn Narayanan; IronRuby External Code Reviewers Subject: RE: Code Review: remove_old_spec Fixed, can you recheck for me? Same shelveset JD> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jim Deville > Sent: Monday, September 15, 2008 11:41 AM > To: Srivatsn Narayanan; IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: Re: [Ironruby-core] Code Review: remove_old_spec > > Any idea why VS decided to check that file out? > > I''m trying to get into the habit of running tfpt uu before shelving, > but I missed it this time. I''ll run that and the sortvsmdi script and > resubmit. > > > JD > > > -----Original Message----- > > From: Srivatsn Narayanan > > Sent: Monday, September 15, 2008 11:38 AM > > To: Jim Deville; IronRuby External Code Reviewers > > Cc: ironruby-core at rubyforge.org > > Subject: RE: Code Review: remove_old_spec > > > > Rowantest.vbproj doesn''t have any changes. Could you sort the vsmdi > > (using sortvsmdi.py in test\scripts)? There are too many changes > > otherwise. > > > > -----Original Message----- > > From: Jim Deville > > Sent: Monday, September 15, 2008 11:29 AM > > To: IronRuby External Code Reviewers; Srivatsn Narayanan > > Cc: ironruby-core at rubyforge.org > > Subject: Code Review: remove_old_spec > > > > tfpt review "/shelveset:remove_old_spec;REDMOND\jdeville" > > Comment : > > This change removes the old specs from the test directory. It also > > removes the Rake tasks for those tests, and gets them out of SNAP. > > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core