tfpt review "/shelveset:YamlRails;REDMOND\olegtk" Comment : Adds missing functionality used by Rails: - yaml_as method, which is basically a declarative alias to tag_class(). - quick_emit method, which allows to emit yaml nodes. -- Oleg -------------- next part -------------- A non-text attachment was scrubbed... Name: YamlRails.diff Type: application/octet-stream Size: 12645 bytes Desc: YamlRails.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080912/62169a73/attachment.obj>
Looks good. Did you confirm that a return from the block passed to quick_emit does not get passed back to the caller? -----Original Message----- From: Oleg Tkachenko Sent: Freitag, 12. September 2008 23:10 To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: YamlRails tfpt review "/shelveset:YamlRails;REDMOND\olegtk" Comment : Adds missing functionality used by Rails: - yaml_as method, which is basically a declarative alias to tag_class(). - quick_emit method, which allows to emit yaml nodes. -- Oleg
Yes, while this is terribly underspecified, I confirmed that quick_emit returns string YAML representation of the user-emitted YAML nodes. The major use for this is to override to_yaml method in order to provide custom YAML representation for a type. -- Oleg -----Original Message----- From: Curt Hagenlocher Sent: Monday, September 15, 2008 9:03 AM To: Oleg Tkachenko; IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: RE: Code Review: YamlRails Looks good. Did you confirm that a return from the block passed to quick_emit does not get passed back to the caller? -----Original Message----- From: Oleg Tkachenko Sent: Freitag, 12. September 2008 23:10 To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: YamlRails tfpt review "/shelveset:YamlRails;REDMOND\olegtk" Comment : Adds missing functionality used by Rails: - yaml_as method, which is basically a declarative alias to tag_class(). - quick_emit method, which allows to emit yaml nodes. -- Oleg