tfpt review "/shelveset:bugs-1;REDMOND\jflam" Comment : Fixes Rakefile to correctly generate case-sensitive filenames during compilation Fixes String#reverse and taint flow Fixes File#zero? behavior (works correctly for directory names, and handles NUL correctly) Stubs out implementation of File#symlink do throw a NotImplementedError (not sure if we can do this without P/Invoke) -------------- next part -------------- A non-text attachment was scrubbed... Name: bugs-1.diff Type: application/octet-stream Size: 18862 bytes Desc: bugs-1.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080818/87b3bad3/attachment-0001.obj>
Looks good. -----Original Message----- From: John Lam (IRONRUBY) Sent: Monday, August 18, 2008 10:55 AM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: bugs-1 tfpt review "/shelveset:bugs-1;REDMOND\jflam" Comment : Fixes Rakefile to correctly generate case-sensitive filenames during compilation Fixes String#reverse and taint flow Fixes File#zero? behavior (works correctly for directory names, and handles NUL correctly) Stubs out implementation of File#symlink do throw a NotImplementedError (not sure if we can do this without P/Invoke)