tfpt review "/shelveset:unniseo;REDMOND\jdeville" Comment : -Patch from Unni to return true for File.zero? ''nul'' and File.zero? ''NUL'' -Patch from Seo to search for both ruby and ruby.exe when searching for a ruby binary -Incorporates feedback from #ironruby IRC channel to use the first Ruby found instead of throwing an error when multiple are found -------------- next part -------------- A non-text attachment was scrubbed... Name: unniseo.diff Type: application/octet-stream Size: 5551 bytes Desc: unniseo.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080808/d01cfd34/attachment-0001.obj>
Change looks good. -----Original Message----- From: Jim Deville Sent: Friday, August 08, 2008 1:21 AM To: IronRuby External Code Reviewers; Curt Hagenlocher Cc: ironruby-core at rubyforge.org Subject: Code Review: unniseo tfpt review "/shelveset:unniseo;REDMOND\jdeville" Comment : -Patch from Unni to return true for File.zero? ''nul'' and File.zero? ''NUL'' -Patch from Seo to search for both ruby and ruby.exe when searching for a ruby binary -Incorporates feedback from #ironruby IRC channel to use the first Ruby found instead of throwing an error when multiple are found