tfpt review "/shelveset:unni1;REDMOND\jdeville" Comment : Patch from Unnikrishnan Nair to properly handle File.zero? for ''NUL'' -------------- next part -------------- A non-text attachment was scrubbed... Name: unni1.diff Type: application/octet-stream Size: 1335 bytes Desc: unni1.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080715/91cf71e9/attachment.obj>
Reviewed F2F with John JD> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jim Deville > Sent: Tuesday, July 15, 2008 1:45 PM > To: IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: [Ironruby-core] Code Review: unni1 > > tfpt review "/shelveset:unni1;REDMOND\jdeville" > Comment : > Patch from Unnikrishnan Nair to properly handle File.zero? for ''NUL'' >
While testing this manually I discovered that CRuby treats nul and NUL as zero length files, while this patch only works for NUL. Unni, can you fix that and resubmit? Thanks, JD> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jim Deville > Sent: Tuesday, July 15, 2008 2:31 PM > To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers > Subject: Re: [Ironruby-core] Code Review: unni1 > > Reviewed F2F with John > > > JD > > > -----Original Message----- > > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > > bounces at rubyforge.org] On Behalf Of Jim Deville > > Sent: Tuesday, July 15, 2008 1:45 PM > > To: IronRuby External Code Reviewers > > Cc: ironruby-core at rubyforge.org > > Subject: [Ironruby-core] Code Review: unni1 > > > > tfpt review "/shelveset:unni1;REDMOND\jdeville" > > Comment : > > Patch from Unnikrishnan Nair to properly handle File.zero? for > ''NUL'' > > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core
yes, I will do that. Thanks. Unni --- On Tue, 7/15/08, Jim Deville <jdeville at microsoft.com> wrote: From: Jim Deville <jdeville at microsoft.com> Subject: Re: [Ironruby-core] Code Review: unni1 To: "ironruby-core at rubyforge.org" <ironruby-core at rubyforge.org>, "IronRuby External Code Reviewers" <irbrev at microsoft.com> Date: Tuesday, July 15, 2008, 3:51 PM While testing this manually I discovered that CRuby treats nul and NUL as zero length files, while this patch only works for NUL. Unni, can you fix that and resubmit? Thanks, JD> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jim Deville > Sent: Tuesday, July 15, 2008 2:31 PM > To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers > Subject: Re: [Ironruby-core] Code Review: unni1 > > Reviewed F2F with John > > > JD > > > -----Original Message----- > > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > > bounces at rubyforge.org] On Behalf Of Jim Deville > > Sent: Tuesday, July 15, 2008 1:45 PM > > To: IronRuby External Code Reviewers > > Cc: ironruby-core at rubyforge.org > > Subject: [Ironruby-core] Code Review: unni1 > > > > tfpt review "/shelveset:unni1;REDMOND\jdeville" > > Comment : > > Patch from Unnikrishnan Nair to properly handle File.zero? for > ''NUL'' > > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core_______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080716/f1c6fac4/attachment.html>
Jim, ? As per your comments, I have modified the code and ran against Matz Ruby and verified the results. Yes you are correct ''nul'' is same as ''NUL'' as well. I have updated the patch as well. ? Just curious, how come there is no representation of IronRuby in Lonestar Ruby conference? ? Thanks. Unni --- On Wed, 7/16/08, Unnikrishnan Nair <ksunair at yahoo.com> wrote: From: Unnikrishnan Nair <ksunair at yahoo.com> Subject: Re: [Ironruby-core] Code Review: unni1 To: ironruby-core at rubyforge.org Date: Wednesday, July 16, 2008, 10:34 AM yes, I will do that. Thanks. Unni --- On Tue, 7/15/08, Jim Deville <jdeville at microsoft.com> wrote: From: Jim Deville <jdeville at microsoft.com> Subject: Re: [Ironruby-core] Code Review: unni1 To: "ironruby-core at rubyforge.org" <ironruby-core at rubyforge.org>, "IronRuby External Code Reviewers" <irbrev at microsoft.com> Date: Tuesday, July 15, 2008, 3:51 PM While testing this manually I discovered that CRuby treats nul and NUL as zero length files, while this patch only works for NUL. Unni, can you fix that and resubmit? Thanks, JD> -----Original Message----- > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > bounces at rubyforge.org] On Behalf Of Jim Deville > Sent: Tuesday, July 15, 2008 2:31 PM > To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers > Subject: Re: [Ironruby-core] Code Review: unni1 > > Reviewed F2F with John > > > JD > > > -----Original Message----- > > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core- > > bounces at rubyforge.org] On Behalf Of Jim Deville > > Sent: Tuesday, July 15, 2008 1:45 PM > > To: IronRuby External Code Reviewers > > Cc: ironruby-core at rubyforge.org > > Subject: [Ironruby-core] Code Review: unni1 > > > > tfpt review "/shelveset:unni1;REDMOND\jdeville" > > Comment : > > Patch from Unnikrishnan Nair to properly handle File.zero? for > ''NUL'' > > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core_______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core_______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080716/b7d5b728/attachment.html>
Cool, I''ll get that integrated into the repo. I don''t know why we didn''t send someone to Lonestar. Probably just a case of limited resources. JD From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Unnikrishnan Nair Sent: Wednesday, July 16, 2008 7:52 PM To: ironruby-core at rubyforge.org Subject: Re: [Ironruby-core] Code Review: unni1 Jim, As per your comments, I have modified the code and ran against Matz Ruby and verified the results. Yes you are correct ''nul'' is same as ''NUL'' as well. I have updated the patch as well. Just curious, how come there is no representation of IronRuby in Lonestar Ruby conference? Thanks. Unni --- On Wed, 7/16/08, Unnikrishnan Nair <ksunair at yahoo.com> wrote: From: Unnikrishnan Nair <ksunair at yahoo.com> Subject: Re: [Ironruby-core] Code Review: unni1 To: ironruby-core at rubyforge.org Date: Wednesday, July 16, 2008, 10:34 AM yes, I will do that. Thanks. Unni --- On Tue, 7/15/08, Jim Deville <jdeville at microsoft.com> wrote: From: Jim Deville <jdeville at microsoft.com> Subject: Re: [Ironruby-core] Code Review: unni1 To: "ironruby-core at rubyforge.org" <ironruby-core at rubyforge.org>, "IronRuby External Code Reviewers" <irbrev at microsoft.com> Date: Tuesday, July 15, 2008, 3:51 PM While testing this manually I discovered that CRuby treats nul and NUL as zero length files, while this patch only works for NUL. Unni, can you fix that and resubmit? Thanks, JD> -----Original Message-----> From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-> bounces at rubyforge.org] On Behalf Of Jim Deville> Sent: Tuesday, July 15, 2008 2:31 PM> To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers> Subject: Re: [Ironruby-core] Code Review: unni1>> Reviewed F2F with John>>> JD>> > -----Original Message-----> > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-> > bounces at rubyforge.org] On Behalf Of Jim Deville> > Sent: Tuesday, July 15, 2008 1:45 PM> > To: IronRuby External Code Reviewers> > Cc: ironruby-core at rubyforge.org> > Subject: [Ironruby-core] Code Review: unni1> >> > tfpt review "/shelveset:unni1;REDMOND\jdeville"> > Comment :> > Patch from Unnikrishnan Nair to properly handle File.zero? for> ''NUL''> >>> _______________________________________________> Ironruby-core mailing list> Ironruby-core at rubyforge.org> http://rubyforge.org/mailman/listinfo/ironruby-core_______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core _______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080716/d0656800/attachment.html>
As much as we would love to attend more Ruby conferences (and there are a LOT of Ruby conferences!), we really don''t have the bandwidth. So we''re being very careful about where we go. We''ll be at RubyConf this year. Thanks, -John From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Unnikrishnan Nair Sent: Wednesday, July 16, 2008 10:52 PM To: ironruby-core at rubyforge.org Subject: Re: [Ironruby-core] Code Review: unni1 Jim, As per your comments, I have modified the code and ran against Matz Ruby and verified the results. Yes you are correct ''nul'' is same as ''NUL'' as well. I have updated the patch as well. Just curious, how come there is no representation of IronRuby in Lonestar Ruby conference? Thanks. Unni --- On Wed, 7/16/08, Unnikrishnan Nair <ksunair at yahoo.com> wrote: From: Unnikrishnan Nair <ksunair at yahoo.com> Subject: Re: [Ironruby-core] Code Review: unni1 To: ironruby-core at rubyforge.org Date: Wednesday, July 16, 2008, 10:34 AM yes, I will do that. Thanks. Unni --- On Tue, 7/15/08, Jim Deville <jdeville at microsoft.com> wrote: From: Jim Deville <jdeville at microsoft.com> Subject: Re: [Ironruby-core] Code Review: unni1 To: "ironruby-core at rubyforge.org" <ironruby-core at rubyforge.org>, "IronRuby External Code Reviewers" <irbrev at microsoft.com> Date: Tuesday, July 15, 2008, 3:51 PM While testing this manually I discovered that CRuby treats nul and NUL as zero length files, while this patch only works for NUL. Unni, can you fix that and resubmit? Thanks, JD> -----Original Message-----> From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-> bounces at rubyforge.org] On Behalf Of Jim Deville> Sent: Tuesday, July 15, 2008 2:31 PM> To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers> Subject: Re: [Ironruby-core] Code Review: unni1>> Reviewed F2F with John>>> JD>> > -----Original Message-----> > From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-> > bounces at rubyforge.org] On Behalf Of Jim Deville> > Sent: Tuesday, July 15, 2008 1:45 PM> > To: IronRuby External Code Reviewers> > Cc: ironruby-core at rubyforge.org> > Subject: [Ironruby-core] Code Review: unni1> >> > tfpt review "/shelveset:unni1;REDMOND\jdeville"> > Comment :> > Patch from Unnikrishnan Nair to properly handle File.zero? for> ''NUL''> >>> _______________________________________________> Ironruby-core mailing list> Ironruby-core at rubyforge.org> http://rubyforge.org/mailman/listinfo/ironruby-core_______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core _______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080717/857671e4/attachment-0001.html>
I was really looking forward to meet you guys here at Texas, well next time. Matz is giving the key note. Thanks. Unni --- On Thu, 7/17/08, John Lam (IRONRUBY) <jflam at microsoft.com> wrote:> From: John Lam (IRONRUBY) <jflam at microsoft.com> > Subject: RE: [Ironruby-core] Code Review: unni1 > To: "ksunair at yahoo.com" <ksunair at yahoo.com>, "ironruby-core at rubyforge.org" <ironruby-core at rubyforge.org> > Date: Thursday, July 17, 2008, 9:05 AM > As much as we would love to attend more Ruby conferences > (and there are a LOT of Ruby conferences!), we really > don''t have the bandwidth. So we''re being very > careful about where we go. > > We''ll be at RubyConf this year. > > Thanks, > -John > > > From: ironruby-core-bounces at rubyforge.org > [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of > Unnikrishnan Nair > Sent: Wednesday, July 16, 2008 10:52 PM > To: ironruby-core at rubyforge.org > Subject: Re: [Ironruby-core] Code Review: unni1 > > > Jim, > > > > As per your comments, I have modified the code and ran > against Matz Ruby and verified the results. Yes you are > correct ''nul'' is same as ''NUL'' as well. I > have updated the patch as well. > > > > Just curious, how come there is no representation of > IronRuby in Lonestar Ruby conference? > > > > Thanks. > > Unni > > --- On Wed, 7/16/08, Unnikrishnan Nair > <ksunair at yahoo.com> wrote: > From: Unnikrishnan Nair <ksunair at yahoo.com> > Subject: Re: [Ironruby-core] Code Review: unni1 > To: ironruby-core at rubyforge.org > Date: Wednesday, July 16, 2008, 10:34 AM > > yes, I will do that. > > Thanks. > > Unni > > --- On Tue, 7/15/08, Jim Deville > <jdeville at microsoft.com> wrote: > From: Jim Deville <jdeville at microsoft.com> > Subject: Re: [Ironruby-core] Code Review: unni1 > To: "ironruby-core at rubyforge.org" > <ironruby-core at rubyforge.org>, "IronRuby > External Code Reviewers" <irbrev at microsoft.com> > Date: Tuesday, July 15, 2008, 3:51 PM > > While testing this manually I discovered that CRuby treats > nul and NUL as zero > > length files, while this patch only works for NUL. Unni, > can you fix that and > > resubmit? > > > > Thanks, > > > > > > JD > > > > > > > -----Original Message----- > > > From: ironruby-core-bounces at rubyforge.org > [mailto:ironruby-core- > > > bounces at rubyforge.org] On Behalf Of Jim Deville > > > Sent: Tuesday, July 15, 2008 2:31 PM > > > To: ironruby-core at rubyforge.org; IronRuby External > Code Reviewers > > > Subject: Re: [Ironruby-core] Code Review: unni1 > > > > > > Reviewed F2F with John > > > > > > > > > JD > > > > > > > -----Original Message----- > > > > From: ironruby-core-bounces at rubyforge.org > [mailto:ironruby-core- > > > > bounces at rubyforge.org] On Behalf Of Jim Deville > > > > Sent: Tuesday, July 15, 2008 1:45 PM > > > > To: IronRuby External Code Reviewers > > > > Cc: ironruby-core at rubyforge.org > > > > Subject: [Ironruby-core] Code Review: unni1 > > > > > > > > tfpt review > "/shelveset:unni1;REDMOND\jdeville" > > > > Comment : > > > > Patch from Unnikrishnan Nair to properly handle > File.zero? for > > > ''NUL'' > > > > > > > > > > _______________________________________________ > > > Ironruby-core mailing list > > > Ironruby-core at rubyforge.org > > > http://rubyforge.org/mailman/listinfo/ironruby-core > > > > _______________________________________________ > > Ironruby-core mailing list > > Ironruby-core at rubyforge.org > > http://rubyforge.org/mailman/listinfo/ironruby-core > > > _______________________________________________ > > Ironruby-core mailing list > > Ironruby-core at rubyforge.org > > http://rubyforge.org/mailman/listinfo/ironruby-core