I''m syncing up the copy of Rubyspec in TFS/SVN with the copy in Git. I''d like to get a code review of the changes. Eventually this will be automated, but for now, I''m attaching them directly. Question: Does the attached format work? It''s the format output by git when you run git format-patch. It''s basically a diff, but it''s different enough that I want to know. I can change to diff''s if needed. ~~~~ JD http://blog.jredville.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080709/1cf8de6b/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-adding-bignum-spec-for-bignum-divide-by-float-0.0.patch Type: application/octet-stream Size: 1080 bytes Desc: 0001-adding-bignum-spec-for-bignum-divide-by-float-0.0.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080709/1cf8de6b/attachment-0005.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-added-guards-for-ironruby-to-bignum-specs-converted.patch Type: application/octet-stream Size: 3772 bytes Desc: 0002-added-guards-for-ironruby-to-bignum-specs-converted.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080709/1cf8de6b/attachment-0006.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0003-added-guards-for-continuation.patch Type: application/octet-stream Size: 1132 bytes Desc: 0003-added-guards-for-continuation.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080709/1cf8de6b/attachment-0007.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0004-modifications-to-dir-specs-to-work-on-windows.patch Type: application/octet-stream Size: 12699 bytes Desc: 0004-modifications-to-dir-specs-to-work-on-windows.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080709/1cf8de6b/attachment-0008.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0005-changed-wording-for-some-enumerable-each-specs.patch Type: application/octet-stream Size: 1015 bytes Desc: 0005-changed-wording-for-some-enumerable-each-specs.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080709/1cf8de6b/attachment-0009.obj>
Why not fork the RubySpec project on GitHub, apply your patches and point us at your forked GIT repository? That way we can easily see the changes using the tools on GitHub. Pete From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Jim Deville Sent: Wednesday,09 July 09, 2008 21:21 To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers; Srivatsn Narayanan Subject: [Ironruby-core] RubySpec changes I''m syncing up the copy of Rubyspec in TFS/SVN with the copy in Git. I''d like to get a code review of the changes. Eventually this will be automated, but for now, I''m attaching them directly. Question: Does the attached format work? It''s the format output by git when you run git format-patch. It''s basically a diff, but it''s different enough that I want to know. I can change to diff''s if needed. ~~~~ JD http://blog.jredville.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080709/8079be2c/attachment.html>
Good idea. I''m going to start doing that, but here''s an update on what I''ve done while I move my get repo''s origin. I''ve already sent some of the out, but I resent all just to be safe. JD From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Peter Bacon Darwin Sent: Wednesday, July 09, 2008 1:36 PM To: ironruby-core at rubyforge.org Subject: Re: [Ironruby-core] RubySpec changes Why not fork the RubySpec project on GitHub, apply your patches and point us at your forked GIT repository? That way we can easily see the changes using the tools on GitHub. Pete From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Jim Deville Sent: Wednesday,09 July 09, 2008 21:21 To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers; Srivatsn Narayanan Subject: [Ironruby-core] RubySpec changes I''m syncing up the copy of Rubyspec in TFS/SVN with the copy in Git. I''d like to get a code review of the changes. Eventually this will be automated, but for now, I''m attaching them directly. Question: Does the attached format work? It''s the format output by git when you run git format-patch. It''s basically a diff, but it''s different enough that I want to know. I can change to diff''s if needed. ~~~~ JD http://blog.jredville.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080710/f946fdd5/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-adding-bignum-spec-for-bignum-divide-by-float-0.0.patch Type: application/octet-stream Size: 1080 bytes Desc: 0001-adding-bignum-spec-for-bignum-divide-by-float-0.0.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080710/f946fdd5/attachment-0009.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-added-guards-for-ironruby-to-bignum-specs-converted.patch Type: application/octet-stream Size: 3772 bytes Desc: 0002-added-guards-for-ironruby-to-bignum-specs-converted.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080710/f946fdd5/attachment-0010.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0003-added-guards-for-continuation.patch Type: application/octet-stream Size: 1132 bytes Desc: 0003-added-guards-for-continuation.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080710/f946fdd5/attachment-0011.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0004-modifications-to-dir-specs-to-work-on-windows.patch Type: application/octet-stream Size: 12699 bytes Desc: 0004-modifications-to-dir-specs-to-work-on-windows.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080710/f946fdd5/attachment-0012.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0005-changed-wording-for-some-enumerable-each-specs.patch Type: application/octet-stream Size: 1015 bytes Desc: 0005-changed-wording-for-some-enumerable-each-specs.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080710/f946fdd5/attachment-0013.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0006-modified-env-specs-for-windows.patch Type: application/octet-stream Size: 1265 bytes Desc: 0006-modified-env-specs-for-windows.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080710/f946fdd5/attachment-0014.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0007-uncommented-script_error_spec-added-case-insensitiv.patch Type: application/octet-stream Size: 2020 bytes Desc: 0007-uncommented-script_error_spec-added-case-insensitiv.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080710/f946fdd5/attachment-0015.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0008-removed-extra-puts-in-file-open_spec.rb.patch Type: application/octet-stream Size: 763 bytes Desc: 0008-removed-extra-puts-in-file-open_spec.rb.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080710/f946fdd5/attachment-0016.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0009-modified-hash-spec-guards-to-include-IronRuby.patch Type: application/octet-stream Size: 2638 bytes Desc: 0009-modified-hash-spec-guards-to-include-IronRuby.patch URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080710/f946fdd5/attachment-0017.obj>
I went over these face to face with John, but for those who want, I''ve also now pushed ( and will in the future) these to my github fork: http://github.com/jredville/rubyspec. You can check them out there. JD From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Jim Deville Sent: Thursday, July 10, 2008 12:45 PM To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers; Srivatsn Narayanan Subject: Re: [Ironruby-core] RubySpec changes Good idea. I''m going to start doing that, but here''s an update on what I''ve done while I move my get repo''s origin. I''ve already sent some of the out, but I resent all just to be safe. JD From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Peter Bacon Darwin Sent: Wednesday, July 09, 2008 1:36 PM To: ironruby-core at rubyforge.org Subject: Re: [Ironruby-core] RubySpec changes Why not fork the RubySpec project on GitHub, apply your patches and point us at your forked GIT repository? That way we can easily see the changes using the tools on GitHub. Pete From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Jim Deville Sent: Wednesday,09 July 09, 2008 21:21 To: ironruby-core at rubyforge.org; IronRuby External Code Reviewers; Srivatsn Narayanan Subject: [Ironruby-core] RubySpec changes I''m syncing up the copy of Rubyspec in TFS/SVN with the copy in Git. I''d like to get a code review of the changes. Eventually this will be automated, but for now, I''m attaching them directly. Question: Does the attached format work? It''s the format output by git when you run git format-patch. It''s basically a diff, but it''s different enough that I want to know. I can change to diff''s if needed. ~~~~ JD http://blog.jredville.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080710/4ef39011/attachment.html>