tfpt review "/shelveset:MutableStringSqueeze;REDMOND\dremy" Comment : Implement String.squeeze and String.squeeze! Passes RubySpec tests. Passes Unit tests. -------------- next part -------------- A non-text attachment was scrubbed... Name: MutableStringSqueeze.diff Type: application/octet-stream Size: 5458 bytes Desc: MutableStringSqueeze.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080625/ebaaae99/attachment.obj>
Looks good. Tomas -----Original Message----- From: Dave Remy Sent: Wednesday, June 25, 2008 3:56 PM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: MutableStringSqueeze tfpt review "/shelveset:MutableStringSqueeze;REDMOND\dremy" Comment : Implement String.squeeze and String.squeeze! Passes RubySpec tests. Passes Unit tests.
Should the comment:
"putters putt balls".squeeze("mz") => "puters put
balls"
be
"putters putt balls".squeeze("m-z") => "puters put
balls"
Robert.
On Wed, Jun 25, 2008 at 6:55 PM, Dave Remy <dremy at microsoft.com> wrote:
> tfpt review "/shelveset:MutableStringSqueeze;REDMOND\dremy"
> Comment :
> Implement String.squeeze and String.squeeze!
> Passes RubySpec tests. Passes Unit tests.
>
>
>
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20080626/9f5aa9e8/attachment.html>
Yes! Thanks!
From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at
rubyforge.org] On Behalf Of Robert Horvick
Sent: Thursday, June 26, 2008 11:15 AM
To: ironruby-core at rubyforge.org
Subject: Re: [Ironruby-core] Code Review: MutableStringSqueeze
Should the comment:
"putters putt balls".squeeze("mz") => "puters put
balls"
be
"putters putt balls".squeeze("m-z") => "puters put
balls"
Robert.
On Wed, Jun 25, 2008 at 6:55 PM, Dave Remy <dremy at
microsoft.com<mailto:dremy at microsoft.com>> wrote:
tfpt review "/shelveset:MutableStringSqueeze;REDMOND\dremy"
Comment :
Implement String.squeeze and String.squeeze!
Passes RubySpec tests. Passes Unit tests.
_______________________________________________
Ironruby-core mailing list
Ironruby-core at rubyforge.org<mailto:Ironruby-core at rubyforge.org>
http://rubyforge.org/mailman/listinfo/ironruby-core
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20080626/ad31e7b5/attachment.html>