tfpt review "/shelveset:Partial1;REDMOND\tomat" Adds /partial mode to IronRuby unit tests. If specified, the harness will run tests in an app-domain that has restricted permissions. Simple DLR changes: Snippet assembly needs to be marked by SecurityTransparent attribute in order to work in partial trust. Fixed TestAst - a handful of types were declared private yet referenced from generated code. Ruby changes: IronRuby assemblies were missing SecurityTransparent and AllowPartiallyTrustedCallers attributes. Few tests access files, so they need to be excluded in partial trust. Methods invoked via reflection need to be public. Tomas -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080611/5bf3729e/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: Partial1.diff Type: application/octet-stream Size: 26705 bytes Desc: Partial1.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080611/5bf3729e/attachment-0001.obj>
tfpt review "/shelveset:partial1;REDMOND\jdeville" Comment : Run IronRuby.test.exe under regular and partial trust in snap.
Did you forget to include irtest.bat? I don''t see it already checked in. Also RowanTest.* files don''t have any changes. You can undo them. -----Original Message----- From: Jim Deville Sent: Thursday, June 26, 2008 9:10 AM To: IronRuby External Code Reviewers; Srivatsn Narayanan Cc: ironruby-core at rubyforge.org Subject: Code Review: partial1 tfpt review "/shelveset:partial1;REDMOND\jdeville" Comment : Run IronRuby.test.exe under regular and partial trust in snap.
Fixed. Try again. JD> -----Original Message----- > From: Srivatsn Narayanan > Sent: Thursday, June 26, 2008 10:41 AM > To: Jim Deville; IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: RE: Code Review: partial1 > > Did you forget to include irtest.bat? I don''t see it already checked > in. Also RowanTest.* files don''t have any changes. You can undo them. > > -----Original Message----- > From: Jim Deville > Sent: Thursday, June 26, 2008 9:10 AM > To: IronRuby External Code Reviewers; Srivatsn Narayanan > Cc: ironruby-core at rubyforge.org > Subject: Code Review: partial1 > > tfpt review "/shelveset:partial1;REDMOND\jdeville" > Comment : > Run IronRuby.test.exe under regular and partial trust in snap. >-------------- next part -------------- A non-text attachment was scrubbed... Name: partial1.diff Type: application/octet-stream Size: 953 bytes Desc: partial1.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20080626/64b3e86b/attachment-0001.obj>
Looks good. Make sure that the generic test won''t timeout since the running time has effectively doubled. Also, in the batch file, you could use pushd %ROWAN_BIN% and then popd instead of storing CURRENT. -----Original Message----- From: Jim Deville Sent: Thursday, June 26, 2008 10:57 AM To: Srivatsn Narayanan; IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: RE: Code Review: partial1 Fixed. Try again. JD> -----Original Message----- > From: Srivatsn Narayanan > Sent: Thursday, June 26, 2008 10:41 AM > To: Jim Deville; IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: RE: Code Review: partial1 > > Did you forget to include irtest.bat? I don''t see it already checked > in. Also RowanTest.* files don''t have any changes. You can undo them. > > -----Original Message----- > From: Jim Deville > Sent: Thursday, June 26, 2008 9:10 AM > To: IronRuby External Code Reviewers; Srivatsn Narayanan > Cc: ironruby-core at rubyforge.org > Subject: Code Review: partial1 > > tfpt review "/shelveset:partial1;REDMOND\jdeville" > Comment : > Run IronRuby.test.exe under regular and partial trust in snap. >
What''s the timeout for generic tests? Is it the one in the test? Or does Snap have a limit? JD> -----Original Message----- > From: Srivatsn Narayanan > Sent: Thursday, June 26, 2008 11:11 AM > To: Jim Deville; IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: RE: RE: Code Review: partial1 > > Looks good. Make sure that the generic test won''t timeout since the > running time has effectively doubled. Also, in the batch file, you > could use pushd %ROWAN_BIN% and then popd instead of storing CURRENT. > > -----Original Message----- > From: Jim Deville > Sent: Thursday, June 26, 2008 10:57 AM > To: Srivatsn Narayanan; IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: RE: Code Review: partial1 > > Fixed. Try again. > > > JD > > > > -----Original Message----- > > From: Srivatsn Narayanan > > Sent: Thursday, June 26, 2008 10:41 AM > > To: Jim Deville; IronRuby External Code Reviewers > > Cc: ironruby-core at rubyforge.org > > Subject: RE: Code Review: partial1 > > > > Did you forget to include irtest.bat? I don''t see it already checked > > in. Also RowanTest.* files don''t have any changes. You can undo them. > > > > -----Original Message----- > > From: Jim Deville > > Sent: Thursday, June 26, 2008 9:10 AM > > To: IronRuby External Code Reviewers; Srivatsn Narayanan > > Cc: ironruby-core at rubyforge.org > > Subject: Code Review: partial1 > > > > tfpt review "/shelveset:partial1;REDMOND\jdeville" > > Comment : > > Run IronRuby.test.exe under regular and partial trust in snap. > >
It''s the one in the test. There is a snap timeout as well but that is the for the entire task. That shouldn''t have to change. -----Original Message----- From: Jim Deville Sent: Thursday, June 26, 2008 1:23 PM To: Srivatsn Narayanan; IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: RE: RE: Code Review: partial1 What''s the timeout for generic tests? Is it the one in the test? Or does Snap have a limit? JD> -----Original Message----- > From: Srivatsn Narayanan > Sent: Thursday, June 26, 2008 11:11 AM > To: Jim Deville; IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: RE: RE: Code Review: partial1 > > Looks good. Make sure that the generic test won''t timeout since the > running time has effectively doubled. Also, in the batch file, you > could use pushd %ROWAN_BIN% and then popd instead of storing CURRENT. > > -----Original Message----- > From: Jim Deville > Sent: Thursday, June 26, 2008 10:57 AM > To: Srivatsn Narayanan; IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: RE: Code Review: partial1 > > Fixed. Try again. > > > JD > > > > -----Original Message----- > > From: Srivatsn Narayanan > > Sent: Thursday, June 26, 2008 10:41 AM > > To: Jim Deville; IronRuby External Code Reviewers > > Cc: ironruby-core at rubyforge.org > > Subject: RE: Code Review: partial1 > > > > Did you forget to include irtest.bat? I don''t see it already checked > > in. Also RowanTest.* files don''t have any changes. You can undo them. > > > > -----Original Message----- > > From: Jim Deville > > Sent: Thursday, June 26, 2008 9:10 AM > > To: IronRuby External Code Reviewers; Srivatsn Narayanan > > Cc: ironruby-core at rubyforge.org > > Subject: Code Review: partial1 > > > > tfpt review "/shelveset:partial1;REDMOND\jdeville" > > Comment : > > Run IronRuby.test.exe under regular and partial trust in snap. > >