Ironruby core - May 2008 - Code Review: rails-12

tfpt review "/shelveset:rails-12;REDMOND\jflam"

- Adds an implementation of Kernel#rand. Passes all specs
- Fixes bug where you are matching a regex against a nil (both #match and #=~)
- Fixes glob for matching directory names (paths that end with / are assumed to
refer to dirs and not files)
- Fixes bug in constructing Digest objects in OpenSSL

Thanks,
-John




-------------- next part --------------
A non-text attachment was scrubbed...
Name: rails-12.diff
Type: application/octet-stream
Size: 15938 bytes
Desc: rails-12.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20080526/df4c27f3/attachment-0001.obj>

Looks good. The final "rand" implementation would need to use a
"srand"-seeded generator associated with RubyExecutionContext though.

Tomas

-----Original Message-----
From: John Lam (IRONRUBY)
Sent: Monday, May 26, 2008 5:09 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: rails-12

tfpt review "/shelveset:rails-12;REDMOND\jflam"

- Adds an implementation of Kernel#rand. Passes all specs
- Fixes bug where you are matching a regex against a nil (both #match and #=~)
- Fixes glob for matching directory names (paths that end with / are assumed to
refer to dirs and not files)
- Fixes bug in constructing Digest objects in OpenSSL

Thanks,
-John