John Lam (IRONRUBY)
2008-Apr-24 19:45 UTC
[Ironruby-core] Seo''s patch for building on mono
FYI I''m accepting part of the patch only. This won''t be
accepted - if folks want this to compile under Mono, please submit a patch that
fixes this correctly (new defines etc).
Index: src/microsoft.scripting.core/shell/BasicConsole.cs
protected void WriteColor(TextWriter output, string str, ConsoleColor c) {
-#if !SILVERLIGHT // Console.ForegroundColor
- ConsoleColor origColor = Console.ForegroundColor;
- Console.ForegroundColor = c;
-#endif
output.Write(str);
output.Flush();
-
-#if !SILVERLIGHT // Console.ForegroundColor
- Console.ForegroundColor = origColor;
-#endif
}
Regarding the Mono compiler bug: will the latest mono c# compiler compile these?
I''m reluctant to change our sources
Index: src/ironruby/Builtins/RubyModule.cs
==================================================================
- _mixins = ArrayUtils.InsertAt(_mixins, 0, allModules.ToArray());
+ _mixins = ArrayUtils.InsertAt<RubyModule>(_mixins, 0,
allModules.ToArray());
Index: src/microsoft.scripting.core/utils/ArrayUtils.cs
==================================================================
- return InsertAt(MakeArray(list), index, items);
+ return InsertAt<T>(MakeArray(list), index, items);
Thanks,
-John
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://rubyforge.org/pipermail/ironruby-core/attachments/20080424/7d96a2d0/attachment.html
2008/4/25, John Lam (IRONRUBY) <jflam at microsoft.com>:> FYI I''m accepting part of the patch only. This won''t be accepted ? if folks > want this to compile under Mono, please submit a patch that fixes this > correctly (new defines etc). > > (Regarding Mono console workaround and Mono compiler workaround)I never expected otherwise. :-) Those workarounds are there for people who want to try IronRuby on Mono right now. I never intended them to be merged. -- Seo Sanghyeon