Ironruby core - Apr 2008 - Patch submitted - [#19230] Time implementation

Hey Guys,

Josh Charles put a bug in my ear (thanks Josh!), so I got off my duff and
submitted a patch for the Time class that''s been sitting on my laptop
for
months.  It should have implementations for most of the basic Time
functionality save for the strftime method.  It''ll pass 22 of the 55
time
specs.  It would pass almost all of them, but the specs depend on
ENV["TZ"]
to set the system time zone, which I''m not sure is really possible on
Windows, and seems a little sketchy anyway (who wants specs monkeying with
their system time?).  I had more luck with the JRuby tests when I ran them.

I hope it''s useful for somebody... Cheers!
Eric Nicholson
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://rubyforge.org/pipermail/ironruby-core/attachments/20080331/ff5732fb/attachment-0001.html

Thanks for submitting this, Eric!

This reminds me that I need to add a simple implementation for ENV as well ...

Thanks,
-John

> -----Original Message-----
> From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-
> bounces at rubyforge.org] On Behalf Of Eric Nicholson
> Sent: Monday, March 31, 2008 8:07 PM
> To: ironruby-core at rubyforge.org
> Subject: [Ironruby-core] Patch submitted - [#19230] Time
> implementation
>
> Hey Guys,
>
> Josh Charles put a bug in my ear (thanks Josh!), so I got off my duff
> and submitted a patch for the Time class that''s been sitting on my
> laptop for months.  It should have implementations for most of the
> basic Time functionality save for the strftime method.  It''ll pass
22
> of the
> 55 time specs.  It would pass almost all of them, but the specs depend
> on ENV["TZ"] to set the system time zone, which I''m not
sure is really
> possible on Windows, and seems a little sketchy anyway (who wants
> specs monkeying with their system time?).  I had more luck with the
> JRuby tests when I ran them.
>
> I hope it''s useful for somebody... Cheers!
> Eric Nicholson
>