Hi, I'm trying to adapt darkice to the current state of icecast2. As I see, there is a possibility to stream in various formats, by specifying a Content-type field on the source header. When I try to log in with an mp3 source, I get a seg fault from icecast2. The connection looks something like: SOURCE /mountpoint ICE/1.0 Content-type: audio/mpeg ice-password: password ice-bitrate: 96 ice-public: 0 ice-name: name ice-description: description ice-url: http://url.org ice-genre: genre <here comes the raw mp3 data> <p>the seg fault occurs in icecast2 at line 150 of source.c: <p> refbuf = source->format->get_buffer(source->format, NULL, 0); <p>according to gdb. When I send Ogg Vorbis data (with Content-type: application/x-ogg), everything is OK. Am I doing something wrong with mp3 data? <p>Akos BTW, where is that libshout I'm supposed to figure out the ICE 1.0 protocol from? Are the meta fields different for Ogg Vorbis and mp3 streams? <p>--- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
> I'm trying to adapt darkice to the current state of icecast2. As I see, > there is a possibility to stream in various formats, by specifying a > Content-type field on the source header.All the hooks are there for other formats, but we haven't added any but Vorbis.> When I try to log in with an mp3 source, I get a seg fault from > icecast2. The connection looks something like: > > SOURCE /mountpoint ICE/1.0 > Content-type: audio/mpeg > ice-password: password > ice-bitrate: 96 > ice-public: 0 > ice-name: name > ice-description: description > ice-url: http://url.org > ice-genre: genre > > <here comes the raw mp3 data> > > > the seg fault occurs in icecast2 at line 150 of source.c: > > > refbuf = source->format->get_buffer(source->format, NULL, 0); > > > according to gdb. > > When I send Ogg Vorbis data (with Content-type: application/x-ogg), > everything is OK. > > Am I doing something wrong with mp3 data?MP3 isn't supported, but you should get an error, not a segfault. I'll dig into this a bit. Are you using current CVS? jack. --- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
Jack Moffitt wrote:> All the hooks are there for other formats, but we haven't added any but > Vorbis.I see,> MP3 isn't supported, but you should get an error, not a segfault. I'll > dig into this a bit. Are you using current CVS?yes, current CVS <p>--- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.