Luca Cireddu
2014-Jan-08 19:41 UTC
[Icecast-dev] Possible memory leak in Icecast-2.4-beta3
<html>
<head>
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Thanks Thomas,<br>
I successed running icecast in Valgrind using a Dell PowerEdge
rack server with a single Debian 7 64bit Virtual Machine.<br>
No memory leaks reported, but I'm working in a "lab
environment"...<br>
I'm trying to "simulate" different listeners using curl in a
bash
script with random connections and disconnections.<br>
I will report asap some result about testing, but I'm not a good
Valgrind-er, so any help or suggestion is welcome.<br>
<br>
On 12/08/2013 03:19 PM, "Thomas B. Rücker" wrote:<br>
</div>
<blockquote cite="mid:52A48003.5020804@ruecker.fi"
type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 12/06/2013 04:57 PM, voice
wrote:<br>
</div>
<blockquote
cite="mid:CAExdBCur62OoT8JvgwbxMkqAS=OvAis8TK0sC1WwxEmY+0r_9Q@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>Putting my hat into the ring as well to report memory
leak issues using 2.3.99.3.<br>
</div>
</div>
<div class="gmail_extra"><br>
On Mon, Oct 28, 2013 at 3:30 AM, Luca Cireddu <span
dir="ltr"><<a
moz-do-not-send="true"
href="mailto:sardylan@gmail.com"
target="_blank">sardylan@gmail.com</a>></span>
wrote:<br>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0
0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Hi all,<br>
Icecast increase memory usage on our server too.<br>
When started, memory usage was about 0.5% of 1GB.<br>
After 2 or 3 months, about 15%.<br>
I tried also to use valgrind to debug icecast sources,
but my machine is too slow to keep it running through
it, and it crashes.<br>
<br>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br>
To everyone, please help pinpointing this by running Icecast in
Valgrind.<br>
I'll try to also set up a test setup, but it's possible that this
doesn't show up in a lab environment.<br>
<br>
Cheers<br>
<br>
Thomas<br>
</blockquote>
<br>
Cheers<br>
Luca<br>
</body>
</html>
"Thomas B. Rücker"
2014-Jan-09 08:53 UTC
[Icecast-dev] Possible memory leak in Icecast-2.4-beta3
On 08/01/14 21:41, Luca Cireddu wrote:> Thanks Thomas, > I successed running icecast in Valgrind using a Dell PowerEdge rack > server with a single Debian 7 64bit Virtual Machine. > No memory leaks reported, but I'm working in a "lab environment"... > I'm trying to "simulate" different listeners using curl in a bash > script with random connections and disconnections. > I will report asap some result about testing, but I'm not a good > Valgrind-er, so any help or suggestion is welcome. >I have a similar setup and simulate source and listener client connections, but so far no results. I'll try to see if I can find some small public server that gets some traffic which I could run under valgrind. cheers Thomas> On 12/08/2013 03:19 PM, "Thomas B. R?cker" wrote: >> On 12/06/2013 04:57 PM, voice wrote: >>> Putting my hat into the ring as well to report memory leak issues >>> using 2.3.99.3. >>> >>> On Mon, Oct 28, 2013 at 3:30 AM, Luca Cireddu <sardylan at gmail.com >>> <mailto:sardylan at gmail.com>> wrote: >>> >>> Hi all, >>> Icecast increase memory usage on our server too. >>> When started, memory usage was about 0.5% of 1GB. >>> After 2 or 3 months, about 15%. >>> I tried also to use valgrind to debug icecast sources, but my >>> machine is too slow to keep it running through it, and it crashes. >>> >> >> To everyone, please help pinpointing this by running Icecast in Valgrind. >> I'll try to also set up a test setup, but it's possible that this >> doesn't show up in a lab environment. >> >> Cheers >> >> Thomas > > Cheers > Luca > > > _______________________________________________ > Icecast-dev mailing list > Icecast-dev at xiph.org > http://lists.xiph.org/mailman/listinfo/icecast-dev-------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/icecast-dev/attachments/20140109/35eeddd2/attachment.htm
"Thomas B. Rücker"
2014-Jan-12 22:01 UTC
[Icecast-dev] Possible memory leak in Icecast-2.4-beta3
Hi everyone, thanks for everyone's help and persistence! We've been successful in finding a memory leak (hopefully /the/ memory leak). The main credit goes to Philipp for taking the Valgrind hints and then digging through the pretty awful part of the code and then fixing it: Author: ph3-der-loewe Date: 2014-01-12 13:09:04 -0800 (Sun, 12 Jan 2014) New Revision: 19054 Modified: icecast/trunk/icecast/src/format_ogg.c icecast/trunk/icecast/src/refbuf.c Log: fixed(?) a memory leak: lost headers of stream because of wrong ref counter in associated refbuf objects. I HATE refbuf. This was a major step towards release, I'll try to roll a beta4/RC1 ASAP. Feel free to test the fix on trunk meanwhile (we also need to confirm we didn't regress in metadata handling). Cheers Thomas