Icecast dev - Oct 2007 - Patch to support .pls .asx .ram .qtl listing formats on last SVN

Hi Karl,
> While I think most of this is fine, I think in the fserve part (where
> the checks to see if there is a playlist file in webroot), they all
> seem to follow the same pattern so that would tend to indicate a
> function to reduce duplication.
>
> At the moment I'm wondering whether these responses could be
> automatically generated from xslt files? like xspf is.
>
> karl.
I have developed this patch to avoid us to create "by hand"
one file for each listing format for each mounts.

One part of the problem with icecast is that you cannot choose
mime  type of each web files or having ASIS file like on Apache.

I have cloned fserve functions to have dissociate functions
for each kind of listing format and don't have one huge function

I agree some part of the code could be included in a single
function to avoid code duplication. Make a function dispatcher
to point to each function who give the corresponding HTTP header
for each format.

Best Regards,
Guy

-- 

Infomaniak Network SA
Guy Baconniere <baco@infomaniak.ch>
Unix System Administrator
Certified Linux Engineer (RHCE, LPIC-2)
Avenue de la Praille 26
1227 Carouge (Geneva)
Switzerland (CH)
Phone +41 (0)22 820 3541
Fax +41 (0)22 820 3546
AS29222 / BACO-RIPE

Infomaniak Network SA / Guy Baconniere wrote:
> Hi Karl,
> 
>> While I think most of this is fine, I think in the fserve part (where
>> the checks to see if there is a playlist file in webroot), they all
>> seem to follow the same pattern so that would tend to indicate a
>> function to reduce duplication.
>>
>> At the moment I'm wondering whether these responses could be
>> automatically generated from xslt files? like xspf is.
>>
>> karl.
> 
> I have developed this patch to avoid us to create "by hand"
> one file for each listing format for each mounts.
with the xslt approach, it would be 1 xsl file for each format not each 
mountpoint. The xslt would just be a template.
> One part of the problem with icecast is that you cannot choose
> mime  type of each web files or having ASIS file like on Apache.
I've made it now so that you can specify the mime type in the xsl file 
with the media-type setting. It was hardcoded to one type before which 
was limiting.
> I have cloned fserve functions to have dissociate functions
> for each kind of listing format and don't have one huge function
> 
> I agree some part of the code could be included in a single
> function to avoid code duplication. Make a function dispatcher
> to point to each function who give the corresponding HTTP header
> for each format.
I suspect we could define a /admin/buildplaylist and pass the type as an 
arg, allowing for multiple types and multiple streams to be listed. So 
for example /admin/playlist?mount=/stream&type=pls

karl.

Is it at all possible to add Icecast2 Relays or Mounts without having 
to restart the server, and thus drop all the other existing 
connections in the process?

Thanks.
-g.
__________________________________________________________________________
Greg J. Ogonowski
VP Product Development
ORBAN / CRL, Inc.
Diamond Bar, CA  91765  USA
greg@orban.com
http://www.orban.com