Icecast dev - Aug 2004 - [PATCH] Solaris needs sys/types.h for uint32_t

Otherwise, well, things tend not to pan out as they should when compiling
anything that #includes md5.h

Patch against cvs HEAD attached

/dale
-------------- next part --------------
Index: src/md5.h
==================================================================RCS file:
/usr/local/cvsroot/icecast/src/md5.h,v
retrieving revision 1.2
diff -u -r1.2 md5.h
--- src/md5.h	29 Jan 2004 01:02:06 -0000	1.2
+++ src/md5.h	9 Mar 2004 07:41:47 -0000
@@ -16,6 +16,10 @@
 #include "config.h"
 #include "compat.h"
 
+#ifdef HAVE_SYS_TYPES_H
+    #include <sys/types.h>
+#endif
+
 #define HASH_LEN     16
 
 struct MD5Context
+mb+rzqk7&zzmy:.mkabzhj]zrj)
'+a{
+v&{ay,ry'rzg-b"V	~)mz

On Tue, Mar 09, 2004 at 02:44:09AM -0500, Dale Ghent wrote:
>  #include "config.h"
>  #include "compat.h"
>  
> +#ifdef HAVE_SYS_TYPES_H
> +    #include <sys/types.h>
> +#endif
> +
compat.h is supposed to make sure the stdint.h types are available. This is a
royal pain,
generally speaking, because of all the platforms that define some of the types
in random general
headers.

Doesn't solaris also provide them in inttypes.h? maybe this would be more
appropriate (in
compat.h):

#  if defined(HAVE_STDINT_H)
#    include <stdint.h>
#  elif defined(HAVE_INTTYPES_H)
#    include <inttypes.h>
#  endif

With the appropriate check in configure.

 -r
--- >8 ----
List archives:  http://www.xiph.org/archives/
icecast project homepage: http://www.icecast.org/
To unsubscribe from this list, send a message to
'icecast-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

On Mar 9, 2004, at 12:33 PM, Ralph Giles wrote:
>
> Doesn't solaris also provide them in inttypes.h? maybe this would be 
> more appropriate (in
> compat.h):
You are correct, sir. Solaris does indeed have inttypes.h, which 
includes sys/inttypes.h, which then includes sys/int_types.h, which 
defines uint32_t :)

The AC_HEADER_STDC macro already looks for inittypes.h, so all we 
needed to do is add the ifdef to compat.h to include it.

Attached is a patch with the necessary changes to src/compat.h, which 
pretty much mirrors your suggestion.

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: uint32-compat.patch
Type: application/octet-stream
Size: 532 bytes
Desc: uint32-compat.patch
Url :
http://lists.xiph.org/pipermail/icecast-dev/attachments/20040309/890dbf43/uint32-compat.obj