On Tue, 19 Nov 2002 00:54:13 +1100 Michael Smith <msmith@xiph.org> wrote:> At 12:23 PM 18/11/2002 +0000, you wrote: > >The icecast2 code uses recv(2) to read data from a source and tests > >its returning value to see if something went wrong. The current code > >groups together two checks of the return value: > > > > This is a known problem, I just haven't had time to do anything about > it yet (had my final exam today). > > >The patch is a small change but looks longer because I indented the > >code. > > Well... don't do that, then. Patches that do mass reindenting will > always be rejected, unless there's a REALLY good reason to do so > (you not liking my indentation style is a very poor reason).I didn't do a massive reindenting. I reindented just that small part of the code. I thought it was a mess. Was it supposed to be like that?> MichaelPedro. -------------- next part -------------- A non-text attachment was scrubbed... Name: part Type: application/pgp-signature Size: 190 bytes Desc: not available Url : http://lists.xiph.org/pipermail/icecast-dev/attachments/20021118/faf070c3/part.pgp
>I didn't do a massive reindenting. I reindented just that small part of >the code. I thought it was a mess. Was it supposed to be like that?Yes. Michael <p>--- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
On Tue, 19 Nov 2002 13:06:02 +1100 Michael Smith <msmith@xiph.org> wrote:> > >I didn't do a massive reindenting. I reindented just that small part > >of the code. I thought it was a mess. Was it supposed to be like > >that? > > Yes.Ok, sorry for the reindenting then. Is the patch a correct fix? I couldn't find any docs explaining what recv(2) returning 0 meant. I assumed it was end of stream.> MichaelPedro. -------------- next part -------------- A non-text attachment was scrubbed... Name: part Type: application/pgp-signature Size: 190 bytes Desc: not available Url : http://lists.xiph.org/pipermail/icecast-dev/attachments/20021119/2f24e457/part.pgp