Gluster users - Mar 2017 - Any way to get rid of zfs error messages?

> On Mar 6, 2017, at 2:36 PM, Niels de Vos <ndevos at redhat.com>
wrote:
> 
> On Mon, Mar 06, 2017 at 05:26:56PM +0100, Arman Khalatyan wrote:
>> hi, I have replicated glusterfs on 3 nodes with zfs, the logs are
flooded
>> with inodes error
>> 
>> [2017-03-06 16:24:15.019386] E [MSGID: 106419]
>> [glusterd-utils.c:5458:glusterd_add_inode_size_to_dict] 0-management:
could
>> not find (null) to getinode size for zclei21/01 (zfs): (null) package
>> missing?
>> 
>> Any way to fix it?
>> 
>> glusterfs --version
>> glusterfs 3.8.9 built on Feb 13 2017 10:03:47
> 
> We'll need to add the zfs command to fetch the size of the inodes. The
> commands for the different filesystems that we currently recognize are
> in the 'fs_info' structure at:
> 
https://github.com/gluster/glusterfs/blob/master/xlators/mgmt/glusterd/src/glusterd-utils.c#L5895
<https://github.com/gluster/glusterfs/blob/master/xlators/mgmt/glusterd/src/glusterd-utils.c#L5895>
ZFS ?doesn?t have inodes? and thus there is no way to get their size. Would it
be appropriate to treat it like Btrfs dynamic inodes, gluster wise? Would adding
?zfs, NULL, NULL, NULL, NULL? to the detect code avoid those errors?
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.gluster.org/pipermail/gluster-users/attachments/20170306/8ec08837/attachment.html>

On Mon, Mar 06, 2017 at 03:59:32PM -0600, Darrell Budic
wrote:
> 
> > On Mar 6, 2017, at 2:36 PM, Niels de Vos <ndevos at redhat.com>
wrote:
> > 
> > On Mon, Mar 06, 2017 at 05:26:56PM +0100, Arman Khalatyan wrote:
> >> hi, I have replicated glusterfs on 3 nodes with zfs, the logs are
flooded
> >> with inodes error
> >> 
> >> [2017-03-06 16:24:15.019386] E [MSGID: 106419]
> >> [glusterd-utils.c:5458:glusterd_add_inode_size_to_dict]
0-management: could
> >> not find (null) to getinode size for zclei21/01 (zfs): (null)
package
> >> missing?
> >> 
> >> Any way to fix it?
> >> 
> >> glusterfs --version
> >> glusterfs 3.8.9 built on Feb 13 2017 10:03:47
> > 
> > We'll need to add the zfs command to fetch the size of the inodes.
The
> > commands for the different filesystems that we currently recognize are
> > in the 'fs_info' structure at:
> > 
https://github.com/gluster/glusterfs/blob/master/xlators/mgmt/glusterd/src/glusterd-utils.c#L5895
<https://github.com/gluster/glusterfs/blob/master/xlators/mgmt/glusterd/src/glusterd-utils.c#L5895>
> 
> ZFS ?doesn?t have inodes? and thus there is no way to get their size.
> Would it be appropriate to treat it like Btrfs dynamic inodes, gluster
> wise? Would adding ?zfs, NULL, NULL, NULL, NULL? to the detect code
> avoid those errors?
It probably would, but an additional check on the NULL string for the
fs_tool would be nice. We can then skip sys_access() calls and just goto
the end of the function.

Niels
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL:
<http://lists.gluster.org/pipermail/gluster-users/attachments/20170307/6e6aa8bf/attachment.sig>