On 19/10/16 20:54, Jackie Tung wrote:> Thanks Jiffin, filed https://bugzilla.redhat.com/show_bug.cgi?id=1386766
>
> In my limited knowledge of the original reasons for 1GB hardcode,
> either removing the limit altogether, or an additional ?override"
> option parameter would be preferable in my humble opinion.
>
Thanks for filing the bug, patch posted for addressing this issue
http://review.gluster.org/15689
--
Jiffin
>> On Oct 19, 2016, at 2:02 AM, Jiffin Tony Thottan <jthottan at
redhat.com
>> <mailto:jthottan at redhat.com>> wrote:
>>
>> Hi Jackie,
>>
>>
>> On 18/10/16 23:48, Jackie Tung wrote:
>>> Hi all,
>>>
>>> Documentation says:
>>>
https://gluster.readthedocs.io/en/latest/Administrator%20Guide/Trash/
>>>
>>> */gluster volume set <VOLNAME> features.trash-max-filesize
<size>/*
>>>
>>> This command can be used to filter files entering trash directory
>>> based on their size. Files above trash_max_filesize are
>>> deleted/truncated directly.Value for size may be followed by
>>> multiplicative suffixes as KB(=1024 bytes), MB(=1024*1024 bytes)
and
>>> GB(=1024*1024*1024 bytes). Default size is set to 5MB. Considering
>>> the fact that trash directory is consuming the glusterfs volume
>>> space, trash feature is implemented to function in such a way
>>> that*it directly deletes/truncates files with size > 1GB even if
>>> this option is set to some value greater than 1GB.*
>>>
>>> Is there any workaround (short of changing source code and
>>> rebuilding) that can allow me to override this 1GB hard limit? We
>>> store a lot of large files, and having a limit of 1GB greatly
>>> reduces the value of this trashcan feature for us.
>>>
>>
>>
>> I don't remember exactly reason behind having a hard coded value
for
>> upper boundary, one reason may be to limit space used
>> by trash directory and for truncate operation it result in
>> performance hit. The hard coded value can be found at
>> xlators/features/trash/src/trash.h:32 (GF_ALLOWED_MAX_FILE_SIZE) . If
>> you are interested , then change value(according to
>> your preference) in the code and send out a patch to
>> http://review.gluster.org/ as well.
>>
>> As first step please file a bug https://bugzilla.redhat.com/ under
>> community->glusterfs->trash xlator.
>>
>> Regards,
>> Jiffin
>>
>>> Many thanks,
>>> Jackie
>>>
>>>
>>>
>>>
>>>
>>> The information in this email is confidential and may be legally
>>> privileged. It is intended solely for the addressee. Access to this
>>> email by anyone else is unauthorized. If you are not the intended
>>> recipient, any disclosure, copying, distribution or any action
taken
>>> or omitted to be taken in reliance on it, is prohibited and may be
>>> unlawful.
>>>
>>>
>>>
>>> _______________________________________________
>>> Gluster-users mailing list
>>> Gluster-users at gluster.org
>>> http://www.gluster.org/mailman/listinfo/gluster-users
>>
>
>
> The information in this email is confidential and may be legally
> privileged. It is intended solely for the addressee. Access to this
> email by anyone else is unauthorized. If you are not the intended
> recipient, any disclosure, copying, distribution or any action taken
> or omitted to be taken in reliance on it, is prohibited and may be
> unlawful.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://www.gluster.org/pipermail/gluster-users/attachments/20161021/815b242d/attachment.html>