freebsd stable - Mar 2021 - geli broken in 13.0-BETA4 and later

Somewhere between 13.0-ALPHA2 (c256201-g02611ef8ee9) and 13.0-BETA4
(releng/13.0-n244592-e32bc253629), geli (at least on my RockPro64 -
RK3399, arm64) has changed so that a geli-encrypted partition (using
AES-XTS 128) that was readable on 13.0-ALPHA2 becomes garbage on
13.0-BETA4.

I've verified that the garbage seems consistent between reboots and
isn't impacted by enabling the big cores in 7ba4d0f82955.  There's
nothing useful reported via geli debugging.

I've tried updating to releng/13.0 60e8939aa85b and it's still broken.

My suspicion is f76393a6305b - whilst that just talks about AES-GCM,
it does a reasonable job of roto-tilling the entire armv8crypto stack.
I notice that there are a fixes to f76393a6305b that don't seem to
have made it into releng/13.0 and I will continue to investigate.

-- 
Peter Jeremy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL:
<http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20210306/7dcddd3c/attachment.sig>

On 2021-Mar-06 19:18:37 +1100, Peter Jeremy via freebsd-stable
<freebsd-stable at freebsd.org> wrote:
>Somewhere between 13.0-ALPHA2 (c256201-g02611ef8ee9) and 13.0-BETA4
>(releng/13.0-n244592-e32bc253629), geli (at least on my RockPro64 -
>RK3399, arm64) has changed so that a geli-encrypted partition (using
>AES-XTS 128) that was readable on 13.0-ALPHA2 becomes garbage on
>13.0-BETA4.
I've confirmed that the problem is f76393a6305b - reverting that
commit fixes the problem in releng/13.0.

I've further verified that the bug is still present in main (14.x)
at 028616d0dd69.

-- 
Peter Jeremy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL:
<http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20210306/ae50b996/attachment.sig>