freebsd stable - Oct 2020 - calendar (1) - patch to correct error description

Here's another 2 calendar errors, presumably cpp, that manifest in
12.2-STABLE,
that 9.2-RELEASE gets right.

Man calendar:
	Empty lines and lines protected by the C commenting syntax
	(/* ...  */) are ignored.

--- Input ~/.calendar/calendar
friday	fish
/*
 * Oct 21	AAA
 */
friday	and chips
---12.2-STABLE output
Oct 30*	and chips
Oct 30 	AAA
Oct 30*	fish
Oct 31 	AAA
---9.2-RELEASE output
Oct 30*	and chips
Oct 30*	fish
---

Error 1:	Why does it emit AAA ?
Error 2:	Why twice ?
Puzzle: 	Doesnt happen if you change Oct above to Aug inside the comment.

(PS both do a nasty stack unstack, which may look familiar to us
programmers, but looks silly to normal peopler, inverting fish & chips)

Cheers,
-- 
Julian Stacey, Consultant Sys. Eng. BSD Linux Unix, http://berklix.com/jhs/cv/
Crash Brexit profits financial speculators in cabinet damaging Britain.
UK stole 3.7 million votes from Brits abroad 700 K in EU http://stolenvotes.uk

Am 30.10.20 um 00:48 schrieb Julian H. Stacey:
> Here's another 2 calendar errors, presumably cpp, that manifest in
12.2-STABLE,
> that 9.2-RELEASE gets right.
> 
> Man calendar:
> 	Empty lines and lines protected by the C commenting syntax
> 	(/* ...  */) are ignored.
> 
> --- Input ~/.calendar/calendar
> friday	fish
> /*
>   * Oct 21	AAA
>   */
> friday	and chips
> ---12.2-STABLE output
> Oct 30*	and chips
> Oct 30 	AAA
> Oct 30*	fish
> Oct 31 	AAA
> ---9.2-RELEASE output
> Oct 30*	and chips
> Oct 30*	fish
> ---
> 
> Error 1:	Why does it emit AAA ?
The version you used does only support /* ... */ on a single line.
The "*" in front of "Oct" seems to have been parsed as a
wild-card,
but I have not checked why it lead to be interpreted as "Oct 30".

This is fixed with the comment processing that I have added to the
internal pre-processor.
> Error 2:	Why twice ?
No idea and I do not consider this relevant now that the issue is
fixed.
> Puzzle: 	Doesnt happen if you change Oct above to Aug inside the comment.
Feel free to solve this puzzle, I really do not have the time to
waste on this question ;-)
> (PS both do a nasty stack unstack, which may look familiar to us
> programmers, but looks silly to normal peopler, inverting fish & chips)
Yes, a linked list that got built-up be putting the new element at
the head and the previously added values into the "next" field of
that element.


Please check the calendar version in -CURRENT or the deskutil/calendar
port version 0.6. Both issues should be fixed there.

Regards, STefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20201030/9c15f3a1/attachment.sig>