Trond Endrestøl
2020-Mar-05 12:54 UTC
r358661 breaks /usr/src/usr.sbin/amd/include/newvers.sh on stable/12
The command
"sh /usr/src/usr.sbin/amd/include/newvers.sh
/usr/src/sys/conf/newvers.sh"
is run a part of a normal build, creating config_local.h.
After r358661, I find this in my build logs for stable/12:
eval: 1: Syntax error: end of file unexpected (expecting ")")
eval: 1: Syntax error: Error in command substitution
Meta mode is activated, and the build logs gives this insight:
_ERROR_CMD='@rm -f config_local.h; sh
/usr/src/usr.sbin/amd/include/newvers.sh /usr/src/sys/conf/newvers.sh >
config_local.h;'
.CURDIR='/usr/src/usr.sbin/amd/include'
Any attempts to build again, results in:
--- amd.o ---
/usr/src/contrib/amd/amd/amd.c:275:17: error: use of undeclared identifier
'HOST_OS_NAME'
gopt.op_sys = HOST_OS_NAME;
^
/usr/src/contrib/amd/amd/amd.c:278:21: error: use of undeclared identifier
'HOST_OS_VERSION'
gopt.op_sys_ver = HOST_OS_VERSION;
^
/usr/src/contrib/amd/amd/amd.c:281:22: error: use of undeclared identifier
'HOST_OS'
gopt.op_sys_full = HOST_OS;
^
3 errors generated.
CC-ing imp@ as he's the author of r358661.
--
Trond.
David Wolfskill
2020-Mar-05 13:01 UTC
r358661 breaks /usr/src/usr.sbin/amd/include/newvers.sh on stable/12
On Thu, Mar 05, 2020 at 01:54:58PM +0100, Trond Endrest?l wrote:> The command > "sh /usr/src/usr.sbin/amd/include/newvers.sh /usr/src/sys/conf/newvers.sh" > is run a part of a normal build, creating config_local.h. > > After r358661, I find this in my build logs for stable/12: > > eval: 1: Syntax error: end of file unexpected (expecting ")") > eval: 1: Syntax error: Error in command substitution > ....As Tomoaki AOKI <junchoon at dec.sakura.ne.jp> pointed out (in svn-src-stable-12@): | This should be MFC'ed with r346022, otherwise usr.sbin/amd | does not build. (I hand-applied the change, and the build (and suibsequent reboot & smoke-test) succeeded.) Peace, david -- David H. Wolfskill david at catwhisker.org "Racism is a poison, hatred is a poison." -- Angela Merkel See http://www.catwhisker.org/~david/publickey.gpg for my public key. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 618 bytes Desc: not available URL: <http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20200305/38e01d45/attachment.sig>