Konstantin Belousov
2018-Dec-27 21:10 UTC
Error upgrading 11-STABLE to 12-STABLE in ifunc resolver
On Thu, Dec 27, 2018 at 09:41:06PM +0100, Thierry Thomas wrote:> Hello, > > Trying to upgrade a machine from > > 11.2-STABLE #0 r337833: Wed Aug 15 12:50:47 CEST 2018 > > to 12-STABLE as: > > Working Copy Root Path: /usr/src > URL: https://svn.freebsd.org/base/stable/12 > Relative URL: ^/stable/12 > Repository Root: https://svn.freebsd.org/base > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 342558 > Node Kind: directory > Schedule: normal > Last Changed Author: kp > Last Changed Rev: 342545 > Last Changed Date: 2018-12-26 13:56:36 +0100 (Wed, 26 Dec 2018) > > aborts due to this error: > > /usr/local/libexec/ccache/world/cc -target x86_64-unknown-freebsd12.0 --sysroot=/usr/obj/usr/src/amd64.amd64/tmp -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -O2 -pipe -DNO__SCCSID -DNO__RCSID -I/usr/src/lib/libc/include -I/usr/src/include -I/usr/src/lib/libc/amd64 -DNLS -D__DBINTERFACE_PRIVATE -I/usr/src/contrib/gdtoa -I/usr/src/contrib/libc-vis -DINET6 -I/usr/obj/usr/src/amd64.amd64/lib/libc -I/usr/src/lib/libc/resolv -D_ACL_PRIVATE -DPOSIX_MISTAKE -I/usr/src/lib/libmd -I/usr/src/contrib/jemalloc/include -I/usr/src/contrib/tzcode/stdtime -I/usr/src/lib/libc/stdtime -I/usr/src/lib/libc/locale -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/usr/src/lib/libc/rpc -DWANT_HYPERV -DYP -DNS_CACHING -DSYMBOL_VERSIONING -g -MD -MF.depend.amd64_set_fsbase.o -MTamd64_set_fsbase.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Qunused-arguments -I/usr/src/lib/libutil -I/usr/src/lib/msun/amd64 -I/usr/src/lib/msun/x86 -I/usr/src/lib/msun/src -c /usr/src/lib/libc/amd64/sys/amd64_set_fsbase.c -o amd64_set_fsbase.o > --- amd64_get_fsbase.o --- > /usr/src/lib/libc/amd64/sys/amd64_get_fsbase.c:60:1: error: ifunc resolver function must have no parameters > DEFINE_UIFUNC(, int, amd64_get_fsbase, (void **), static) > ^ > /usr/obj/usr/src/amd64.amd64/tmp/usr/include/x86/ifunc.h:43:44: note: expanded from macro 'DEFINE_UIFUNC' > qual ret_type name args __attribute__((ifunc(#name "_resolver"))); \ > > cc is: > FreeBSD clang version 6.0.1 (tags/RELEASE_601/final 335540) (based on LLVM 6.0.1) > > This problem has already been reported in > <https://lists.freebsd.org/pipermail/freebsd-current/2018-November/071980.html> > and should be fixed with clang 7, but I'm surprised that it seems > impossible to upgrade from 11-STABLE to 12-STABLE; did I miss something?Yes, you should update to the latest stable/11. More details, you need to have host clang which includes the r339284 commit.
Warner Losh
2018-Dec-27 22:19 UTC
Error upgrading 11-STABLE to 12-STABLE in ifunc resolver
On Thu, Dec 27, 2018, 4:11 PM Konstantin Belousov <kostikbel at gmail.com wrote:> On Thu, Dec 27, 2018 at 09:41:06PM +0100, Thierry Thomas wrote: > > Hello, > > > > Trying to upgrade a machine from > > > > 11.2-STABLE #0 r337833: Wed Aug 15 12:50:47 CEST 2018 > > > > to 12-STABLE as: > > > > Working Copy Root Path: /usr/src > > URL: https://svn.freebsd.org/base/stable/12 > > Relative URL: ^/stable/12 > > Repository Root: https://svn.freebsd.org/base > > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > Revision: 342558 > > Node Kind: directory > > Schedule: normal > > Last Changed Author: kp > > Last Changed Rev: 342545 > > Last Changed Date: 2018-12-26 13:56:36 +0100 (Wed, 26 Dec 2018) > > > > aborts due to this error: > > > > /usr/local/libexec/ccache/world/cc -target x86_64-unknown-freebsd12.0 > --sysroot=/usr/obj/usr/src/amd64.amd64/tmp > -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -O2 -pipe -DNO__SCCSID > -DNO__RCSID -I/usr/src/lib/libc/include -I/usr/src/include > -I/usr/src/lib/libc/amd64 -DNLS -D__DBINTERFACE_PRIVATE > -I/usr/src/contrib/gdtoa -I/usr/src/contrib/libc-vis -DINET6 > -I/usr/obj/usr/src/amd64.amd64/lib/libc -I/usr/src/lib/libc/resolv > -D_ACL_PRIVATE -DPOSIX_MISTAKE -I/usr/src/lib/libmd > -I/usr/src/contrib/jemalloc/include -I/usr/src/contrib/tzcode/stdtime > -I/usr/src/lib/libc/stdtime -I/usr/src/lib/libc/locale -DBROKEN_DES > -DPORTMAP -DDES_BUILTIN -I/usr/src/lib/libc/rpc -DWANT_HYPERV -DYP > -DNS_CACHING -DSYMBOL_VERSIONING -g -MD -MF.depend.amd64_set_fsbase.o > -MTamd64_set_fsbase.o -std=gnu99 -fstack-protector-strong -Wsystem-headers > -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign > -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable > -Wno-tautological-compare -Wno-unuse > d-value -Wno-parentheses-equality -Wno-unused-function > -Wno-enum-conversion -Wno-unused-local-typedef > -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum > -Wno-knr-promoted-parameter -Qunused-arguments -I/usr/src/lib/libutil > -I/usr/src/lib/msun/amd64 -I/usr/src/lib/msun/x86 -I/usr/src/lib/msun/src > -c /usr/src/lib/libc/amd64/sys/amd64_set_fsbase.c -o amd64_set_fsbase.o > > --- amd64_get_fsbase.o --- > > /usr/src/lib/libc/amd64/sys/amd64_get_fsbase.c:60:1: error: ifunc > resolver function must have no parameters > > DEFINE_UIFUNC(, int, amd64_get_fsbase, (void **), static) > > ^ > > /usr/obj/usr/src/amd64.amd64/tmp/usr/include/x86/ifunc.h:43:44: note: > expanded from macro 'DEFINE_UIFUNC' > > qual ret_type name args __attribute__((ifunc(#name "_resolver"))); \ > > > > cc is: > > FreeBSD clang version 6.0.1 (tags/RELEASE_601/final 335540) (based on > LLVM 6.0.1) > > > > This problem has already been reported in > > < > https://lists.freebsd.org/pipermail/freebsd-current/2018-November/071980.html > > > > and should be fixed with clang 7, but I'm surprised that it seems > > impossible to upgrade from 11-STABLE to 12-STABLE; did I miss something? > > Yes, you should update to the latest stable/11. More details, you need > to have host clang which includes the r339284 commit. >We either need to fix this problem, or we need to bump the minimum in Makefile.inc1. Warner _______________________________________________> freebsd-stable at freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe at freebsd.org" >
On Thu, 27 Dec 2018 at 17:20, Warner Losh <imp at bsdimp.com> wrote:> > > Yes, you should update to the latest stable/11. More details, you need > > to have host clang which includes the r339284 commit. > > We either need to fix this problem, or we need to bump the minimum in > Makefile.inc1.amd64_get_fsbase.c should be compiled with the toolchain built for stable/12 and this error shouldn't occur absent non-default flags such as WITHOUT_CLANG_BOOTSTRAP, I believe. Thierry did this occur with a plain make buildworld, without src.conf settings?