freebsd stable - Apr 2018 - [Bug 227323] [patch] [spi] sys/modules/spi/mx25l cannot be built outside of kernel build environment

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227323

            Bug ID: 227323
           Summary: [patch] [spi] sys/modules/spi/mx25l cannot be built
                    outside of kernel build environment
           Product: Base System
           Version: 11.1-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Keywords: easy, patch-ready
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: loos at FreeBSD.org
          Reporter: eugen at freebsd.org
                CC: eadler at FreeBSD.org, ian at FreeBSD.org,
                    stable at FreeBSD.org

Created attachment 192286
  -->
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=192286&action=edit
The fix

# cd /usr/src/sys/modules/spi/mx25l && make
cc -O2 -pipe  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc  
-I. -I/home/src/sys -fno-common  -fno-omit-frame-pointer
-mno-omit-leaf-frame-pointer   -MD  -MF.depend.mx25l.o -MTmx25l.o
-mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float 
-fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall
-Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes
-Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign
-D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs
-fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare
-Wno-error-empty-body -Wno-error-parentheses-equality
-Wno-error-unused-function -Wno-error-pointer-sign
-Wno-error-shift-negative-value -Wno-error-address-of-packed-member  -mno-aes
-mno-avx  -std=iso9899:1999 -c /home/src/sys/dev/flash/mx25l.c -o mx25l.o
/home/src/sys/dev/flash/mx25l.c:30:10: fatal error: 'opt_platform.h'
file not
found
#include "opt_platform.h"
         ^~~~~~~~~~~~~~~~
1 error generated.
*** Error code 1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227323

--- Comment #1 from commit-hook at freebsd.org ---
A commit references this bug:

Author: ian
Date: Fri Apr  6 16:48:08 UTC 2018
New revision: 332113
URL: https://svnweb.freebsd.org/changeset/base/332113

Log:
  MFC r331868:

  Add opt_platform.h for several modules that have #ifdef FDT in the source.

  Submitted by: Andre Albsmeier <Andre.Albsmeier at siemens.com>

  PR:           227322 227323

Changes:
  stable/11/sys/modules/i2c/iicbus/Makefile
  stable/11/sys/modules/i2c/isl/Makefile
  stable/11/sys/modules/spi/at45d/Makefile
  stable/11/sys/modules/spi/mx25l/Makefile
  stable/11/sys/modules/spi/spibus/Makefile

-- 
You are receiving this mail because:
You are on the CC list for the bug.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227323

Ian Lepore <ian at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|New                         |Closed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

On Fri, 2018-04-06 at 13:09 +0000, bugzilla-noreply at freebsd.org
wrote:
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227323
> 
> ????????????Bug ID: 227323
> ???????????Summary: [patch] [spi] sys/modules/spi/mx25l cannot be
> built
> ????????????????????outside of kernel build environment
> ???????????Product: Base System
> ???????????Version: 11.1-STABLE
> ??????????Hardware: Any
> ????????????????OS: Any
> ????????????Status: New
> ??????????Keywords: easy, patch-ready
> ??????????Severity: Affects Some People
> ??????????Priority: ---
> ?????????Component: kern
> ??????????Assignee: loos at FreeBSD.org
> ??????????Reporter: eugen at freebsd.org
> ????????????????CC: eadler at FreeBSD.org, ian at FreeBSD.org,
> ????????????????????stable at FreeBSD.org
> 
> Created attachment 192286
> ? -->
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=192286&acti
> on=edit
> The fix
> 
> # cd /usr/src/sys/modules/spi/mx25l && make
> cc -O2 -pipe??-fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE
> -nostdinc??
> -I. -I/home/src/sys -fno-common??-fno-omit-frame-pointer
> -mno-omit-leaf-frame-pointer???-MD??-MF.depend.mx25l.o -MTmx25l.o
> -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float?
> -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-
> protector -Wall
> -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-
> prototypes
> -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign
> -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs
> -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-
> tautological-compare
> -Wno-error-empty-body -Wno-error-parentheses-equality
> -Wno-error-unused-function -Wno-error-pointer-sign
> -Wno-error-shift-negative-value -Wno-error-address-of-packed-
> member??-mno-aes
> -mno-avx??-std=iso9899:1999 -c /home/src/sys/dev/flash/mx25l.c -o
> mx25l.o
> /home/src/sys/dev/flash/mx25l.c:30:10: fatal error:
'opt_platform.h'
> file not
> found
> #include "opt_platform.h"
> ?????????^~~~~~~~~~~~~~~~
> 1 error generated.
> *** Error code 1
> 
Does anybody know why mailing lists have recently started being spammed
with bug reports? ?Using the list to point out a bug that's been
languishing without attention for a while might be appropriate, but
spamming the list with every action on every bug, IMO, is not.

-- Ian

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227323

Eugene Grosbein <eugen at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.freebsd.org/bu
                   |                            |gzilla/show_bug.cgi?id=2391
                   |                            |19

-- 
You are receiving this mail because:
You are on the CC list for the bug.