On Sat, 2018-03-10 at 23:42 +0000, Pete French wrote:> > > > It looks like r330745 applies fine to stable-11 without any changes, > > and there's plenty of value in testing that as well, if you're already > > set up for that world. > > > > Ive been running the patch from the PR in production since the original? > bug report and it works fine. I havent looked at r330745 yes, but can? > replace the PR patch with that and give it a whirl.... will take a look? > Monday at whats possible. > > -pete. >I based my fix heavily on that patch from the PR, but I rewrote it enough that I might've made any number of mistakes, so it needs fresh testing. ?The main change I made was to make it a lot less noisy while waiting (it only mentions the wait once, unless bootverbose is set, in which case it's once per second). ?I also removed the logic that limited the retries to nfs and zfs, because I think we can remove all the old code related to waiting that only worked for ufs and let this new retry be the way it waits for all filesystems. ?But that's a bigger change we can do separately; I didn't want to hold up this fix any longer. -- Ian
On 10/03/2018 23:48, Ian Lepore wrote:> I based my fix heavily on that patch from the PR, but I rewrote it > enough that I might've made any number of mistakes, so it needs fresh > testing. ?The main change I made was to make it a lot less noisy while > waiting (it only mentions the wait once, unless bootverbose is set, in > which case it's once per second). ?I also removed the logic that > limited the retries to nfs and zfs, because I think we can remove all > the old code related to waiting that only worked for ufs and let this > new retry be the way it waits for all filesystems. ?But that's a bigger > change we can do separately; I didn't want to hold up this fix any > longer.TThansk for the patch, its is very much appercaited! I applied this earlier today, and have been continuously rebooting the machine in Azure ever since (every ten minutes). This has worked flawlessly, so I am very happy that this fixes the issue for me. I am going to leave it running though, just to see if anything happens. I havent examined dmesg, but I thould be able to see the output from the patch there to verify that its waiting, yes ? cheers, -pete.
> I based my fix heavily on that patch from the PR, but I rewrote it > enough that I might've made any number of mistakes, so it needs fresh > testing.Ok, have been rebooting with the patch eery ten minutes for 24 hours now, and it comes back up perfectly every time, so as far as I am concerned thats sufficient testing for me to say its fixed and I would be very happy to have it merged into STABLE (and I;ll then roll it out everywhere). Thanks! -pete.