Konstantin Belousov
2017-Jul-09 12:23 UTC
11.1-RC2 breaks wine, creates unkillable process
On Sun, Jul 09, 2017 at 01:53:24PM +0200, Jan Kokem??ller wrote:> Same here on -CURRENT r320620. r319481 (I think) was working fine. > > I'm using the i386-wine-devel package from the official repository.This should fix creation of the unkillable processes, but untested. After that, if wine still does not work, you need to look exactly what breaks, perhaps using ktrace. Most likely there would be some unsuccessfull mmap(2) syscall. diff --git a/sys/vm/vm_map.c b/sys/vm/vm_map.c index 0a99ddde486..a0688fe4f0c 100644 --- a/sys/vm/vm_map.c +++ b/sys/vm/vm_map.c @@ -1571,7 +1571,7 @@ vm_map_find_min(vm_map_t map, vm_object_t object, vm_ooffset_t offset, find_space, prot, max, cow); if (rv == KERN_SUCCESS || min_addr >= hint) return (rv); - *addr = min_addr; + *addr = hint = min_addr; } }
> This should fix creation of the unkillable processes, but untested.Thank you, wine works fine again with this patch applied.
On 09.07.2017 14:23, Konstantin Belousov wrote:> On Sun, Jul 09, 2017 at 01:53:24PM +0200, Jan Kokem??ller wrote: >> Same here on -CURRENT r320620. r319481 (I think) was working fine. >> >> I'm using the i386-wine-devel package from the official repository. > > This should fix creation of the unkillable processes, but untested. > > After that, if wine still does not work, you need to look exactly > what breaks, perhaps using ktrace. Most likely there would be some > unsuccessfull mmap(2) syscall.The patch fixes the issue. No problems so far, but only tested simple applications. Thank you for the quick fix.
Konstantin Belousov <kostikbel at gmail.com> wrote:> On Sun, Jul 09, 2017 at 01:53:24PM +0200, Jan Kokem??ller wrote: > > Same here on -CURRENT r320620. r319481 (I think) was working fine. > > > > I'm using the i386-wine-devel package from the official repository. > > This should fix creation of the unkillable processes, but untested. > > After that, if wine still does not work, you need to look exactly > what breaks, perhaps using ktrace. Most likely there would be some > unsuccessfull mmap(2) syscall. > > diff --git a/sys/vm/vm_map.c b/sys/vm/vm_map.c > index 0a99ddde486..a0688fe4f0c 100644 > --- a/sys/vm/vm_map.c > +++ b/sys/vm/vm_map.c > @@ -1571,7 +1571,7 @@ vm_map_find_min(vm_map_t map, vm_object_t object, vm_ooffset_t offset, > find_space, prot, max, cow); > if (rv == KERN_SUCCESS || min_addr >= hint) > return (rv); > - *addr = min_addr; > + *addr = hint = min_addr; > } > } >Can someone tell me if this got fixed before 11.1-RELEASE? Thanks in advance and best regards, Frank