freebsd stable - Mar 2017 - IPFW kernel build failing on 11.0-STABLE

Tried building IPFW into my kernel and it failed midway with this:

cc  -c -O2 -pipe -fno-strict-aliasing  -g -nostdinc  -I.
-I/usr/src/sys -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_
KERNEL_OPTION_HEADERS -include opt_global.h  -fno-omit-frame-pointer
-mno-omit-leaf-frame-pointer -MD  -MF.depend.ppb_1
284.o -MTppb_1284.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse
-msoft-float  -fno-asynchronous-unwind-tables -ffre
estanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls
-Wnested-externs -Wstrict-prototypes  -Wmissing-p
rototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
-Wno-pointer-sign -D__printf__=__freebsd_kprintf__  -Wmissing-i
nclude-dirs -fdiagnostics-show-option  -Wno-unknown-pragmas
-Wno-error-tautological-compare -Wno-error-empty-body  -Wn
o-error-parentheses-equality -Wno-error-unused-function
-Wno-error-pointer-sign -Wno-error-shift-negative-value  -mno-
aes -mno-avx  -std=iso9899:1999 -Werror  /usr/src/sys/dev/ppbus/ppb_1284.c
/usr/src/sys/dev/ppbus/ppb_1284.c:296:46: error: implicit conversion
from 'int' to 'char' changes value from 144 to
      -112 [-Werror,-Wconstant-conversion]
        if ((error = do_peripheral_wait(bus, SELECT | nBUSY, 0))) {
                     ~~~~~~~~~~~~~~~~~~      ~~~~~~~^~~~~~~
/usr/src/sys/dev/ppbus/ppb_1284.c:785:48: error: implicit conversion
from 'int' to 'char' changes value from 240 to -16
      [-Werror,-Wconstant-conversion]
                if (do_1284_wait(bus, nACK | SELECT | PERROR | nBUSY,
                    ~~~~~~~~~~~~      ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/usr/src/sys/dev/ppbus/ppb_1284.c:786:29: error: implicit conversion
from 'int' to 'char' changes value from 240 to -16
      [-Werror,-Wconstant-conversion]
                                        nACK | SELECT | PERROR | nBUSY)) {
                                        ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
/usr/src/sys/dev/ppbus/ppb_1284.c:841:37: error: implicit conversion
from 'int' to 'char' changes value from 200 to -56
      [-Werror,-Wconstant-conversion]
        if (do_1284_wait(bus, nACK | nBUSY | nFAULT, nFAULT)) {
            ~~~~~~~~~~~~      ~~~~~~~~~~~~~^~~~~~~~
4 errors generated.
*** Error code 1
Stop.
make[2]: stopped in /usr/obj/usr/src/sys/IPFW
*** Error code 1
Stop.
make[1]: stopped in /usr/src
*** Error code 1
Stop.
make: stopped in /usr/src
q
[1]    Exit 1                        ( make buildkernel KERNCONF=IPFW
&& make installkernel KERNCONF=IPFW )
root@****:/usr/src # uname -a
FreeBSD **** 11.0-STABLE FreeBSD 11.0-STABLE #0 r314941: Thu Mar  9
19:39:31 UTC 2017
root at releng2.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

On Tue, Mar 14, 2017 at 10:09:06PM -0500, Steven Borrelli via freebsd-stable
wrote:
> Tried building IPFW into my kernel and it failed midway with this:
> ....
My laptop's kernel (config file named "CANARY") includes IPFW;
this
morning's stable/11 update from:

FreeBSD g1-252.catwhisker.org 11.0-STABLE FreeBSD 11.0-STABLE #280 
r315241M/315241:1100509: Tue Mar 14 04:48:24 PDT 2017     root at
g1-252.catwhisker.org:/common/S1/obj/usr/src/sys/CANARY  amd64

to 

FreeBSD g1-252.catwhisker.org 11.0-STABLE FreeBSD 11.0-STABLE #281 
r315302M/315302:1100509: Wed Mar 15 04:56:42 PDT 2017     root at
g1-252.catwhisker.org:/common/S1/obj/usr/src/sys/CANARY  amd64

was ... "uneventful" -- it Just Worked.

Peace,
david
-- 
David H. Wolfskill				david at catwhisker.org
Claims that lack evidence are not a basis for rational decision-making.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 603 bytes
Desc: not available
URL:
<http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20170315/6316d802/attachment.sig>