freebsd stable - Oct 2016 - aibs(4) / atk0110 support for newer systems

On 05/10/2016 23:28, Torfinn Ingolfsen wrote:
> #6  0xffffffff80cd0081 in calltrap ()
>     at /usr/src/sys/amd64/amd64/exception.S:238
> #7  0xffffffff81bcb078 in aibs_add_sensor () from /boot/kernel/aibs.ko
> #8  0xffffffff81bcb4b4 in aibs_attach_sif () from /boot/kernel/aibs.ko
Argh, I've just spotted a very silly typo.
Could you please replace '0' with 'o' in
	err = aibs_add_sensor(sc, 0, &as[i], &descr);
?
I wish compilers were more noisy about passing a scalar as a pointer argument.

Thanks!
-- 
Andriy Gapon

On 06/10/2016 00:37, Andriy Gapon wrote:
> On 05/10/2016 23:28, Torfinn Ingolfsen wrote:
>> #6  0xffffffff80cd0081 in calltrap ()
>>     at /usr/src/sys/amd64/amd64/exception.S:238
>> #7  0xffffffff81bcb078 in aibs_add_sensor () from /boot/kernel/aibs.ko
>> #8  0xffffffff81bcb4b4 in aibs_attach_sif () from /boot/kernel/aibs.ko
> 
> Argh, I've just spotted a very silly typo.
> Could you please replace '0' with 'o' in
> 	err = aibs_add_sensor(sc, 0, &as[i], &descr);
> ?
Ping.


-- 
Andriy Gapon

On Thu, 6 Oct 2016 00:37:16 +0300
Andriy Gapon <avg at FreeBSD.org> wrote:
> On 05/10/2016 23:28, Torfinn Ingolfsen wrote:
> > #6  0xffffffff80cd0081 in calltrap ()
> >     at /usr/src/sys/amd64/amd64/exception.S:238
> > #7  0xffffffff81bcb078 in aibs_add_sensor () from /boot/kernel/aibs.ko
> > #8  0xffffffff81bcb4b4 in aibs_attach_sif () from /boot/kernel/aibs.ko
> 
> Argh, I've just spotted a very silly typo.
> Could you please replace '0' with 'o' in
> 	err = aibs_add_sensor(sc, 0, &as[i], &descr);
> ?
Yes, that fixes it - aibs.ko no longer panics my machine when I load it.
Output from /var/log/messages:
Oct 14 20:32:18 kg-core1 kernel: aibs0: <ASUSTeK AI Booster (ACPI ASOC
ATK0110)> on acpi0
Oct 14 20:32:18 kg-core1 kernel: aibs0: v0: 0x06020000        Vcore Voltage  
850 /  1600
Oct 14 20:32:18 kg-core1 kernel: aibs0: v1: 0x06020001         +3.3 Voltage 
2970 /  3630
Oct 14 20:32:18 kg-core1 kernel: aibs0: v2: 0x06020002           +5 Voltage 
4500 /  5500
Oct 14 20:32:18 kg-core1 kernel: aibs0: v3: 0x06020003          +12 Voltage
10200 / 13800
Oct 14 20:32:18 kg-core1 kernel: aibs0: t0: 0x06030000      CPU Temperature  
600 /   950
Oct 14 20:32:18 kg-core1 kernel: aibs0: t1: 0x06030001       MB Temperature  
450 /   750
Oct 14 20:32:18 kg-core1 kernel: aibs0: f0: 0x06040000        CPU FAN Speed  
600 /  7200
Oct 14 20:32:18 kg-core1 kernel: aibs0: f1: 0x06040001    CHASSIS FAN Speed  
600 /  7200

it looks almost the same as it did previously:
tingo at kg-core1$ grep aibs /tmp/c1-dmesg-9.3-stable-20160826.txt
aibs0: <ASUSTeK AI Booster (ACPI ASOC ATK0110)> on acpi0
aibs0: V0: 0x06020000        Vcore Voltage   850 /  1600  0x1
aibs0: V1: 0x06020001         +3.3 Voltage  2970 /  3630  0x1
aibs0: V2: 0x06020002           +5 Voltage  4500 /  5500  0x1
aibs0: V3: 0x06020003          +12 Voltage 10200 / 13800  0x1
aibs0: T0: 0x06030000      CPU Temperature   600 /   950  0x10001
aibs0: T1: 0x06030001       MB Temperature   450 /   750  0x10001
aibs0: F0: 0x06040000        CPU FAN Speed   600 /  7200  0x10001
aibs0: F1: 0x06040001    CHASSIS FAN Speed   600 /  7200  0x10001


and from sysctl dev.aibs
root at kg-core1# sysctl dev.aibs
dev.aibs.0.volt.0: 1404 850 1600
dev.aibs.0.volt.1: 3265 2970 3630
dev.aibs.0.volt.2: 5070 4500 5500
dev.aibs.0.volt.3: 12028 10200 13800
dev.aibs.0.temp.0: 51.9C 59.9C 94.9C
dev.aibs.0.temp.1: 30.9C 44.9C 74.9C
dev.aibs.0.fan.0: 2678 600 7200
dev.aibs.0.fan.1: 2678 600 7200
dev.aibs.0.%parent: acpi0
dev.aibs.0.%pnpinfo: _HID=ATK0110 _UID=16843024
dev.aibs.0.%location: handle=\_SB_.PCI0.SBRG.ASOC
dev.aibs.0.%driver: aibs
dev.aibs.0.%desc: ASUSTeK AI Booster (ACPI ASOC ATK0110)


-- 
Torfinn Ingolfsen <torfinn.ingolfsen at getmail.no>