On 05/10/2016 15:37, Torfinn Ingolfsen wrote:> On Mon, 3 Oct 2016 23:05:48 +0300
> Andriy Gapon <avg at FreeBSD.org> wrote:
>
>> Yes, it does. Thank you!
>> It seems like a couple of minor changes are not in the source tree that
you are
>> using. One is some casts in a diagnostic printf and the other is a
different
>> rounding of 0C in Kelvins.
>> I've generated a patch that should apply to your tree:
>> https://people.freebsd.org/~avg/aibs-ggrp-gitm.93.diff
>> Please try.
>
> The patch applied cleanly (I removed the old one with patch -R first):
Good!
> /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c: In
function 'aibs_attach':
> /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:252:
warning: 's_idx' may be used uninitialized in this function
> /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:252:
note: 's_idx' was declared here
> /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:256:
warning: 'so' may be used uninitialized in this function
> /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:256:
note: 'so' was declared here
> /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:253:
warning: 'name' may be used uninitialized in this function
> /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:253:
note: 'name' was declared here
> *** [atk0110.o] Error code 1
>
> Stop in /usr/src/sys/modules/acpi/aibs.
>
> Do I have to do something more in order to build the new module?
>
Seems like this is a clang vs gcc issue as I didn't get warnings here.
Could you please simply add initialization to those variables in
aibs_attach_ggrp()?
E.g.:
s_idx = NULL;
so = NULL;
Thank you!
--
Andriy Gapon