Sean Bruno
2015-Aug-12 22:41 UTC
Possible Error in the FreeBSD 10.2 Release Notes/Man page for TCP
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 08/12/15 15:15, Glen Barber wrote:> On Wed, Aug 12, 2015 at 01:09:31PM -0500, dweimer wrote: >> I was reading through the Release notes, and decided to enable >> net.inet.tcp.pmtud_blackhole_detection in my test environment. It >> appears that the monitoring tunable >> net.inet.tcp.pmtud_blackhole_min_activated is incorrectly listed. >> Using sysctl -a | grep net.inet.tcp.pmtud, doesn't show it as a >> result. The test system is running RC3 built on the 7th from >> revision 286391 of the https://svn.freebsd.org/base/releng/10.2 >> tree. >> >> root at freebsd:/usr/src # sysctl -a | grep net.inet.tcp.pmtud >> net.inet.tcp.pmtud_blackhole_mss: 1200 >> net.inet.tcp.pmtud_blackhole_failed: 0 >> net.inet.tcp.pmtud_blackhole_activated_min_mss: 0 >> net.inet.tcp.pmtud_blackhole_activated: 0 >> net.inet.tcp.pmtud_blackhole_detection: 1 >> >> I did confirm that the pmtud_blackhole_min_activated option is >> also listed in the tcp(4) man page page as well. >> >> If anyone is more familiar with this than I am can they look into >> seeing if there is indeed an error, or if I am missing something >> here. >> > > This appears to be an error based on the content of the commit > log. I will confirm with the person that committed the code, and > will note the findings in the 10.2-RELEASE errata document. > > Glen >This looks like I failed to MFC r276345 to stable 10 in order to update tcp.4 leading to this confusion. sean -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJVy8uPXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kfV0H/jluKnznRLif5znvcy/4yNuE 1uP2pG3dyxJXK2GgCSb8gmyO3bM4Wn3C+BVYcPt3hC86koudyAB3edNUYKQ3qjzg H3cYWK/IY6mCzblBKm1WRRpleISjWtQgfjAXwJs1VlSgobtIIqmGqj2ksOiye1FB 1okLFqCMq/Gb2arHVD7jiRyVU8RqRLagCu9xNfKcn+xo79ietluAdpxZosW+wovJ RqNLLy55O7tW7c97KGCi/Rot6eb5tLotGJxjwnkMkxecizfGc26WIZVWZSF+9B4g ctYFiyZ1mL2sRmH+nhV7tbDyzoCA++yj3jLzbysnziXmicBeAchyjwvhJ2Xp1Oo=Q+HE -----END PGP SIGNATURE-----
Glen Barber
2015-Aug-12 22:43 UTC
Possible Error in the FreeBSD 10.2 Release Notes/Man page for TCP
On Wed, Aug 12, 2015 at 03:41:21PM -0700, Sean Bruno wrote:> On 08/12/15 15:15, Glen Barber wrote: > > On Wed, Aug 12, 2015 at 01:09:31PM -0500, dweimer wrote: > >> I was reading through the Release notes, and decided to enable > >> net.inet.tcp.pmtud_blackhole_detection in my test environment. It > >> appears that the monitoring tunable > >> net.inet.tcp.pmtud_blackhole_min_activated is incorrectly listed. > >> Using sysctl -a | grep net.inet.tcp.pmtud, doesn't show it as a > >> result. The test system is running RC3 built on the 7th from > >> revision 286391 of the https://svn.freebsd.org/base/releng/10.2 > >> tree. > >> > >> root at freebsd:/usr/src # sysctl -a | grep net.inet.tcp.pmtud > >> net.inet.tcp.pmtud_blackhole_mss: 1200 > >> net.inet.tcp.pmtud_blackhole_failed: 0 > >> net.inet.tcp.pmtud_blackhole_activated_min_mss: 0 > >> net.inet.tcp.pmtud_blackhole_activated: 0 > >> net.inet.tcp.pmtud_blackhole_detection: 1 > >> > >> I did confirm that the pmtud_blackhole_min_activated option is > >> also listed in the tcp(4) man page page as well. > >> > >> If anyone is more familiar with this than I am can they look into > >> seeing if there is indeed an error, or if I am missing something > >> here. > >> > > > > This appears to be an error based on the content of the commit > > log. I will confirm with the person that committed the code, and > > will note the findings in the 10.2-RELEASE errata document. > > > > This looks like I failed to MFC r276345 to stable 10 in order to > update tcp.4 leading to this confusion. >Thank you for confirming. I'll update the 10.2-RELEASE errata accordingly. What should the proper sysctls be, for completeness? Glen -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20150812/33f2ba76/attachment.bin>