freebsd stable - May 2015 - vt_core.c vt_is_cursor_in_area different behavior after r282823

Hi,

after r282823, new vt_is_cursor_in_area is, in some cases, returning
different values than the old function.

For example:
If (my + vd->vd_mcursor->height) is equal to (area->tr_begin.tp_row),
old function will return 1 and new function will return 0.

Is this intended behavior or is it a bug?

BR,
Marko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL:
<http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20150513/0a10411f/attachment.sig>

On 13 May 2015 at 03:02, Marko Turk <markoml at markoturk.info>
wrote:
> Hi,
>
> after r282823, new vt_is_cursor_in_area is, in some cases, returning
> different values than the old function.
>
> For example:
> If (my + vd->vd_mcursor->height) is equal to
(area->tr_begin.tp_row),
> old function will return 1 and new function will return 0.
>
> Is this intended behavior or is it a bug?
Thanks for the detailed look at the change! It's intentional -- when
they're equal the cursor rectangle and display area rectangle border
each other, but do not actually overlap. It doesn't hurt to return 1
in this case, it just results in some unnecessary drawing.