Kimmo Paasiala
2013-Feb-04 22:36 UTC
stable/9 r245439 breaks security/pam_ssh_agent_auth on stable/9 (WAS: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9)
On Sun, Feb 3, 2013 at 7:22 PM, Chris Rees <crees at freebsd.org> wrote:> On 3 February 2013 17:15, Stefan Bethke <stb at lassitu.de> wrote: >> >> Am 03.02.2013 um 10:57 schrieb Chris Rees <crees at FreeBSD.org>: >> >>> On 3 February 2013 03:55, Kimmo Paasiala <kpaasial at gmail.com> wrote: >>>> >>>> There is no PR yet with my fix and therefor no commit to ports tree >>>> that would fix the problem. I'll file a PR soon (TM). >>> >>> The problem was in base, and is fixed there. >> >> Huh? With -current r246283, I still get a segfault from sudo unless I have Kimmo's patch. >> >> Is there some confusion about which problem is addressed by Kimmo's patch? >> > > Hm, perhaps it might be necessary then. > > Kimmo, please would you submit the patch you had as a PR? I'm sure > Wesley would appreciate the hint. > > ChrisI'll file a PR when I have recovered from a nasty flu. Right now I'm not fit for thinking... I changed the title of this thread to a better one. -Kimmo
Kimmo Paasiala
2013-Feb-05 18:09 UTC
stable/9 r245439 breaks security/pam_ssh_agent_auth on stable/9 (WAS: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9)
On Tue, Feb 5, 2013 at 12:36 AM, Kimmo Paasiala <kpaasial at gmail.com> wrote:> On Sun, Feb 3, 2013 at 7:22 PM, Chris Rees <crees at freebsd.org> wrote: >> On 3 February 2013 17:15, Stefan Bethke <stb at lassitu.de> wrote: >>> >>> Am 03.02.2013 um 10:57 schrieb Chris Rees <crees at FreeBSD.org>: >>> >>>> On 3 February 2013 03:55, Kimmo Paasiala <kpaasial at gmail.com> wrote: >>>>> >>>>> There is no PR yet with my fix and therefor no commit to ports tree >>>>> that would fix the problem. I'll file a PR soon (TM). >>>> >>>> The problem was in base, and is fixed there. >>> >>> Huh? With -current r246283, I still get a segfault from sudo unless I have Kimmo's patch. >>> >>> Is there some confusion about which problem is addressed by Kimmo's patch? >>> >> >> Hm, perhaps it might be necessary then. >> >> Kimmo, please would you submit the patch you had as a PR? I'm sure >> Wesley would appreciate the hint. >> >> Chris > > I'll file a PR when I have recovered from a nasty flu. Right now I'm > not fit for thinking... > > I changed the title of this thread to a better one. > > -KimmoIt looks like the port was updated just recently to a new version that has its own problems that are no longer related strnvis(3). I'll have to give up for now. (freebsd-ports added to cc:) -Kimmo
Kimmo Paasiala
2013-Feb-20 15:34 UTC
stable/9 r245439 breaks security/pam_ssh_agent_auth on stable/9 (WAS: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9)
On Wed, Feb 6, 2013 at 12:28 AM, Stefan Bethke <stb at lassitu.de> wrote:> > Am 05.02.2013 um 23:06 schrieb Stefan Bethke <stb at lassitu.de>: > >> Am 05.02.2013 um 19:09 schrieb Kimmo Paasiala <kpaasial at gmail.com>: >> >>> On Tue, Feb 5, 2013 at 12:36 AM, Kimmo Paasiala <kpaasial at gmail.com> wrote: >>>> On Sun, Feb 3, 2013 at 7:22 PM, Chris Rees <crees at freebsd.org> wrote: >>>>> On 3 February 2013 17:15, Stefan Bethke <stb at lassitu.de> wrote: >>>>>> >>>>>> Am 03.02.2013 um 10:57 schrieb Chris Rees <crees at FreeBSD.org>: >>>>>> >>>>>>> On 3 February 2013 03:55, Kimmo Paasiala <kpaasial at gmail.com> wrote: >>>>>>>> >>>>>>>> There is no PR yet with my fix and therefor no commit to ports tree >>>>>>>> that would fix the problem. I'll file a PR soon (TM). >>>>>>> >>>>>>> The problem was in base, and is fixed there. >>>>>> >>>>>> Huh? With -current r246283, I still get a segfault from sudo unless I have Kimmo's patch. >>>>>> >>>>>> Is there some confusion about which problem is addressed by Kimmo's patch? >>>>>> >>>>> >>>>> Hm, perhaps it might be necessary then. >>>>> >>>>> Kimmo, please would you submit the patch you had as a PR? I'm sure >>>>> Wesley would appreciate the hint. >>>>> >>>>> Chris >>>> >>>> I'll file a PR when I have recovered from a nasty flu. Right now I'm >>>> not fit for thinking... >>>> >>>> I changed the title of this thread to a better one. >>>> >>>> -Kimmo >>> >>> It looks like the port was updated just recently to a new version that >>> has its own problems that are no longer related strnvis(3). I'll have >>> to give up for now. >>> >>> (freebsd-ports added to cc:) >> >> I can confirm that with the new port version on a two day old current, the module doesn't work: >> $ uname -a >> FreeBSD freebsd-current.lassitu.de 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r246283: Sun Feb 3 16:55:16 CET 2013 root at freebsd-current.lassitu.de:/usr/obj/usr/src/sys/GENERIC amd64 >> $ pkg info|grep pam >> pam_ssh_agent_auth-0.9.4 PAM module which permits authentication via ssh-agent >> $ sudo ls >> sudo: unable to initialize PAM: No error: 0 >> >> If I downgrade to the previous port version (and apply Kimmo's patch), it's working properly. > > > Here's a slightly different error message on 9-stable: > $ uname -a > FreeBSD diesel.lassitu.de 9.1-STABLE FreeBSD 9.1-STABLE #7 r245996: Sun Jan 27 22:36:05 CET 2013 root at diesel.lassitu.de:/usr/obj/usr/src/sys/DIESEL amd64 > stb at diesel:~$ sudo ls > sudo: unable to initialize PAM: No such file or directory > > > Stefan > > -- > Stefan Bethke <stb at lassitu.de> Fon +49 151 14070811 > > >Latest version pam_ssh_agent_auth-0.9.4_1 seems to finally work without any extra patches when built on a 9.1-RELEASE system. -Kimmo