freebsd stable - Jun 2012 - ggate problem

Hi list,

I encoutered a panic with ggatec :
I misconfigured gg.exports on the server with bad IP address for allowed 
client. Resulting a panic when creating ggatec on the client.
Investigating the panic a I discovered at line 362 in g_gatec.c, the 
ggio->gctl_sectorsize variable is not checked to be > 0 resulting a 
"Fatal trap 18: integer divide fault while in kernel mode", thus
because
there is no ggated allowed for my client IP (in my misconfigured 
gg.exports) in my case.

It would be better to check before the 'if' at line 362, that the 
partition we are trying to import with ggatec is available and otherwise 
give an explicit warning instead of letting the kernel panicing.

Sorry for my bad english and the poor description of the problem

David

On Sat, Jun 16, 2012 at 11:14:50PM +0200, David ROFFIAEN
wrote:
> Hi list,
> 
> I encoutered a panic with ggatec :
> I misconfigured gg.exports on the server with bad IP address for
> allowed client. Resulting a panic when creating ggatec on the
> client.
> Investigating the panic a I discovered at line 362 in g_gatec.c, the
> ggio->gctl_sectorsize variable is not checked to be > 0 resulting a
> "Fatal trap 18: integer divide fault while in kernel mode", thus
> because there is no ggated allowed for my client IP (in my
> misconfigured gg.exports) in my case.
> 
> It would be better to check before the 'if' at line 362, that the
> partition we are trying to import with ggatec is available and
> otherwise give an explicit warning instead of letting the kernel
> panicing.
> 
I'm unable to reproduce this.

It would be best if you provide:
- version of your system
- your gg.exports config
- exact ggatec command you ran
- backtrace from the panic

-- 
Mateusz Guzik <mjguzik gmail.com>