freebsd stable - May 2012 - Make buildkernel fails on /usr/src/sys/dev/ata/atapi-cam.c

After a successful "make buildworld" with newly updated source tree,
"make buildkernel" failed on atapi-cam.c :

Ending lines of my buildkernel.log are

cc -shared -nostdlib hack.c -o hack.So
rm -f hack.c
MAKE=make sh /usr/src/sys/conf/newvers.sh SANDY
cc -c -O2 -frename-registers -pipe -fno-strict-aliasing  -std=c99 -g -Wall
-Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes
-Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign
-fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option  
-nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL
-DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common
-finline-limit=8000 --param inline-unit-growth=100 --param
large-function-growth=1000  -fno-omit-frame-pointer -mcmodel=kernel
-mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables
-ffreestanding -fstack-protector -Werror  vers.c
linking kernel.debug
atapi-cam.o: In function `atapi_action':
/usr/src/sys/dev/ata/atapi-cam.c:436: undefined reference to
`ata_controlcmd'
/usr/src/sys/dev/ata/atapi-cam.c:651: undefined reference to
`ata_queue_request'
*** Error code 1

Stop in /usr/obj/usr/src/sys/SANDY.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.
(end of quoted text)

Is this a known problem?  This is on RELENG_9  and just a couple hours ago.

Tom

On Fri, May 18, 2012 at 02:02:02PM -0400, Thomas Mueller
wrote:
> After a successful "make buildworld" with newly updated source
tree, "make buildkernel" failed on atapi-cam.c :
> ... 
> Is this a known problem?  This is on RELENG_9  and just a couple hours ago.
> ...
My daily stable/9 build (& boot) was successful at r235604:

FreeBSD g1-227.catwhisker.org 9.0-STABLE FreeBSD 9.0-STABLE #162 235604M: Fri
May 18 04:39:02 PDT 2012    
root@g1-227.catwhisker.org:/usr/obj/usr/src/sys/CANARY  i386

Peace,
david
-- 
David H. Wolfskill				david@catwhisker.org
Depriving a girl or boy of an opportunity for education is evil.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url :
http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20120518/5f7f812f/attachment.pgp

On Fri, May 18, 2012 at 11:02 AM, Thomas Mueller
<mueller23@insightbb.com> wrote:
> After a successful "make buildworld" with newly updated source
tree, "make buildkernel" failed on atapi-cam.c :
>
> Ending lines of my buildkernel.log are
>
> cc -shared -nostdlib hack.c -o hack.So
> rm -f hack.c
> MAKE=make sh /usr/src/sys/conf/newvers.sh SANDY
> cc -c -O2 -frename-registers -pipe -fno-strict-aliasing ?-std=c99 -g -Wall
-Wredundant-decls -Wnested-externs -Wstrict-prototypes ?-Wmissing-prototypes
-Wpointer-arith -Winline -Wcast-qual ?-Wundef -Wno-pointer-sign
-fformat-extensions ?-Wmissing-include-dirs -fdiagnostics-show-option ?
-nostdinc ?-I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL
-DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common
-finline-limit=8000 --param inline-unit-growth=100 --param
large-function-growth=1000 ?-fno-omit-frame-pointer -mcmodel=kernel
-mno-red-zone -mno-mmx -mno-sse -msoft-float ?-fno-asynchronous-unwind-tables
-ffreestanding -fstack-protector -Werror ?vers.c
> linking kernel.debug
> atapi-cam.o: In function `atapi_action':
> /usr/src/sys/dev/ata/atapi-cam.c:436: undefined reference to
`ata_controlcmd'
> /usr/src/sys/dev/ata/atapi-cam.c:651: undefined reference to
`ata_queue_request'
> *** Error code 1
>
> Stop in /usr/obj/usr/src/sys/SANDY.
> *** Error code 1
>
> Stop in /usr/src.
> *** Error code 1
>
> Stop in /usr/src.
> (end of quoted text)
>
> Is this a known problem? ?This is on RELENG_9 ?and just a couple hours ago
Do you have 'device ata' in your kernel?

Is 'option ATA_CAM' in it? I don't know how atapi-cam plays with
ATA_CAM.
-- 
R. Kevin Oberman, Network Engineer
E-mail: kob6558@gmail.com

> My daily stable/9 build (& boot) was successful at r235604:
> FreeBSD g1-227.catwhisker.org 9.0-STABLE FreeBSD 9.0-STABLE #162 235604M:
Fri May 18 04:39:02 PDT 2012
> +root@g1-227.catwhisker.org:/usr/obj/usr/src/sys/CANARY  i386
> Peace,
> david
> --
> David H. Wolfskill                              david@catwhisker.org
So maybe I just need to csup again and try again, "make buildworld"
followed by "make buildkernel"?

Where do you find the number r235604 either in the built-and-installed system or
the source tree?

I looked in /usr/src/sys/conf/newvers.sh and some other files.
> From Marcelo Gondim <gondim@bsdinfo.com.br>:
> You are using GENERIC kernel or custom kernel?
> You have "options         ATA_CAM" in your kernel conf?
It's a custom kernel, config file named SANDY, as in Intel Sandy Bridge.

Sure, I have "options ATA_CAM", believe that is necessary to be able
to burn CDs or DVDs with a SATA drive.

That was discussed in a few past threads on questions@freebsd.org .

Tom

> My daily stable/9 build (& boot) was successful at r235604:
> FreeBSD g1-227.catwhisker.org 9.0-STABLE FreeBSD 9.0-STABLE #162 235604M:
Fri May 18 04:39:02 PDT 2012
> +root@g1-227.catwhisker.org:/usr/obj/usr/src/sys/CANARY  i386
> Peace,
> david
> --
> David H. Wolfskill                              david@catwhisker.org
So maybe I just need to csup again and try again, "make buildworld"
followed by "make buildkernel"?

Where do you find the number r235604 either in the built-and-installed system or
the source tree?

I looked in /usr/src/sys/conf/newvers.sh and some other files.
> That's nice, but do you have 'device ata' in the configuration?
It is
> required, even with ATA_CAM.
> Also, the thread states that atapicam is not needed with ATA_CAM. I
> don't have atapicam it in my kernel and my SATA CD/DVD drive works
> just fine.
> --
> R. Kevin Oberman, Network Engineer
I had both 'device ata' and 'device atapicam' in kernel
configuration, in accordance with online FreeBSD Handbook:
> 19.6.9 Using the ATAPI/CAM Driver
> Contributed by Marc Fonvieille.
> This driver allows ATAPI devices (CD-ROM, CD-RW, DVD drives etc...) to be
accessed through the SCSI subsystem, and so allows the use of applications like
sysutils/cdrdao or cdrecord(1).
> To use this driver, you will need to add the following line to the
/boot/loader.conf file:
> atapicam_load="YES"
> then, reboot your machine.
>     Note: If you prefer to statically compile the atapicam(4) support in
your kernel, you will have to add this line to your kernel configuration file:
>     device atapicam
>     You also need the following lines in your kernel configuration file:
>     device ata
>     device scbus
>     device cd
>     device pass
>     which should already be present. Then rebuild, install your new kernel,
and reboot your machine.
But there was nothing about 'options ATA_CAM', which I included.  Maybe
you had atapicam kernel module which loaded in the absence of 'device
atapicam' in kernel config?

Now I see in /usr/src/sys/conf/NOTES, ATA_CAM deprecates all ata drivers
including atapicam.  So maybe I need to delete or put '# ' in front of
'device atapicam' in kernel config?  But it worked building 9.0_STABLE
#6 from 9.0_RELEASE.

One other thing I could do would be to exclude module ulpt due to idiosyncrasies
of HP printers and hplip.

Reason for upgrading to STABLE was spontaneous reboots in 9.0_RELEASE, like
maybe once in 48 hours, plus modern hardware needing the latest driver updates.

Tom