Hi,
I have added these device IDs to pucdata.c to support the Moxa CP-112UL board
family.
Should I submit a problem report, or is there an easier way to get the patch
merged?
(I care about 8-STABLE at the moment ?)
Thanks,
Jan Mikkelsen
==== //depot/vendor/freebsd/8.2/src/sys/dev/puc/pucdata.c#4 (text) ===
@@ -523,6 +523,12 @@
PUC_PORT_4S, 0x18, 0, 8,
},
+ { 0x1393, 0x1120, 0xffff, 0,
+ "Moxa Technologies, CP-112UL family",
+ DEFAULT_RCLK * 8,
+ PUC_PORT_2S, 0x18, 0, 8,
+ },
+
{ 0x1393, 0x1141, 0xffff, 0,
"Moxa Technologies, Industio CP-114",
DEFAULT_RCLK * 8,
On 11 August 2011 07:55, Jan Mikkelsen <janm@transactionware.com> wrote:> Hi, > > I have added these device IDs to pucdata.c to support the Moxa CP-112UL board family. > > Should I submit a problem report, or is there an easier way to get the patch merged?The "right" way is to get a PR submitted, then chase it up with the maintainer of that subsystem. Adrian
on 11/08/2011 07:25 Adrian Chadd said the following:> On 11 August 2011 07:55, Jan Mikkelsen <janm@transactionware.com> wrote: >> Hi, >> >> I have added these device IDs to pucdata.c to support the Moxa CP-112UL board family. >> >> Should I submit a problem report, or is there an easier way to get the patch merged? > > The "right" way is to get a PR submitted, then chase it up with the > maintainer of that subsystem.I usually did it in the opposite order. No need for a PR if a patch is sufficiently trivial and a developer is sufficiently responsive at the moment. -- Andriy Gapon
On Wednesday, August 10, 2011 7:55:18 pm Jan Mikkelsen wrote:> Hi, > > I have added these device IDs to pucdata.c to support the Moxa CP-112UL board family. > > Should I submit a problem report, or is there an easier way to get the patch merged? > > (I care about 8-STABLE at the moment ?) > > Thanks, > > Jan MikkelsenCommitted to HEAD, will MFC in a week or so, thanks! -- John Baldwin