David Wolfskill
2009-Dec-19 13:35 UTC
Failure during GENERIC (i386) kernel build at r200721
Attempted clean kernel build, running FreeBSD freebeast.catwhisker.org 7.2-STABLE FreeBSD 7.2-STABLE #11 r200664: Fri Dec 18 05:18:46 PST 2009 root@freebeast.catwhisker.org:/common/S2/obj/usr/src/sys/GENERIC i386 [Immediately following a "make buldworld"...]>>> Kernel build for GENERIC started on Sat Dec 19 05:05:56 PST 2009...>>> stage 3.2: building everything... cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror /usr/src/sys/i386/i386/machdep.c cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror /usr/src/sys/i386/i386/mca.c cc1: warnings being treated as errors /usr/src/sys/i386/i386/mca.c: In function 'mca_init': /usr/src/sys/i386/i386/mca.c:510: warning: implicit declaration of function 'CPUID_TO_FAMILY' /usr/src/sys/i386/i386/mca.c:510: warning: nested extern declaration of 'CPUID_TO_FAMILY' /usr/src/sys/i386/i386/mca.c:511: warning: implicit declaration of function 'CPUID_TO_MODEL' /usr/src/sys/i386/i386/mca.c:511: warning: nested extern declaration of 'CPUID_TO_MODEL' *** Error code 1 Stop in /common/S2/obj/usr/src/sys/GENERIC. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. As a reality check: freebeast(7.2-S)[8] cd /usr/src freebeast(7.2-S)[9] grep -wnr CPUID_TO_FAMILY . ./sys/i386/i386/.svn/text-base/mca.c.svn-base:510: if (i == 0 && CPUID_TO_FAMILY(cpu_id) == 0x6 ./sys/i386/i386/.svn/text-base/mca.c.svn-base:515: if (i == 4 && CPUID_TO_FAMILY(cpu_id) >= 0xf) ./sys/i386/i386/mca.c:510: if (i == 0 && CPUID_TO_FAMILY(cpu_id) == 0x6 ./sys/i386/i386/mca.c:515: if (i == 4 && CPUID_TO_FAMILY(cpu_id) >= 0xf) ./sys/amd64/amd64/.svn/text-base/mca.c.svn-base:510: if (i == 0 && CPUID_TO_FAMILY(cpu_id) == 0x6 ./sys/amd64/amd64/.svn/text-base/mca.c.svn-base:515: if (i == 4 && CPUID_TO_FAMILY(cpu_id) >= 0xf) ./sys/amd64/amd64/mca.c:510: if (i == 0 && CPUID_TO_FAMILY(cpu_id) == 0x6 ./sys/amd64/amd64/mca.c:515: if (i == 4 && CPUID_TO_FAMILY(cpu_id) >= 0xf) freebeast(7.2-S)[10] [cut/pasted, so whitespace may not match]. Was a definition or two overlooked? Peace, david -- David H. Wolfskill david@catwhisker.org Depriving a girl or boy of an opportunity for education is evil. See http://www.catwhisker.org/~david/publickey.gpg for my public key. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20091219/976c2031/attachment.pgp
David Wolfskill
2009-Dec-19 13:50 UTC
Failure during GENERIC (i386) kernel build at r200721
I looked in my stbale/8 sources for comparison and found the definition
of CPUID_TO_FAMILY in sys/i386/include/specialreg.h.
Here's a diff comparing the stable/7 vs. the stable/8 versions of that
file:
--- /usr/src/sys/i386/include/specialreg.h 2009-12-09 04:36:55.000000000 -0800
+++ sys/i386/include/specialreg.h 2009-12-09 05:39:17.000000000 -0800
@@ -27,7 +27,7 @@
* SUCH DAMAGE.
*
* from: @(#)specialreg.h 7.1 (Berkeley) 5/9/91
- * $FreeBSD: stable/7/sys/i386/include/specialreg.h 200263 2009-12-08 15:29:12Z
avg $
+ * $FreeBSD: stable/8/sys/i386/include/specialreg.h 200262 2009-12-08 15:27:06Z
avg $
*/
#ifndef _MACHINE_SPECIALREG_H_
@@ -166,11 +166,11 @@
#define CPUID_FAMILY 0x00000f00
#define CPUID_EXT_MODEL 0x000f0000
#define CPUID_EXT_FAMILY 0x0ff00000
-#define I386_CPU_MODEL(id) \
+#define CPUID_TO_MODEL(id) \
((((id) & CPUID_MODEL) >> 4) | \
((((id) & CPUID_FAMILY) >= 0x600) ? \
(((id) & CPUID_EXT_MODEL) >> 12) : 0))
-#define I386_CPU_FAMILY(id) \
+#define CPUID_TO_FAMILY(id) \
((((id) & CPUID_FAMILY) >> 8) + \
((((id) & CPUID_FAMILY) == 0xf00) ? \
(((id) & CPUID_EXT_FAMILY) >> 20) : 0))
@@ -183,6 +183,13 @@
#define CPUID_HTT_CORES 0x00ff0000
#define CPUID_LOCAL_APIC_ID 0xff000000
+/*
+ * CPUID instruction 0xb ebx info.
+ */
+#define CPUID_TYPE_INVAL 0
+#define CPUID_TYPE_SMT 1
+#define CPUID_TYPE_CORE 2
+
/*
* AMD extended function 8000_0007h edx info
*/
Peace,
david
--
David H. Wolfskill david@catwhisker.org
Depriving a girl or boy of an opportunity for education is evil.
See http://www.catwhisker.org/~david/publickey.gpg for my public key.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url :
http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20091219/2b3a2acc/attachment.pgp
On Sat, December 19, 2009 5:35 am, David Wolfskill wrote:> Attempted clean kernel build, running > > > FreeBSD freebeast.catwhisker.org 7.2-STABLE FreeBSD 7.2-STABLE #11 r200664: Fri > Dec 18 05:18:46 PST 2009 > root@freebeast.catwhisker.org:/common/S2/obj/usr/src/sys/GENERIC i386 > > > [Immediately following a "make buldworld"...] > >>>> Kernel build for GENERIC started on Sat Dec 19 05:05:56 PST 2009 >>>> > ... > >>>> stage 3.2: building everything > ... > cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual---8<---8<---[big snip]---8<---8<--- Greetings, What are the chances you made no declaration as to your CPU type in your KERNCONF? eg; 1386 HTH --Chris H> > > Was a definition or two overlooked? > > > Peace, > david -- > David H. Wolfskill david@catwhisker.org > Depriving a girl or boy of an opportunity for education is evil. > > > See http://www.catwhisker.org/~david/publickey.gpg for my public key. > >
Michael Butler
2009-Dec-20 00:42 UTC
Failure during GENERIC (i386) kernel build at r200721
On 12/19/09 08:35, David Wolfskill wrote:> Attempted clean kernel build, running[ .. snip .. ]> /usr/src/sys/i386/i386/mca.c:510: warning: implicit declaration of function 'CPUID_TO_FAMILY' > /usr/src/sys/i386/i386/mca.c:510: warning: nested extern declaration of 'CPUID_TO_FAMILY' > /usr/src/sys/i386/i386/mca.c:511: warning: implicit declaration of function 'CPUID_TO_MODEL' > /usr/src/sys/i386/i386/mca.c:511: warning: nested extern declaration of 'CPUID_TO_MODEL'The attached patch fixes the RELENG_7 kernel build until svn 200714 gets revisited .. imb -------------- next part -------------- A non-text attachment was scrubbed... Name: mca-fix-svn200714.diff Type: text/x-diff Size: 961 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20091220/954703d0/mca-fix-svn200714.bin
on 19/12/2009 15:35 David Wolfskill said the following:> Attempted clean kernel build, running > > FreeBSD freebeast.catwhisker.org 7.2-STABLE FreeBSD 7.2-STABLE #11 r200664: Fri Dec 18 05:18:46 PST 2009 root@freebeast.catwhisker.org:/common/S2/obj/usr/src/sys/GENERIC i386 > > [Immediately following a "make buldworld"...] >>>> Kernel build for GENERIC started on Sat Dec 19 05:05:56 PST 2009 > ... >>>> stage 3.2: building everything > ... > cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror /usr/src/sys/i386/i386/machdep.c > cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror /usr/src/sys/i386/i386/mca.c > cc1: warnings being treated as errors > /usr/src/sys/i386/i386/mca.c: In function 'mca_init': > /usr/src/sys/i386/i386/mca.c:510: warning: implicit declaration of function 'CPUID_TO_FAMILY' > /usr/src/sys/i386/i386/mca.c:510: warning: nested extern declaration of 'CPUID_TO_FAMILY' > /usr/src/sys/i386/i386/mca.c:511: warning: implicit declaration of function 'CPUID_TO_MODEL' > /usr/src/sys/i386/i386/mca.c:511: warning: nested extern declaration of 'CPUID_TO_MODEL' > *** Error code 1 > > Stop in /common/S2/obj/usr/src/sys/GENERIC. > *** Error code 1 > > Stop in /usr/src. > *** Error code 1 > > Stop in /usr/src. > > > As a reality check: > > freebeast(7.2-S)[8] cd /usr/src > freebeast(7.2-S)[9] grep -wnr CPUID_TO_FAMILY . > ./sys/i386/i386/.svn/text-base/mca.c.svn-base:510: if (i == 0 && CPUID_TO_FAMILY(cpu_id) == 0x6 > ./sys/i386/i386/.svn/text-base/mca.c.svn-base:515: if (i == 4 && CPUID_TO_FAMILY(cpu_id) >= 0xf) > ./sys/i386/i386/mca.c:510: if (i == 0 && CPUID_TO_FAMILY(cpu_id) == 0x6 > ./sys/i386/i386/mca.c:515: if (i == 4 && CPUID_TO_FAMILY(cpu_id) >= 0xf) > ./sys/amd64/amd64/.svn/text-base/mca.c.svn-base:510: if (i == 0 && CPUID_TO_FAMILY(cpu_id) == 0x6 > ./sys/amd64/amd64/.svn/text-base/mca.c.svn-base:515: if (i == 4 && CPUID_TO_FAMILY(cpu_id) >= 0xf) > ./sys/amd64/amd64/mca.c:510: if (i == 0 && CPUID_TO_FAMILY(cpu_id) == 0x6 > ./sys/amd64/amd64/mca.c:515: if (i == 4 && CPUID_TO_FAMILY(cpu_id) >= 0xf) > freebeast(7.2-S)[10] > > [cut/pasted, so whitespace may not match]. > > Was a definition or two overlooked?My apologies, this is a result of me not being attentive and taking shortcuts during MFC. The breakage should be fixed as of r200742. -- Andriy Gapon