Doug Barton
2006-Sep-02 04:31 UTC
[Fwd: cvs commit: src/libexec/save-entropy save-entropy.sh]
FYI, I just MFC'ed this change to RELENG_6. I do not plan to MFC it to
RELENG_5. I believe this will help avoid the symptoms of the most common
user errors that we see complaints about on the mailing list, and my
personal mailbox.
I tested the changes thoroughly on both HEAD and RELENG_6, so I do not
anticipate any problems, but please consider this a mini-heads up.
Doug
--
This .signature sanitized for your protection
-------- Original Message --------
Subject: cvs commit: src/libexec/save-entropy save-entropy.sh
Date: Mon, 28 Aug 2006 06:41:50 +0000 (UTC)
From: Doug Barton <dougb@FreeBSD.org>
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
dougb 2006-08-28 06:41:50 UTC
FreeBSD src repository
Modified files:
libexec/save-entropy save-entropy.sh
Log:
1. Attempt to take one bullet out of the foot-shooting gun by silently
ignoring errors when sourcing rc.conf* files. The most common error
occurs when users put a command of some sort into those files.
(ifconfig is a popular choice)
2. Make the file rotation logic simpler by starting one down from
the "top" of the list, rather than at the top.
3. Try to make file rotation more secure by calling unlink(1) on all
new file names before rotating an old file to the new name, rather than
merely calling 'rm -f' on any files that exceed the number of files
to save.
Revision Changes Path
1.4 +10 -10 src/libexec/save-entropy/save-entropy.sh
http://www.FreeBSD.org/cgi/cvsweb.cgi/src/libexec/save-entropy/save-entropy.sh.diff?&r1=1.3&r2=1.4&f=h