freebsd stable - Feb 2006 - RELENG_6: serial console drops back from 115200 to 9600 baud

Hi,

I believe this MFC commit:
http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/boot/i386/libi386/comconsole.c?rev=1.10.10.1&content-type=text/x-cvsweb-markup
broke the speed-setting of the serial console at boot time, for RELENG_6.

At least for me, it doesn't set the speed to 115200 (as specified in
make.conf) anymore, it always stays at 9600, even when I put
comconsole_speed=115200 in loader.conf.

I noticed this, when I upgraded from 6.0-STABLE built around december
last year, to 6.1-PRERELEASE from last week.  The serial console on this
particular machine had been working flawlessly for years now...

There's a new comment added by the commit in this file that says:

	/*
  	 * Assume that the speed was set by an earlier boot loader if
  	 * comconsole is already the preferred console.
  	 */

whereas in the previous version it was set (hardcoded) to COMSPEED,
which in its turn came from BOOT_COMCONSOLE_SPEED in
boot/i386/libi386/Makefile.

Anyone know of a way to restore the old behaviour?  I'll experiment here
with reverting the comconsole.c file to the previous version, to see if
that helps, but a permanent solution would be better. :)

Cheers,
Dimitry


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: OpenPGP digital signature
Url :
http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20060225/d5d4e1da/signature.bin

Dimitry Andric wrote:
> whereas in the previous version it was set (hardcoded) to COMSPEED,
> which in its turn came from BOOT_COMCONSOLE_SPEED in
> boot/i386/libi386/Makefile.
> 
> Anyone know of a way to restore the old behaviour?  I'll experiment
here
> with reverting the comconsole.c file to the previous version, to see if
> that helps, but a permanent solution would be better. :)
Confirmed, putting back rev 1.10 of comconsole.c restores the old
behaviour.  My serial console runs at 115200 baud again.

I still don't get why comconsole_speed in /boot/loader.conf didn't work
with the newer revision, though...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: OpenPGP digital signature
Url :
http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20060225/6cf71e4e/signature.bin

On Sat, Feb 25, 2006 at 10:55:01PM +0100, Dimitry Andric wrote:
> Hi,
> 
> I believe this MFC commit:
>
http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/boot/i386/libi386/comconsole.c?rev=1.10.10.1&content-type=text/x-cvsweb-markup
> broke the speed-setting of the serial console at boot time, for RELENG_6.
> 
> At least for me, it doesn't set the speed to 115200 (as specified in
> make.conf) anymore, it always stays at 9600, even when I put
> comconsole_speed=115200 in loader.conf.
The way this is supposed to work is that you can put -S<speed>
in /boot.config, which gets used by boot2, and the loader then
detects that the serial console is already in use and defaults
to the existing speed.

comconsole_speed="115200" in loader.conf should override it
if you don't want to replace boot2 or change /boot.config.

I'm looking into it now.

-ed