freebsd stable - Feb 2006 - mysql50-server not starting correctly on FreeBSD 6.1-PRERELEASE (ldconfig, rcorder)

I installed mysql50-server from an up-to-date ports tree on a new server I'm
setting up running FreeBSD 6.1.  The port adds the appropriate paths to 
ldconfig, but the startup script does not require ldconfig.  This was causing 
mysqld not to start up correctly since on my system the mysql-server.sh 
script was being run before /etc/rc.d/ldconfig.  The mysql script failed with 
errors about libraries being unavailable, etc.  Running the mysql-server.sh 
script again once the system is up works fine.

I'm not entirely conversant with the new rc script syntax, but I tried
adding
"ldconfig" to the REQUIRES line of mysql-server.sh and that seems to
have
fixed the problem.

I now have two questions:

1) Is this a correct fix?

2) If so, should I file a PR with a patch or can someone just get this 
committed?

Thanks,

JN

<snip>
>
> I now have two questions:
>
> 1) Is this a correct fix?
Probably not, the correct fix would have been to cvsup your ports tree to
get the latest MySQL and then portupgrade MySQL which I'm guessing would
have fixed the problem. I'm not seeing the problem on my MySQL boxes but
then I sync the ports tree before I build.
>
> 2) If so, should I file a PR with a patch or can someone just get this
> committed?
Can't tell if it's a bug until the proper step's are done. Besudes
if you
are running an out of date port's tree the fix might have allready been
commited.

John Nielsen wrote:
> I'm not entirely conversant with the new rc script syntax, but I tried
adding
> "ldconfig" to the REQUIRES line of mysql-server.sh and that seems
to have
> fixed the problem.
Perhaps a better solution would be to replace the REQUIRE/BEFORE rows 
with a single "REQUIRE: DAEMON". What about it?

--
Alex Dupre

On Thursday 23 February 2006 03:46, Alex Dupre wrote:
> Florent Thoumie wrote:
> > Yup, since mysqld is running as root, otherwise REQUIRE: LOGIN.
>
> mysqld switch to user mysql after startup, so I guess it should require
> LOGIN.
That works here.  I removed the BEFORE line and changed REQUIRE to only 
include LOGIN:

# PROVIDE: mysql
# REQUIRE: LOGIN
# KEYWORD: shutdown

Let me know if there are any other incantations I should test.

Thanks,

JN