freebsd stable - Dec 2004 - mbuf leak in bpf.c

If one tries to write a datagram to a bpf device, and the datagram is
longer than the MTU on the physical interface, the write fails as it
should, but an mbuf is allocated and thrown away.  Proposed solution:

--- bpf.c.orig  Mon Dec 27 10:43:06 2004
+++ bpf.c       Mon Dec 27 10:44:16 2004
@@ -633,8 +633,10 @@
        if (error)
                return (error);
 
-       if (datlen > ifp->if_mtu)
+       if (datlen > ifp->if_mtu) {
+               m_freem(m);
                return (EMSGSIZE);
+       }
 
        if (d->bd_hdrcmplt)
                dst.sa_family = pseudo_AF_HDRCMPLT;

--Johnny

On Mon, Dec 27, 2004 at 12:24:49PM +0000, Johnny Eriksson wrote:
+> If one tries to write a datagram to a bpf device, and the datagram is
+> longer than the MTU on the physical interface, the write fails as it
+> should, but an mbuf is allocated and thrown away.  Proposed solution:

Committed to HEAD, thanks!

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url :
http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20041227/5df76cc4/attachment.bin